From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
robh+dt@kernel.org
Cc: krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
sboyd@kernel.org, chun-jie.chen@mediatek.com,
rex-bc.chen@mediatek.com, wenst@chromium.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] dt-bindings: arm: mt8186: Set #clock-cells as required property
Date: Wed, 18 May 2022 11:30:39 +0200 [thread overview]
Message-ID: <74b97963-3937-66fd-18e2-29278a99d706@linaro.org> (raw)
In-Reply-To: <5100b851-6787-fed8-a40f-7e6e64a123d8@collabora.com>
On 18/05/2022 11:24, AngeloGioacchino Del Regno wrote:
> Il 17/05/22 16:34, Krzysztof Kozlowski ha scritto:
>> On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
>>> This is a clock-controller binding, so it needs #clock-cells, or
>>> it would be of no use: add that to the list of required properties.
>>>
>>> Fixes: f113a51aa2cf ("dt-bindings: ARM: MediaTek: Add new document bindings of MT8186 clock")
>>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>>> ---
>>> .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml | 1 +
>>
>> If these are clock controllers and new bindings, why they were added to
>> "arm" directory? arm is only for top-level stuff, not for devices.
>>
>> In the future please put your bindings in respective subsystem matching
>> the hardware. Fallback is soc directory, not arm.
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>
> Hello Krzysztof,
>
> I agree with you about these bindings belonging to the clock directory.
> Should I add a patch to this series that moves all of the mtxxxx-clock
> and mtxxxx-sys-clock yaml files to the clock directory?
They should not be added there, but no need to shuffle things around...
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-18 9:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 10:15 [PATCH 0/6] dt-bindings: arm: MediaTek: Fix clock bindings AngeloGioacchino Del Regno
2022-05-17 10:15 ` [PATCH 1/6] dt-bindings: arm: mt8186-clock: Remove unnecessary 'items' and fix formatting AngeloGioacchino Del Regno
2022-05-17 14:30 ` Krzysztof Kozlowski
2022-05-17 10:15 ` [PATCH 2/6] dt-bindings: arm: mt8186: Set #clock-cells as required property AngeloGioacchino Del Regno
2022-05-17 14:34 ` Krzysztof Kozlowski
2022-05-18 9:24 ` AngeloGioacchino Del Regno
2022-05-18 9:30 ` Krzysztof Kozlowski [this message]
2022-05-17 10:15 ` [PATCH 3/6] dt-bindings: arm: mt8195-clock: Remove unnecessary 'items' and fix formatting AngeloGioacchino Del Regno
2022-05-17 14:31 ` Krzysztof Kozlowski
2022-05-17 10:15 ` [PATCH 4/6] dt-bindings: arm: mt8195: Set #clock-cells as required property AngeloGioacchino Del Regno
2022-05-17 14:34 ` Krzysztof Kozlowski
2022-05-17 10:15 ` [PATCH 5/6] dt-bindings: arm: mt8192-clock: Remove unnecessary 'items' AngeloGioacchino Del Regno
2022-05-17 14:31 ` Krzysztof Kozlowski
2022-05-17 15:04 ` Nícolas F. R. A. Prado
2022-05-17 10:15 ` [PATCH 6/6] dt-bindings: arm: mt8192: Set #clock-cells as required property AngeloGioacchino Del Regno
2022-05-17 14:34 ` Krzysztof Kozlowski
2022-05-17 13:39 ` [PATCH 0/6] dt-bindings: arm: MediaTek: Fix clock bindings Matthias Brugger
2022-05-17 13:43 ` AngeloGioacchino Del Regno
2022-05-17 15:05 ` Nícolas F. R. A. Prado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74b97963-3937-66fd-18e2-29278a99d706@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chun-jie.chen@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=rex-bc.chen@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).