From: Schrempf Frieder <frieder.schrempf@kontron.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"geert+renesas@glider.be" <geert+renesas@glider.be>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
Jiri Slaby <jslaby@suse.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-imx@nxp.com" <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"festevam@gmail.com" <festevam@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/3] serial: sh-sci: Remove check for specific mctrl_gpio_init() return value
Date: Fri, 2 Aug 2019 07:59:44 +0000 [thread overview]
Message-ID: <75b5875d-fa88-3995-6776-ac9a67a3de3c@kontron.de> (raw)
In-Reply-To: <20190801203902.xie5dexnsoqxxlat@pengutronix.de>
On 01.08.19 22:39, Uwe Kleine-König wrote:
> On Thu, Aug 01, 2019 at 06:45:24PM +0000, Schrempf Frieder wrote:
>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>
>> Now that the mctrl_gpio code returns NULL instead of ERR_PTR(-ENOSYS)
>> in cases when CONFIG_GPIOLIB is disabled, we can safely remove this
>> check.
>
> I would mention -ENOSYS in the Subject line. Something like:
>
> serial: sh-sci: don't check for mctrl_gpio_init returning -ENOSYS
>
> Now that the mctrl_gpio code returns NULL instead of
> ERR_PTR(-ENOSYS) if CONFIG_GPIOLIB is disabled, we can safely
> remove this check.
Indeed, I failed to come up with a better subject line. I will adopt
your proposal.
> Thanks
> Uwe
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-02 7:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 18:45 [PATCH v2 1/3] serial: mctrl_gpio: Avoid probe failures in case of missing gpiolib Schrempf Frieder
2019-08-01 18:45 ` [PATCH v2 2/3] serial: sh-sci: Remove check for specific mctrl_gpio_init() return value Schrempf Frieder
2019-08-01 20:39 ` Uwe Kleine-König
2019-08-02 7:59 ` Schrempf Frieder [this message]
2019-08-01 18:45 ` [PATCH v2 3/3] serial: 8250: " Schrempf Frieder
2019-08-01 20:33 ` [PATCH v2 1/3] serial: mctrl_gpio: Avoid probe failures in case of missing gpiolib Uwe Kleine-König
2019-08-02 7:56 ` Schrempf Frieder
2019-08-02 8:24 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75b5875d-fa88-3995-6776-ac9a67a3de3c@kontron.de \
--to=frieder.schrempf@kontron.de \
--cc=festevam@gmail.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).