From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A5F2C43218 for ; Tue, 11 Jun 2019 14:36:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 29A58206BB for ; Tue, 11 Jun 2019 14:36:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bjBdQES9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29A58206BB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4H1N1aiJeRIbXkFHvhFqP7ZhU09jqG1ceWxNNkGVFRM=; b=bjBdQES9xr+d8X KAmFq6uc6Xxo6aEjqPgmUf7rSQutePqU6pa2r+If4/7ZtnB1KeYAVG2S7c2ah5skto7j7I2KNiJKg 4dmLvw9vheT2pmk6249H/ZjjZagE7QZjTlna+GAkpQbsgwymh9k0irkh379MUQxRKZKYXKrn0DBL9 70EcH1yPSj2Syv6NEWXJaTT85Zf9grEzU08+kSU6l5n91PodG7KW5aaqIa4sDS/yWER1QSuWlvrcD iXsHY03nnJUI8WyKKThRBwuRwz5dbDvBTD/ziQTSmITEDlsnVQ+MrX7vG7oz3ULnVs+kxWJq8TZlO r4Cz0ma1EsQJe/1O9I2w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1haht3-0002Hr-Eq; Tue, 11 Jun 2019 14:36:33 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hahsU-0001pW-Dl for linux-arm-kernel@lists.infradead.org; Tue, 11 Jun 2019 14:35:59 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 75460337; Tue, 11 Jun 2019 07:35:57 -0700 (PDT) Received: from [10.1.196.129] (ostrya.cambridge.arm.com [10.1.196.129]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5103D3F557; Tue, 11 Jun 2019 07:35:56 -0700 (PDT) Subject: Re: [PATCH 4/8] iommu/arm-smmu-v3: Add support for Substream IDs To: Jonathan Cameron References: <20190610184714.6786-1-jean-philippe.brucker@arm.com> <20190610184714.6786-5-jean-philippe.brucker@arm.com> <20190611111939.000030e9@huawei.com> From: Jean-Philippe Brucker Message-ID: <75ceb6d5-9717-3945-364b-f2374a705697@arm.com> Date: Tue, 11 Jun 2019 15:35:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190611111939.000030e9@huawei.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190611_073558_564680_68833ACF X-CRM114-Status: GOOD ( 10.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, will.deacon@arm.com, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, robh+dt@kernel.org, robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/06/2019 11:19, Jonathan Cameron wrote: >> +static int arm_smmu_alloc_cd_tables(struct arm_smmu_domain *smmu_domain, >> + struct arm_smmu_master *master) >> +{ >> + struct arm_smmu_device *smmu = smmu_domain->smmu; >> + struct arm_smmu_s1_cfg *cfg = &smmu_domain->s1_cfg; >> >> - cfg->cdptr[0] = cpu_to_le64(val); >> + cfg->s1fmt = STRTAB_STE_0_S1FMT_LINEAR; >> + cfg->s1cdmax = master->ssid_bits; >> + return arm_smmu_alloc_cd_leaf_table(smmu, &cfg->table, 1 << cfg->s1cdmax); >> +} >> >> - val = cfg->cd.ttbr & CTXDESC_CD_1_TTB0_MASK; >> - cfg->cdptr[1] = cpu_to_le64(val); > > Hmm. Diff was having a field day in trying to make the patch as unreadable as possible.. Ugh, yes. This part is a bit more readable with --patience, but I'll also try to split the patch as you suggest Thanks, Jean _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel