From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, f.fainelli@gmail.com,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, broonie@kernel.org,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org, nsaenzjulienne@suse.de
Subject: Re: [PATCH v4 3/6] ASoC: audio-graph-card: Support setting component plls and sysclks
Date: Tue, 12 Jan 2021 10:22:46 +0000 [thread overview]
Message-ID: <762d798c-bd75-e24a-40fd-263f68f1a5f1@opensource.cirrus.com> (raw)
In-Reply-To: <87y2gzymc5.wl-kuninori.morimoto.gx@renesas.com>
On 12/01/2021 01:35, Kuninori Morimoto wrote:
>
> Hi Richard
>
>> Some codecs need plls and/or sysclks to be configured using the
>> snd_soc_component_set_[sysclk|pll] functions. These drivers cannot
>> necessarily be converted to use the clock framework. If the codec is on
>> a I2C/SPI bus, a nested clk_get would be needed to enable the bus clock.
>> But the clock framework does not support nested operations and this would
>> deadlock.
>>
>> This patch adds new dt properties that list phandles of components with
>> the pll/sysclk settings to be applied. Multiple settings can be given for
>> the same phandle to allow for components with multiple clocks and plls.
>> The plls and sysclks are enabled when the card bias level moves to STANDBY
>> and disabled when it moves to OFF.
>>
>> The implementation does not attempt to handle specifying complex clock
>> ordering interdependencies between components. The plls and sysclks are
>> applied to a component as it is passed to the card set_bias_level/
>> set_bias_level_post callbacks. It follows from this that the order
>> components are configured is the order that they are passed to those
>> callbacks.
>>
>> Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
>> ---
>
> As I mentioned in v3, adding *general* pll to common card driver is
> maybe difficult.
You did say that. But you did not say why.
Can you be more specific about what problem you see with adding it
to the generic driver?
> Using your own customized audio-graph-card driver is better idea,
> instead of adding code to common driver.
I just don't want to duplicate code without good reason.
>
> I think Sameer's Tegra driver (= [3/6]) is good sample for you ?
>
> https://lore.kernel.org/r/1606413823-19885-1-git-send-email-spujar@nvidia.com
>
> Thank you for your help !!
>
> Best regards
> ---
> Kuninori Morimoto
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-12 10:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 16:04 [PATCH v4 0/6] Add support for Rpi4b + Cirrus Lochnagar2 and CS47L15 Richard Fitzgerald
2021-01-08 16:04 ` [PATCH v4 1/6] of: base: Add of_count_phandle_with_fixed_args() Richard Fitzgerald
2021-01-08 16:04 ` [PATCH v4 2/6] dt-bindings: audio-graph-card: Add plls and sysclks properties Richard Fitzgerald
2021-01-13 15:22 ` Rob Herring
2021-01-13 16:09 ` Mark Brown
2021-01-15 10:35 ` Richard Fitzgerald
2021-01-15 13:11 ` Mark Brown
2021-01-15 14:42 ` Richard Fitzgerald
2021-01-15 15:20 ` Mark Brown
2021-01-15 16:15 ` Richard Fitzgerald
2021-01-15 18:35 ` Mark Brown
2021-01-14 10:31 ` Richard Fitzgerald
2021-01-14 11:14 ` Mark Brown
2021-01-08 16:04 ` [PATCH v4 3/6] ASoC: audio-graph-card: Support setting component plls and sysclks Richard Fitzgerald
2021-01-12 1:35 ` Kuninori Morimoto
2021-01-12 10:22 ` Richard Fitzgerald [this message]
2021-01-13 0:00 ` Kuninori Morimoto
2021-01-13 15:51 ` Mark Brown
2021-01-08 16:04 ` [PATCH v4 4/6] ASoC: madera: Allow codecs to be selected from kernel config Richard Fitzgerald
2021-01-08 16:05 ` [PATCH v4 5/6] ASoC: madera: Export clock config defines to dt-bindings Richard Fitzgerald
2021-01-08 16:05 ` [PATCH v4 6/6] ARM: dts: Add dts for RPi4b + Cirrus Logic Lochnagar2 + CS47L15 Richard Fitzgerald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=762d798c-bd75-e24a-40fd-263f68f1a5f1@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenzjulienne@suse.de \
--cc=patches@opensource.cirrus.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).