From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EAD9C433B4 for ; Tue, 20 Apr 2021 10:53:28 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8E5C611C9 for ; Tue, 20 Apr 2021 10:53:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8E5C611C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CT1VwhCWMRbx2WOBBmBkBLVQOHTUtflbdQH7YqYfT/w=; b=k6W9Q59IqRgAKvk1WStdM6Yy/ /2HgB5gUo71EUqjJegMdBlSCLqtVPRZMw9ALyAQTR5Obw3QFFoNve/eVyswZNCu8C9ILa0KVcYDDP th8TscQnNpvRrhQg658Bjp3onOrGUckOA8QRem/emp8vmlAaUJuyHWguVIANCdyYDjV5O0wTBjs2N R333XeV8QrBbpubyeDY9f4W7WotP58kIPUhqT9nf9HRbKas+TTi4NmxLkdJB75tHbOzQnmj3IuB8i xXWPKirFj7rJ6e+idtzqCicwlnf8egd6i2bQaWFDdTMoJ5zQ4iOfvsFipXmLuXvYIb7/zGSZI4G3B sqbAVccig==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYnyG-00Bufr-JO; Tue, 20 Apr 2021 10:51:08 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYnyC-00Bufd-Qr for linux-arm-kernel@desiato.infradead.org; Tue, 20 Apr 2021 10:51:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:CC:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=8hesSIuaVW5SB0Ri36onn983dne0vGQewCTk3OCyRXU=; b=P6AzA+f3hrwF0+j4B+V8b1JR9g Evm06rLzh1veJ6WjxANwwEQu4pdRa1De7l60mPFalHWeXuDVlLx/2gyiSIkrUVU9EeXdFphLq9Ae0 o+dHCWQ4BlqHHGiQD4KQnmp02HMxz4KjETqcLHQPTqUF5wWkOC9n0pX0oz3hlMsVe0M1eEYeNUfJp lxPdnwGGJjuu5F2aGAGglZKSVBCe9E56MNYFGTyMZf11gCOan5817RsGBLOi3V+8mha97gV6yTaXC 42LMadPdBK+DDYSul6Id4RoPoZQC/iMqvM2XPR8AP8XBZbZj/pf5NyyaYlT/MrzsoyBgzPE9eTCww vpoeB7fQ==; Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYny8-00C2bE-S1 for linux-arm-kernel@lists.infradead.org; Tue, 20 Apr 2021 10:51:03 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 13KAoclu116545; Tue, 20 Apr 2021 05:50:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1618915838; bh=8hesSIuaVW5SB0Ri36onn983dne0vGQewCTk3OCyRXU=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=PK964GQY7zQ+pMmHWS1eykT0Ix1g1QSIQSy+uevo+nsT7sfkbEs6nJhy3+vDTRTHj Clj2FhTZLFBFK6VfKJI66CJsAPTIo1CTYb/8rxFjJIL0NxPxPPfkdS39wVG8Nqj/1t P+CTo6R1Le63axYT/Ph6DRnyQ7qj1vW/pGJ3ttnk= Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 13KAockw015459 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 20 Apr 2021 05:50:38 -0500 Received: from DFLE106.ent.ti.com (10.64.6.27) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Tue, 20 Apr 2021 05:50:38 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Tue, 20 Apr 2021 05:50:38 -0500 Received: from [10.250.100.73] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 13KAoZq6028986; Tue, 20 Apr 2021 05:50:36 -0500 Subject: Re: [PATCHv2] gpio: omap: Save and restore sysconfig To: Tony Lindgren , Linus Walleij , Bartosz Golaszewski CC: , , , Aaro Koskinen , Adam Ford , Andreas Kemnade , Peter Ujfalusi References: <20210417083839.46985-1-tony@atomide.com> From: Grygorii Strashko Message-ID: <7679127b-3642-bca2-2c6c-86b60779d815@ti.com> Date: Tue, 20 Apr 2021 13:50:30 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210417083839.46985-1-tony@atomide.com> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210420_035101_079640_1A69EF03 X-CRM114-Status: GOOD ( 15.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org hi Tony, On 17/04/2021 11:38, Tony Lindgren wrote: > As we are using cpu_pm to save and restore context, we must also save and > restore the GPIO sysconfig register. This is needed because we are not > calling PM runtime functions at all with cpu_pm. > > We need to save the sysconfig on idle as it's value can get reconfigured by > PM runtime and can be different from the init time value. Device specific > flags like "ti,no-idle-on-init" can affect the init value. > > Fixes: b764a5863fd8 ("gpio: omap: Remove custom PM calls and use cpu_pm instead") > Cc: Aaro Koskinen > Cc: Adam Ford > Cc: Andreas Kemnade > Cc: Grygorii Strashko > Cc: Peter Ujfalusi > Signed-off-by: Tony Lindgren > --- > drivers/gpio/gpio-omap.c | 9 +++++++++ > include/linux/platform_data/gpio-omap.h | 3 +++ > 2 files changed, 12 insertions(+) > Thank you. Acked-by: Grygorii Strashko -- Best regards, grygorii _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel