From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA0E3C07E9C for ; Thu, 8 Jul 2021 07:41:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 796F261C88 for ; Thu, 8 Jul 2021 07:41:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 796F261C88 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=dh-electronics.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZvZ1xx0FGEB5oNEmKMCYPrT0XlB4LEPiBWTQxneya5A=; b=u+R+EdmqXnBt8F Y3R0Q4iSIqXmNn34kkjMxsqcuVVotswOOH9lrmrn+ndd8yqkxbHPUuLaCuFB3y1bXKhmzN0Mti9ca Dc/Uk/22ReHSUGNaRvNu5YWzI0LadIcjLrW5NxzPeS4vWtSXyH3dhv6PITj17vbFlruBMIFpvgRuu 0gsZM6EqP3byphO+BNuM3Gh7eJK5ajYF+ETvtGFz1jREN7GlSBm4J35vmfA6tvBznRxmUeNflyiZn U5ZgB8ckw6Y54JZbDWIOID3JbzAZtB7+wdukO4VnlUdp9MzD/eYoZxJ2Nvy0YXqplX14e0RCeFGr8 ABpNC2L/KxCYKcqxZFfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1Od5-00GDKk-HY; Thu, 08 Jul 2021 07:39:27 +0000 Received: from mx3.securetransport.de ([2a01:4f8:c0c:92be::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1Od0-00GDJq-JT for linux-arm-kernel@lists.infradead.org; Thu, 08 Jul 2021 07:39:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dh-electronics.com; s=dhelectronicscom; t=1625729936; bh=I6hrV9gGGh9EWSDwdQa1BFZFmG4AFToJMpRml3fG6Dc=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=AU54ga3u+1KPt2WRS1GZEwxQ87Vi+X8PzcfJqmogBm4BUwA6ZaVPInEzPtujW/K20 7LBpuFkJS7DKktk1tvfNcZl+bjU9umP1G2AYsa9QmUcOALuEMZ+lWCXh38ERwpKTly kkZ/Gi8eYAfA0LD1yJhS8zgajebf2wpAcymq4zIoCIJOlLeW5a9oomuKTOEvNqxJs/ r/0tEWgXoqtvDvxldUG1hg2bc1SiEJggO0TMyC2uu1KHQlQhdV8GrtNGL7jFZGAzDv Izrww2u2rMpbeC5xdZyQ8SKFe0vwchqlVDgP2vOCff8I3z8I9KJ6ASP3HqbPaRXwf0 T4yROFouy4aqw== X-secureTransport-forwarded: yes From: Christoph Niedermaier Complaints-To: abuse@cubewerk.de To: "robh+dt@kernel.org" CC: "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Shawn Guo , kernel , "festevam@gmail.com" , "Marek MV. Vasut" Subject: RE: [PATCH V2] dt-bindings: arm: fsl: Add DHCOM PicoITX and DHCOM DRC02 boards Thread-Topic: [PATCH V2] dt-bindings: arm: fsl: Add DHCOM PicoITX and DHCOM DRC02 boards Thread-Index: AQHXUXKxVloH3v/6CkGMRLXBETQyyKsBDI+AgBWQzrD//+TigIAicn3w Date: Thu, 8 Jul 2021 07:38:44 +0000 Message-ID: <76d6cc846f4f473083e597303956ff11@dh-electronics.com> References: <20210525143001.9298-1-cniedermaier@dh-electronics.com> <20210602195009.GA3870858@robh.at.kernel.org> In-Reply-To: Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210708_003923_120081_92CF2034 X-CRM114-Status: GOOD ( 23.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Marek Vasut [mailto:marex@denx.de] Sent: Wednesday, June 16, 2021 1:33 PM > On 6/16/21 1:19 PM, Christoph Niedermaier wrote: >> Send reply also to Rob Herrings +dt email address: >> >> From: Rob Herring >> Sent: Wednesday, June 2, 2021 9:50 PM >> >>> On Tue, May 25, 2021 at 04:30:01PM +0200, Christoph Niedermaier wrote: >>>> Add DH electronics DHCOM PicoITX and DHCOM DRC02 boards. >>>> >>>> Signed-off-by: Christoph Niedermaier >>>> Cc: linux-arm-kernel@lists.infradead.org >>>> Cc: linux-kernel@vger.kernel.org >>>> Cc: robh+dt@kernel.org >>>> Cc: Shawn Guo >>>> Cc: kernel@dh-electronics.com >>>> To: devicetree@vger.kernel.org >>>> --- >>>> V2: Remove line with fsl,imx6s on the DRC02 Board >>>> --- >>>> Documentation/devicetree/bindings/arm/fsl.yaml | 12 ++++++++++++ >>>> 1 file changed, 12 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml >>>> index fce2a8670b49..3c4ff79a3be7 100644 >>>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml >>>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml >>>> @@ -407,6 +407,12 @@ properties: >>>> - const: dfi,fs700e-m60 >>>> - const: fsl,imx6dl >>>> >>>> + - description: i.MX6DL DHCOM PicoITX Board >>>> + items: >>>> + - const: dh,imx6dl-dhcom-picoitx >>>> + - const: dh,imx6dl-dhcom-som >>>> + - const: fsl,imx6dl >>>> + >>>> - description: i.MX6DL Gateworks Ventana Boards >>>> items: >>>> - enum: >>>> @@ -458,6 +464,12 @@ properties: >>>> - const: toradex,colibri_imx6dl # Colibri iMX6 Module >>>> - const: fsl,imx6dl >>>> >>>> + - description: i.MX6S DHCOM DRC02 Board >>>> + items: >>>> + - const: dh,imx6s-dhcom-drc02 >>>> + - const: dh,imx6s-dhcom-som >>>> + - const: fsl,imx6dl >>> >>> fsl,imx6s? >> >> In the first version I had here an additional line with "fsl,imx6s", >> but currently the kernel isn't supporting that compatible. The i.MX6 >> Solo is currently supported by "fsl,imx6dl". So my idea was to add >> both "fsl,imx6dl" and "fsl,imx6s" to match it maybe on a later kernel >> version. If there is no match with the Solo now, it will fall back to >> the i.MX6 DualLite. That is why I had both fsl,imx6s and fsl,imx6dl >> in that order. On Fabio's advice, I removed the line with "fsl,imx6s" >> in version 2. >> Is this what you meant by your comment? > > I didn't notice that at first myself, but I think what Rob means is > > - const: dh,imx6s-dhcom-drc02 > - const: dh,imx6s-dhcom-som > - const: fsl,imx6dl <------ this should be consistent with the two above > > that is > > - const: dh,imx6s-dhcom-drc02 > - const: dh,imx6s-dhcom-som > -- const: fsl,imx6dl > +- const: fsl,imx6s > ^^^^^ > > But that is a bit odd here: > - The MX6S is MX6DL with one CPU core disabled. > - The DRC02 device can only house a SOM with MX6S and NOT with MX6DL > (due to some thermal design consideration or something). > - The kernel discerns the MX6S/MX6DL automatically based on the number > of cores it reads from some register, therefore it only has the > fsl,mx6dl compatible to cover both MX6S and MX6DL. > So, the closest fallback compatible for this device really is the MX6DL, > i.e. fsl,imx6dl. > > So I think this patch is correct as-is, no ? Is this Patch OK? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel