From: Stefan Agner <stefan@agner.ch>
To: Tony Lindgren <tony@atomide.com>
Cc: nicolas.pitre@linaro.org, andrew@lunn.ch, mans@mansr.com,
robh@kernel.org, f.fainelli@gmail.com,
gregory.clement@bootlin.com, linux@armlinux.org.uk,
krzk@kernel.org, arm@kernel.org,
bcm-kernel-feedback-list@broadcom.com,
sebastian.hesselbarth@gmail.com, jason@lakedaemon.net,
arnd@arndb.de, marc.w.gonzalez@free.fr, rjui@broadcom.com,
ssantosh@kernel.org, linux-arm-kernel@lists.infradead.org,
sbranden@broadcom.com, ard.biesheuvel@linaro.org,
ndesaulniers@google.com, linux-kernel@vger.kernel.org,
kgene@kernel.org, robin.murphy@arm.com
Subject: Re: [PATCH v2 1/3] ARM: use arch_extension directive instead of arch argument
Date: Wed, 10 Apr 2019 10:42:30 +0200 [thread overview]
Message-ID: <7798addc2c24a3a3bee2954a854335cf@agner.ch> (raw)
In-Reply-To: <20190409145042.GD2839@atomide.com>
On 09.04.2019 16:50, Tony Lindgren wrote:
> Hi,
>
> * Stefan Agner <stefan@agner.ch> [190408 20:59]:
>> --- a/arch/arm/mach-omap2/Makefile
>> +++ b/arch/arm/mach-omap2/Makefile
>> @@ -41,11 +41,6 @@ obj-$(CONFIG_SOC_OMAP5) += $(omap-4-5-common) $(smp-y) sleep44xx.o
>> obj-$(CONFIG_SOC_AM43XX) += $(omap-4-5-common)
>> obj-$(CONFIG_SOC_DRA7XX) += $(omap-4-5-common) $(smp-y) sleep44xx.o
>>
>> -plus_sec := $(call as-instr,.arch_extension sec,+sec)
>> -AFLAGS_omap-headsmp.o :=-Wa,-march=armv7-a$(plus_sec)
>> -AFLAGS_omap-smc.o :=-Wa,-march=armv7-a$(plus_sec)
>> -AFLAGS_sleep44xx.o :=-Wa,-march=armv7-a$(plus_sec)
>> -
>> # Functions loaded to SRAM
>> obj-$(CONFIG_SOC_OMAP2420) += sram242x.o
>> obj-$(CONFIG_SOC_OMAP2430) += sram243x.o
>> @@ -95,9 +90,6 @@ obj-$(CONFIG_POWER_AVS_OMAP) += sr_device.o
>> obj-$(CONFIG_POWER_AVS_OMAP_CLASS3) += smartreflex-class3.o
>>
>> AFLAGS_sleep24xx.o :=-Wa,-march=armv6
>> -AFLAGS_sleep34xx.o :=-Wa,-march=armv7-a$(plus_sec)
>> -AFLAGS_sleep33xx.o :=-Wa,-march=armv7-a$(plus_sec)
>> -AFLAGS_sleep43xx.o :=-Wa,-march=armv7-a$(plus_sec)
>
> I think we should also change the AFLAGS_sleep24xx.o above the
> same way but with armv6 flags. This can be build tested with
> omap2plus_defconfig.
From what I can tell, since those do not add the sec extension they
should work fine for LLVM's integrated assembler. But I agree, for
consistency it would be nice to get rid of them the same way too.
A bit further up, there is also:
AFLAGS_sram242x.o :=-Wa,-march=armv6
AFLAGS_sram243x.o :=-Wa,-march=armv6
I think those explicit arch definitions are not even necessary since
ARCH_OMAP2 depends on ARCH_MULTI_V6, which cannot be built with pre v6
architecture. So the minimum architecture we build for will be armv6...
In a quick test omap2plus_defconfig builds fine without those AFLAGS. I
will put it through some more testing and drop those flags in v3.
--
Stefan
>
> Regards,
>
> Tony
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-04-10 8:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 20:59 [PATCH v2 1/3] ARM: use arch_extension directive instead of arch argument Stefan Agner
2019-04-08 20:59 ` [PATCH v2 2/3] ARM: mvebu: drop unnecessary label Stefan Agner
2019-04-08 20:59 ` [PATCH v2 3/3] ARM: mvebu: prefix coprocessor operand with p Stefan Agner
2019-04-09 12:25 ` [PATCH v2 1/3] ARM: use arch_extension directive instead of arch argument Måns Rullgård
2019-04-09 15:06 ` Stefan Agner
2019-04-10 8:20 ` Stefan Agner
2019-04-09 14:50 ` Tony Lindgren
2019-04-10 8:42 ` Stefan Agner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7798addc2c24a3a3bee2954a854335cf@agner.ch \
--to=stefan@agner.ch \
--cc=andrew@lunn.ch \
--cc=ard.biesheuvel@linaro.org \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mans@mansr.com \
--cc=marc.w.gonzalez@free.fr \
--cc=ndesaulniers@google.com \
--cc=nicolas.pitre@linaro.org \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sbranden@broadcom.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=ssantosh@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).