From: Rex-BC Chen <rex-bc.chen@mediatek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
<chunkuang.hu@kernel.org>, <matthias.bgg@gmail.com>,
<robh+dt@kernel.org>
Cc: <p.zabel@pengutronix.de>, <airlied@linux.ie>, <daniel@ffwll.ch>,
<jassisinghbrar@gmail.com>, <fparent@baylibre.com>,
<yongqiang.niu@mediatek.com>, <hsinyi@chromium.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH V7 1/5] dt-bindings: display: mediatek: add aal binding for MT8183
Date: Tue, 15 Mar 2022 19:44:41 +0800 [thread overview]
Message-ID: <77ba20c7fbe42daf27696f784b46c3ad8a43ebc1.camel@mediatek.com> (raw)
In-Reply-To: <095b4dad-ade6-c742-1993-e5dc89f5cb93@canonical.com>
On Tue, 2022-03-15 at 11:56 +0100, Krzysztof Kozlowski wrote:
> On 14/03/2022 10:00, Rex-BC Chen wrote:
> > Add aal binding for MT8183.
> >
> > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> > Acked-by: Rob Herring <robh@kernel.org>
> > ---
> > .../devicetree/bindings/display/mediatek/mediatek,aal.yaml |
> > 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y
> > aml
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y
> > aml
> > index 61f0ed1e388f..6c8c83988a24 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y
> > aml
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y
> > aml
> > @@ -23,6 +23,8 @@ properties:
> > oneOf:
> > - items:
> > - const: mediatek,mt8173-disp-aal
> > + - items:
> > + - const: mediatek,mt8183-disp-aal
>
> Use enum in previous entry. This is weird setup to have items with
> one
> element and then duplicate it for another oneOf entry.
>
> > - items:
> > - enum:
> > - mediatek,mt2712-disp-aal
>
>
> Best regards,
> Krzysztof
Hello Krzysztof,
Thanks for your review.
I will modify it in next version.
BRs,
Rex
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-15 11:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 9:00 [PATCH V7 0/5] add display support for MediaTek SoC MT8186 Rex-BC Chen
2022-03-14 9:00 ` [PATCH V7 1/5] dt-bindings: display: mediatek: add aal binding for MT8183 Rex-BC Chen
2022-03-14 10:11 ` AngeloGioacchino Del Regno
2022-03-15 10:56 ` Krzysztof Kozlowski
2022-03-15 11:44 ` Rex-BC Chen [this message]
2022-03-14 9:00 ` [PATCH V7 2/5] dt-bindings: display: mediatek: revise enum to const Rex-BC Chen
2022-03-14 10:10 ` AngeloGioacchino Del Regno
2022-03-14 9:00 ` [PATCH V7 3/5] dt-bindings: display: mediatek: change to use enum for mutex Rex-BC Chen
2022-03-14 10:11 ` AngeloGioacchino Del Regno
2022-03-14 9:00 ` [PATCH V7 4/5] dt-bindings: display: mediatek: add MT8186 SoC binding Rex-BC Chen
2022-03-14 10:10 ` AngeloGioacchino Del Regno
2022-03-14 9:00 ` [PATCH V7 5/5] drm/mediatek: add display support for MT8186 Rex-BC Chen
2022-03-14 10:10 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77ba20c7fbe42daf27696f784b46c3ad8a43ebc1.camel@mediatek.com \
--to=rex-bc.chen@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=airlied@linux.ie \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fparent@baylibre.com \
--cc=hsinyi@chromium.org \
--cc=jassisinghbrar@gmail.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=yongqiang.niu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).