From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_ALL,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA919C433E0 for ; Wed, 10 Feb 2021 17:51:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7423C64DCF for ; Wed, 10 Feb 2021 17:51:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7423C64DCF Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amazon.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To:References: Message-ID:Date:To:From:Subject:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=I21X84E6AsRckh2G5jSkW6nBikERRNcOQEP6mEq0ZGY=; b=CYgVpIoqYqarlSmuoumVcR25f N+fmeWeo1Mfi9z03SUMtiTtV6NkauoeZQNLq78r8mbqpQH38k0hEt/aSutjFbYQenQdwsPLfThDoE W7odvnMZuqpM3jLtEhXLKWufsxsjJl8eECOxLMJy1+cRGzCnHdyLYQ6tJKRJtNe6YO5Lu6xAjet2L JwHAHtPLFTEO14whYJWNcTKfxlO0heSxlikZF2rSb02MF+qpseRR2bxplDVZixyalN1I3uIfInbhC WUvlonsRDPgGzssYBRiMR5jikX4pLVX5HtOGfviTpXg8ZLJWw79PO3XoYZruc4xJp6X/0QQwup4Cq yidNgKbag==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9tct-0007vf-Au; Wed, 10 Feb 2021 17:50:07 +0000 Received: from smtp-fw-4101.amazon.com ([72.21.198.25]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9tcq-0007ue-Eh for linux-arm-kernel@lists.infradead.org; Wed, 10 Feb 2021 17:50:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.co.uk; i=@amazon.co.uk; q=dns/txt; s=amazon201209; t=1612979404; x=1644515404; h=from:to:cc:date:message-id:references:in-reply-to: content-id:mime-version:content-transfer-encoding:subject; bh=5RwsGI+G2DMh/LT3LUkOrjh5XVrq5GYltMUWmHdYBhA=; b=WvMaw0ksR6GBrQ0gFzu5q+ZxcbAa73SdPf+4njiUi0LFQtJSV2X0UROs yY8G5wKDWJTZkA0So07F5yH6QnCVwjTGcLJA4QCqXZUwf8+RNWcZFkRNg qJnaX1cRxgGweDxFM5z122qOI+SKoaQU3A4YUTXBvVPqOLsMbw31DW7e6 M=; X-IronPort-AV: E=Sophos;i="5.81,168,1610409600"; d="scan'208";a="81713523" Subject: Re: [PATCH] arm/xen: Don't probe xenbus as part of an early initcall Thread-Topic: [PATCH] arm/xen: Don't probe xenbus as part of an early initcall Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-2b-859fe132.us-west-2.amazon.com) ([10.43.8.2]) by smtp-border-fw-out-4101.iad4.amazon.com with ESMTP; 10 Feb 2021 17:49:53 +0000 Received: from EX13D37EUA001.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-2b-859fe132.us-west-2.amazon.com (Postfix) with ESMTPS id 37CA122017C; Wed, 10 Feb 2021 17:49:52 +0000 (UTC) Received: from EX13D08UEB001.ant.amazon.com (10.43.60.245) by EX13D37EUA001.ant.amazon.com (10.43.165.212) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 10 Feb 2021 17:49:50 +0000 Received: from EX13D08UEB001.ant.amazon.com ([10.43.60.245]) by EX13D08UEB001.ant.amazon.com ([10.43.60.245]) with mapi id 15.00.1497.010; Wed, 10 Feb 2021 17:49:49 +0000 From: "Woodhouse, David" To: "julien@xen.org" , "xen-devel@lists.xenproject.org" Thread-Index: AQHW/89FvDxsOsmt+E6oHHLpfjI51qpRqqKA Date: Wed, 10 Feb 2021 17:49:49 +0000 Message-ID: <7858866d099732baf56e395a627f610968d24a7d.camel@amazon.co.uk> References: <20210210170654.5377-1-julien@xen.org> In-Reply-To: <20210210170654.5377-1-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.160.207] Content-ID: <873FCF2D6172CE4BBDD0A453F0DDE074@amazon.com> MIME-Version: 1.0 Precedence: Bulk X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210210_125004_859673_A91AED5B X-CRM114-Status: GOOD ( 21.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "jgross@suse.com" , "sstabellini@kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , "Grall, Julien" , "iwj@xenproject.org" , "boris.ostrovsky@oracle.com" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2021-02-10 at 17:06 +0000, Julien Grall wrote: > From: Julien Grall > > After Commit 3499ba8198cad ("xen: Fix event channel callback via > INTX/GSI"), xenbus_probe() will be called too early on Arm. This will > recent to a guest hang during boot. > > If there hang wasn't there, we would have ended up to call > xenbus_probe() twice (the second time is in xenbus_probe_initcall()). > > We don't need to initialize xenbus_probe() early for Arm guest. > Therefore, the call in xen_guest_init() is now removed. > > After this change, there is no more external caller for xenbus_probe(). > So the function is turned to a static one. Interestingly there were two > prototypes for it. > > Fixes: 3499ba8198cad ("xen: Fix event channel callback via INTX/GSI") > Reported-by: Ian Jackson > Signed-off-by: Julien Grall Reviewed-by: David Woodhouse Cc: stable@vger.kernel.org Amazon Development Centre (London) Ltd. Registered in England and Wales with registration number 04543232 with its registered office at 1 Principal Place, Worship Street, London EC2A 2FA, United Kingdom. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel