From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3EED6C433F5 for ; Mon, 31 Jan 2022 15:36:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=frNXr0dN4un0Q3W146gqXTvor3ylytozTTm/nq9+Djg=; b=nhN6y2hSwZ/VEq wRJqs1uZgqXFmOY6R6z262Nt2HPOyjIo4D2bySzkyikMYV2pttV1Vl2ssTUdoBq1yCIX++e2RoFHi TPMzyK91VFchKIORBnd5UU0wFOBUYU4F1VlWi6k4bouSd0WPJLvSBuo5xbNTgZZ5Ned+B0J8A4xe3 b0fMCc3WalC5/r2f8w+jlIbLpwQynDK+iTf92hiSxZkmHxAql+1njgpiphupNLhmazremM8hXi58R UWd3jzEEnjCF6y+WVRocAFPmp4Z/TQIx4XpFTBxPIs9n1mUGMs/d857kf4ygx2u3FT6dq15y9zYYC xaZkGv6I4KWNrr3o1TNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEYiD-009hKB-8x; Mon, 31 Jan 2022 15:35:25 +0000 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEYi9-009hJQ-2M for linux-arm-kernel@lists.infradead.org; Mon, 31 Jan 2022 15:35:23 +0000 Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 2CD7F3F1E9 for ; Mon, 31 Jan 2022 15:35:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1643643319; bh=Z5b/EBNw9uOt5Huvnc3qpF7pqyx4e7DzrtSCyAXGzd0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=b5bQdf95YzBLarC7FApKHouhzqdNZA0cBvLdwL+Ukig92iFlScZGVR6Ii81Ixdxxa uuTjO00tWSm3UEl36EpfV2h+vvEGPOK8Fhc14wmfymk1Or1WALW6PFHq8MLcikZz4h 9gw+ILW84M18gehjhnwKxpNrjxZD1p/wGMhT4nyaDsH1EH+RHFIjjd06VaC2NPRUYF k5DdtjCvbh4+71/ymPwwoq/i1uhSG26VrpcZsAv8FMgSQ83Iemc2kEso0FyoWCkXNR QBx95te/p+qhQPMgnG2nDH6OtJXL6PFBh16Dgar4boAf65mKgxmxDn1IZV1msW0Tjv un5B89BXviXMA== Received: by mail-ej1-f69.google.com with SMTP id v2-20020a1709062f0200b006a5f725efc1so5157700eji.23 for ; Mon, 31 Jan 2022 07:35:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Z5b/EBNw9uOt5Huvnc3qpF7pqyx4e7DzrtSCyAXGzd0=; b=xcquThng29jdrrJcUe7wXu51Ne7A/Vu6at6UW33MMdTrw1n/4DtrOP3Uqj/LiC77fP SFH1OGklJ6cu77mRL8smAVWNdUQwsjKiIpxhhE/i0iWmSrSUaFo2S8KJIN3RqIijteBl mfty+EvpnxAPL++AdrQubUCZbxmUI2V0pKGGYUhRTlOcuDgsC+KsKxSbOFMtQewpbWBl X2wrM7TdM4YX4vpUqU8Tgj2N7swpxSisSBud1RAPnY7i30d0aTsiKu4wV+xCFQz13sg9 K9h0fcNwflDzW1r3FbQKjELE8SAwv3QfXwOCEfQNl3NdeVfCq/cAgRNbRnhkYyke/pV/ hGzA== X-Gm-Message-State: AOAM530f1LOOFNaSvfS3AYXH85DsV97Fs/Y/wAcCb4jOl+eOnY4ZhHMb 12rnjo488xeU1QfQXABhYpTzF0XSmXmnNIQKkKeiYQhsGQNBD2eF7aTUtzevB2qK//N7tI/zv8M PeC9mekoyPGfkhPERRApJCCEg7435CTC+JR0PQfRcp4GV6PI6g87k X-Received: by 2002:a50:ef16:: with SMTP id m22mr20906055eds.340.1643643318900; Mon, 31 Jan 2022 07:35:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJzvhi9AwQxRpZJOEpikHkJ1BPhM8MD3Qh6i+q7FjAIG86ry6+d6e16F+8z0bK3phu/eNvlQlQ== X-Received: by 2002:a50:ef16:: with SMTP id m22mr20906022eds.340.1643643318699; Mon, 31 Jan 2022 07:35:18 -0800 (PST) Received: from [192.168.0.74] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id qa30sm6667123ejc.158.2022.01.31.07.35.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Jan 2022 07:35:17 -0800 (PST) Message-ID: <7941a6b8-4bca-797e-2fa9-ebd82bed70fa@canonical.com> Date: Mon, 31 Jan 2022 16:35:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v4 7/7] arm64: dts: exynos: Add initial device tree support for Exynos7885 SoC Content-Language: en-US To: David Virag Cc: Sam Protsenko , Krzysztof Kozlowski , Rob Herring , Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , Michael Turquette , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org References: <20211206153124.427102-1-virag.david003@gmail.com> <20211206153124.427102-8-virag.david003@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20211206153124.427102-8-virag.david003@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220131_073521_376461_7B1838A3 X-CRM114-Status: GOOD ( 20.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 06/12/2021 16:31, David Virag wrote: > Add initial Exynos7885 device tree nodes with dts for the Samsung Galaxy > A8 (2018), a.k.a. "jackpotlte", with model number "SM-A530F". > Currently this includes some clock support, UART support, and I2C nodes. > > Signed-off-by: David Virag > --- > Changes in v2: > - Remove address-cells, and size-cells from dts, since they are > already in the dtsi. > - Lower case hex in memory node > - Fix node names with underscore instead of hyphen > - Fix line breaks > - Fix "-key" missing from gpio keys node names > - Use the form without "key" in gpio key labels on all keys > - Suffix pin configuration node names with "-pins" > - Remove "fimc_is_mclk" nodes from pinctrl dtsi for now > - Use macros for "samsung,pin-con-pdn", and "samsung,pin-con-pdn" > - Add comment about Arm PMU > - Rename "clock-oscclk" to "osc-clock" > - Include exynos-syscon-restart.dtsi instead of rewriting its contents > > Changes in v3: > - Fix typo (seperate -> separate) > > Changes in v4: > - Fixed leading 0x in clock-controller nodes > - Actually suffixed pin configuration node names with "-pins" > - Seperated Cortex-A53 and Cortex-A73 PMU > Hi David, I hope you are well and did not get discouraged with this patchset. The clock changes got merged, so if you fix the comments pointed here, I could merge it. One more change will be needed - use "-gpio-bank" suffix, like here: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git/commit/?h=for-v5.18/dt-pinctrl&id=71b8d1253b7fe0be0ecf79a7249389c8711f0f94 Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel