From: <Claudiu.Beznea@microchip.com>
To: <weiyongjun1@huawei.com>, <hulkci@huawei.com>,
<Cristian.Birsan@microchip.com>, <balbi@kernel.org>,
<gregkh@linuxfoundation.org>, <Nicolas.Ferre@microchip.com>,
<alexandre.belloni@bootlin.com>,
<Ludovic.Desroches@microchip.com>, <gregory.clement@bootlin.com>
Cc: linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next] usb: gadget: udc: atmel: remove unused variable 'pp'
Date: Fri, 10 Jul 2020 09:47:57 +0000 [thread overview]
Message-ID: <79b167bf-6dc9-aad0-3dca-b4d31a02379c@microchip.com> (raw)
In-Reply-To: <20200710073033.58714-1-weiyongjun1@huawei.com>
Hi,
On 10.07.2020 10:30, Wei Yongjun wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Gcc report build warning as follows:
>
> drivers/usb/gadget/udc/atmel_usba_udc.c:2106:22: warning:
> variable pp set but not used [-Wunused-but-set-variable]
> 2106 | struct device_node *pp;
> | ^~
>
This has been also proposed in series with title
"[PATCH 00/32] Fix the final bunch of W=1 issues in USB"
> After commit e78355b577c4 ("usb: gadget: udc: atmel: Don't
> use DT to configure end point"), variable 'pp' is never used,
> so removing it to avoid warning.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/usb/gadget/udc/atmel_usba_udc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
> index d69f61ff0181..a10b8d406e62 100644
> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
> @@ -2103,7 +2103,6 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev,
> {
> struct device_node *np = pdev->dev.of_node;
> const struct of_device_id *match;
> - struct device_node *pp;
> int i, ret;
> struct usba_ep *eps, *ep;
> const struct usba_udc_config *udc_config;
> @@ -2128,7 +2127,6 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev,
> GPIOD_IN);
>
> if (fifo_mode == 0) {
> - pp = NULL;
> udc->num_ep = udc_config->num_ep;
> udc->configured_ep = 1;
> } else {
> @@ -2144,7 +2142,6 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev,
>
> INIT_LIST_HEAD(&eps[0].ep.ep_list);
>
> - pp = NULL;
> i = 0;
> while (i < udc->num_ep) {
> const struct usba_ep_config *ep_cfg = &udc_config->config[i];
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-07-10 9:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 7:30 [PATCH -next] usb: gadget: udc: atmel: remove unused variable 'pp' Wei Yongjun
2020-07-10 9:47 ` Claudiu.Beznea [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79b167bf-6dc9-aad0-3dca-b4d31a02379c@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=Cristian.Birsan@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@bootlin.com \
--cc=hulkci@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).