From: Ryan Pannell <ryan@osukl.com>
To: Jagan Teki <jagan@amarulasolutions.com>,
Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
Michael Trimarchi <michael@amarulasolutions.com>,
"linux-amarula@amarulasolutions.com"
<linux-amarula@amarulasolutions.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support
Date: Wed, 6 Mar 2019 10:18:18 +0000 [thread overview]
Message-ID: <7AB137701821F94BAF7B06C1747BA691011A3FE164@OS01.os.local> (raw)
In-Reply-To: <CAMty3ZDRAqV10u7QkujxkXtJYOUX8zbxkKtb5oxJMt+2jUbaHg@mail.gmail.com>
Jagan,
The compatible is for the real hardware name as Maxime previously explained. The platform is described in the latter part.
Please use:
compatible = "oceanic,5205-5inmfd", "allwinner,sun50i-a64";
Thanks,
Ryan Pannell
Development Team Lead
Oceanic Systems (UK) Ltd
-----Original Message-----
From: Jagan Teki <jagan@amarulasolutions.com>
Sent: 06 March 2019 09:36
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Ryan Pannell <ryan@osukl.com>; Chen-Yu Tsai <wens@csie.org>; Rob Herring <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>; Michael Trimarchi <michael@amarulasolutions.com>; linux-arm-kernel <linux-arm-kernel@lists.infradead.org>; devicetree <devicetree@vger.kernel.org>; linux-kernel <linux-kernel@vger.kernel.org>; linux-amarula@amarulasolutions.com
Subject: Re: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support
On Wed, Mar 6, 2019 at 2:57 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> On Tue, Mar 05, 2019 at 04:35:04PM +0000, Ryan Pannell wrote:
> > We don't mind if it has to be:
> > compatible = "oceanic,5inmfd", "allwinner,sun50i-a64";
> >
> > However, to avoid confusion, might it be worth including the part number (We list this as '5205 5" MFD') so this would become:
> > compatible = "oceanic,5205-5inmfd", "allwinner,sun50i-a64";
> >
> > Perhaps this solves the issue. Please let me know thoughts.
>
> Yep, that works for me
A64 instead of part-number 5205 seems less confused isn't it? or we need to give more priority with real hardware definition?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-03-06 10:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 6:02 [PATCH 1/2] dt-bindings: Add vendor prefix for oceanic Jagan Teki
2019-02-26 6:02 ` [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support Jagan Teki
2019-02-27 15:33 ` Maxime Ripard
2019-02-27 16:19 ` Jagan Teki
2019-03-01 14:57 ` Maxime Ripard
2019-03-01 16:57 ` Jagan Teki
2019-03-05 15:59 ` Maxime Ripard
2019-03-05 16:07 ` Jagan Teki
2019-03-05 16:35 ` Ryan Pannell
2019-03-06 9:27 ` Maxime Ripard
2019-03-06 9:36 ` Jagan Teki
2019-03-06 10:18 ` Ryan Pannell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7AB137701821F94BAF7B06C1747BA691011A3FE164@OS01.os.local \
--to=ryan@osukl.com \
--cc=devicetree@vger.kernel.org \
--cc=jagan@amarulasolutions.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=michael@amarulasolutions.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).