Re: [PATCH v16 3/7] soc: mediatek: SVS: introduce MTK SVS engine

From: Roger Lu <roger.lu@mediatek.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
	Enric Balletbo Serra <eballetbo@gmail.com>,
	Kevin Hilman <khilman@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Nicolas Boichat <drinkcat@google.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Fan Chen <fan.chen@mediatek.com>,
	HenryC Chen <HenryC.Chen@mediatek.com>,
	YT Lee <yt.lee@mediatek.com>,
	Xiaoqing Liu <Xiaoqing.Liu@mediatek.com>,
	"Charles Yang" <Charles.Yang@mediatek.com>,
	Angus Lin <Angus.Lin@mediatek.com>,
	"Mark Rutland" <mark.rutland@arm.com>, Nishanth Menon <nm@ti.com>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH v16 3/7] soc: mediatek: SVS: introduce MTK SVS engine
Date: Fri, 14 May 2021 11:10:13 +0800	[thread overview]
Message-ID: <7a7a07adedf5d3f430fecf81aed35c6321e5b634.camel@mediatek.com> (raw)
In-Reply-To: <20210506045115.GA767398@roeck-us.net>

Hi Guenter,

Sorry for the late reply and thanks for the notice.

On Wed, 2021-05-05 at 21:51 -0700, Guenter Roeck wrote:
> On Wed, Apr 28, 2021 at 02:54:36PM +0800, Roger Lu wrote:
> > The Smart Voltage Scaling(SVS) engine is a piece of hardware
> > which calculates suitable SVS bank voltages to OPP voltage table.
> > Then, DVFS driver could apply those SVS bank voltages to PMIC/Buck
> > when receiving OPP_EVENT_ADJUST_VOLTAGE.
> > 
> > Signed-off-by: Roger Lu <roger.lu@mediatek.com>
> > ---
> >  drivers/soc/mediatek/Kconfig   |   10 +
> >  drivers/soc/mediatek/Makefile  |    1 +
> >  drivers/soc/mediatek/mtk-svs.c | 1723
> > ++++++++++++++++++++++++++++++++
> >  3 files changed, 1734 insertions(+)
> >  create mode 100644 drivers/soc/mediatek/mtk-svs.c
> > 
> 
> [ ... ]
> 
> > +
> > +	svsp_irq = irq_of_parse_and_map(svsp->dev->of_node, 0);
> > +	ret = devm_request_threaded_irq(svsp->dev, svsp_irq, NULL,
> > svs_isr,
> > +					svsp->irqflags, svsp->name,
> > svsp);
> 
> 0-day reports:
> 
> drivers/soc/mediatek/mtk-svs.c:1663:7-32: ERROR:
> 	Threaded IRQ with no primary handler requested without
> IRQF_ONESHOT
> 
> I would be a bit concerned about this. There is no primary (hard)
> interrupt handler, meaning the hard interrupt may be re-enabled after
> the default hard interrupt handler runs. This might result in endless
> interrupts.

Oh, we add IRQF_ONESHOT in "svs_get_svs_mt8183_platform_data()" for
threaded irq. So, please kindly let us know if we need to set more
flags or any other potential risks we should be aware. Thanks in
advance.

> 
> Guenter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel