From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Arnd Bergmann <arnd@arndb.de>,
Stefano Stabellini <sstabellini@kernel.org>
Cc: Emil Velikov <emil.l.velikov@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Denis Efremov <efremov@linux.com>,
linux-kernel@vger.kernel.org,
Masahiro Yamada <yamada.masahiro@socionext.com>,
xen-devel@lists.xenproject.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [Xen-devel] [PATCH] ARM: xen: unexport HYPERVISOR_platform_op function
Date: Fri, 6 Sep 2019 16:55:30 +0100 [thread overview]
Message-ID: <7abad95e-ea47-c068-d91c-ba503f2530b9@citrix.com> (raw)
In-Reply-To: <20190906153948.2160342-1-arnd@arndb.de>
On 06/09/2019 16:39, Arnd Bergmann wrote:
> HYPERVISOR_platform_op() is an inline function and should not
> be exported. Since commit 15bfc2348d54 ("modpost: check for
> static EXPORT_SYMBOL* functions"), this causes a warning:
>
> WARNING: "HYPERVISOR_platform_op" [vmlinux] is a static EXPORT_SYMBOL_GPL
>
> Remove the extraneous export.
>
> Fixes: 15bfc2348d54 ("modpost: check for static EXPORT_SYMBOL* functions")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Something is wonky. That symbol is (/ really ought to be) in the
hypercall page and most definitely not inline.
Which tree is that changeset from? I can't find the SHA.
I hate to open a separate can of worms, but why are they tagged GPL?
The Xen hypercall ABI, like the Linux syscall ABI, are specifically not
GPL. Xen has as something very similar to (and probably derived from)
the Linux-syscall-note exception.
~Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-06 15:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 15:39 [PATCH] ARM: xen: unexport HYPERVISOR_platform_op function Arnd Bergmann
2019-09-06 15:55 ` Andrew Cooper [this message]
2019-09-06 15:59 ` [Xen-devel] " Jan Beulich
2019-09-06 16:00 ` Arnd Bergmann
2019-09-06 17:20 ` Andrew Cooper
2019-09-07 10:05 ` Julien Grall
2019-10-01 14:33 ` Mark Rutland
2019-10-01 14:39 ` Julien Grall
2019-10-01 14:46 ` Mark Rutland
2019-10-01 17:38 ` Stefano Stabellini
2019-10-01 18:57 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7abad95e-ea47-c068-d91c-ba503f2530b9@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=arnd@arndb.de \
--cc=efremov@linux.com \
--cc=emil.l.velikov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).