From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8301C04A95 for ; Wed, 28 Sep 2022 17:46:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KVCV6EhrFPdz7II61RoTBK5xQxglp+RPeKBvxdfmYVI=; b=M95wLE9jQPg9V3 rwZ9g9D7icXnym+xoSKymayUaMn/l4LJenIM8oeoGzuhgCwpjMIXwZTaS9i2UPgl6C8wjGa7CB4z/ 4QEMtzoUdVad0/l/G0O1mws8UWoknwzc2VdG98MBgJJ5jiyISjN7jtcJQJaQi3EgI5v8Gn/BOmU1j C/FqCVq/wuU1R0xNzcqDqBPOLTsBlH3Bl+Rbxu58py51lbd4mwvlXjq/O9/AqVbFJenX6ORslo1Ku 4cP2ecgkxrLu2GNn9E+jRYKW08t/wMwOYLg8A+/5c1NNE2zSBGVZPPI6hvzb3/4GvV0a01oCILavf kINOjS0UQuUVb9+SKX5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odb7J-00HQmt-1P; Wed, 28 Sep 2022 17:45:05 +0000 Received: from phobos.denx.de ([2a01:238:438b:c500:173d:9f52:ddab:ee01]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odb7G-00HQlG-5L for linux-arm-kernel@lists.infradead.org; Wed, 28 Sep 2022 17:45:04 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 0FFAF84B67; Wed, 28 Sep 2022 19:44:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1664387099; bh=gaYUOXQ4C9X/kZ+ny8vPFL/2ozYC/B1B4psO3k3Bm2E=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ApiLBC8Bw+Hw9Kzi9Tetq5/m5q+LcKwerinps3C7ZutrZnqqhFtEDeL9zJWaZbra0 dTwgC4d+8bGlf8wDc7C5iZqa/+GDdFfMVNkpStogfjSEISpCn4uGQek0pN6RwqEmbr uD5JuqkeOkPHACQDWxq/71ygC9zWcAIGmyho4JTgQ5GLVDeVwm3zUGcisVit3Qxlsk FO4zBxoD67+ZLgoOg1dQmMlYmT6qVgwf+C3xxNx4gxdrMFf9p+HfkBX3+hKye0MlQ/ LuAGGRyEi3Oe8TmbHzNyZCKYuCijSWc/QlMpwF53/UPUrrgejHAMdSSGYn5Cr5mz+s yLpARcy/xjfsQ== Message-ID: <7adc3299-5dd6-fd43-fd5e-c22d150a328a@denx.de> Date: Wed, 28 Sep 2022 19:44:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2] dt-bindings: memory-controller: st,stm32: Split off MC properties To: Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org Cc: Rob Herring , Alexandre Torgue , Christophe Kerello , Linus Walleij , Maxime Coquelin , Rob Herring , devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com References: <20220926225536.548139-1-marex@denx.de> <846bc515-bdda-6022-0611-daaa9a632e64@linaro.org> <393eb833-0dcd-bf6c-49f3-ab8d60e3a8e5@linaro.org> Content-Language: en-US From: Marek Vasut In-Reply-To: <393eb833-0dcd-bf6c-49f3-ab8d60e3a8e5@linaro.org> X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220928_104502_620865_9242ABCB X-CRM114-Status: GOOD ( 18.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/28/22 19:24, Krzysztof Kozlowski wrote: > On 28/09/2022 19:01, Marek Vasut wrote: >> On 9/28/22 09:10, Krzysztof Kozlowski wrote: >> >> Hi, >> >> [...] >> >>>> diff --git a/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml b/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml >>>> index a1f535cececcc..49243f447eb90 100644 >>>> --- a/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml >>>> +++ b/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml >>>> @@ -49,143 +49,6 @@ patternProperties: >>>> "^.*@[0-4],[a-f0-9]+$": >>>> type: object >>>> >>>> - properties: >>>> - reg: >>>> - description: Bank number, base address and size of the device. >>>> - >>> >>> To be equivalent (and similar to SPI peripherals and controllers) this >>> should reference st,stm32-fmc2-ebi-props.yaml as well. >>> >>> After such reference, you can add here unevaluatedProperties:false >>> (could be same or new patch as it is not related to actual split). >> >> I don't think I understand. I don't see any ref from the controller node >> to its props in various SPI controllers (even if that would make sense): > > Because they reference spi peripheral props... > >> >> next$ git grep qspi-nor-peripheral-props.yaml >> Documentation/devicetree/bindings/spi/cdns,qspi-nor-peripheral-props.yaml:$id: >> http://devicetree.org/schemas/spi/cdns,qspi-nor-peripheral-props.yaml# >> Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml: - >> $ref: cdns,qspi-nor-peripheral-props.yaml# >> >> No ref to cdns,qspi-nor-peripheral-props.yaml in >> Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml >> >> next$ git grep tegra210-quad-peripheral-props >> Documentation/devicetree/bindings/spi/nvidia,tegra210-quad-peripheral-props.yaml:$id: >> http://devicetree.org/schemas/spi/nvidia,tegra210-quad-peripheral-props.yaml# >> Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml: - >> $ref: nvidia,tegra210-quad-peripheral-props.yaml# >> >> No ref to nvidia,tegra210-quad-peripheral-props.yaml in >> Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml > > All your examples do it - reference spi peripheral props. > > As I said, your change is now not equivalent. If any other device > appears in st,stm32-fmc2-ebi, the schema won't be applied. > > Let me put it that way: you must have there additionalProperties:false > or unevaluatedProperties:false. Once you add it, you start seeing errors > leading to missing ref. Is what you are trying to convey that Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml does ref spi-controller.yaml# and that one does patternProperties: ref: spi-peripheral-props.yaml ? So the fix for V3 should be the following ? diff --git a/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml b/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml index 49243f447eb90..0448bd07f4310 100644 --- a/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml +++ b/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml @@ -48,6 +48,7 @@ properties: patternProperties: "^.*@[0-4],[a-f0-9]+$": type: object + $ref: st,stm32-fmc2-ebi-props.yaml required: - "#address-cells" _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel