linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Michael Kao <michael.kao@mediatek.com>
To: Hsin-Yi Wang <hsinyi@chromium.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	<Ben.Tseng@mediatek.com>
Cc: <fan.chen@mediatek.com>, Zhang Rui <rui.zhang@intel.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Linux PM <linux-pm@vger.kernel.org>,
	<srv_heupstream@mediatek.com>,
	Eduardo Valentin <edubezval@gmail.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	Devicetree List <devicetree@vger.kernel.org>,
	lkml <linux-kernel@vger.kernel.org>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	"moderated list:ARM/Mediatek SoC support"
	<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH 1/1] arm64: dts: mt8183-kukui: Enable thermal Tboard
Date: Thu, 6 May 2021 13:11:44 +0800	[thread overview]
Message-ID: <7ae074f1f80d6c874e5db12d2650e301d8e4a080.camel@mediatek.com> (raw)
In-Reply-To: <CAJMQK-gXfR2Ca-Ay5fwcRgQ4F6h4xXVt1bbAL+3LFwgotwYREA@mail.gmail.com>

Hi Maintainers,

Gentle pin for this patch.

Thanks

On Fri, 2021-04-09 at 15:16 +0800, Hsin-Yi Wang wrote:
> On Fri, Apr 9, 2021 at 3:12 PM Michael Kao <michael.kao@mediatek.com>
> wrote:
> > 
> > Add Tboard thermal sensor settings.
> > 
> > pull-up voltage: 1800 mv
> > pull-up resistor: 75K
> > 
> > Vsense = pull-up voltage * Rntc / ( pull-up resistor + Rntc )
> > AuxIn = Vsense * 4096 / 1500
> > 
> > TEST=boot kukui
> >      check /sys/class/thermal/thermal_zone*/type
> >      check /sys/class/thermal/thermal_zone*/temp
> 
> the TEST lines can be removed.
> 
> > 
> > Signed-off-by: Michael Kao <michael.kao@mediatek.com>
> > Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
> > ---
> 
> Tested-by: Hsin-Yi Wang <hsinyi@chromium.org>
> 
> This removes following error:
> [   10.882325] generic-adc-thermal thermal-sensor1: Thermal zone
> sensor register failed: -19
> [   10.911912] generic-adc-thermal thermal-sensor2: Thermal zone
> sensor register failed: -19
> 
> >  arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 14 ++++++++++++++
> >  arch/arm64/boot/dts/mediatek/mt8183.dtsi       |  2 +-
> >  2 files changed, 15 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> > b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> > index bf2ad1294dd3..202acb542b12 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> > @@ -801,6 +801,20 @@
> >         status = "okay";
> >  };
> > 
> > +&thermal_zones {
> > +       Tboard1 {
> > +               polling-delay = <1000>; /* milliseconds */
> > +               polling-delay-passive = <0>; /* milliseconds */
> > +               thermal-sensors = <&tboard_thermistor1>;
> > +       };
> > +
> > +       Tboard2 {
> > +               polling-delay = <1000>; /* milliseconds */
> > +               polling-delay-passive = <0>; /* milliseconds */
> > +               thermal-sensors = <&tboard_thermistor2>;
> > +       };
> > +};
> > +
> >  &u3phy {
> >         status = "okay";
> >  };
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > index 1ad0a1d55d53..f0719dbef249 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > @@ -673,7 +673,7 @@
> >                         nvmem-cell-names = "calibration-data";
> >                 };
> > 
> > -               thermal-zones {
> > +               thermal_zones: thermal-zones {
> >                         cpu_thermal: cpu_thermal {
> >                                 polling-delay-passive = <100>;
> >                                 polling-delay = <500>;
> > --
> > 2.18.0
> > 
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      reply	other threads:[~2021-05-06  5:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-09  7:11 [PATCH 1/1] arm64: dts: mt8183-kukui: Enable thermal Tboard Michael Kao
2021-04-09  7:16 ` Hsin-Yi Wang
2021-05-06  5:11   ` Michael Kao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ae074f1f80d6c874e5db12d2650e301d8e4a080.camel@mediatek.com \
    --to=michael.kao@mediatek.com \
    --cc=Ben.Tseng@mediatek.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=edubezval@gmail.com \
    --cc=fan.chen@mediatek.com \
    --cc=hsinyi@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=srv_heupstream@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).