From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Richard Weinberger <richard@nod.at>,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-hardening@vger.kernel.org,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
Alexandre Torgue <alexandre.torgue@st.com>
Subject: Re: [PATCH 104/141] mtd: rawnand: stm32_fmc2: Fix fall-through warnings for Clang
Date: Mon, 8 Feb 2021 09:15:00 -0600 [thread overview]
Message-ID: <7c04f2a2-6787-742e-d487-ed408b698151@embeddedor.com> (raw)
In-Reply-To: <20201123093347.719a77cf@xps13>
Hi Miquel,
On 11/23/20 02:33, Miquel Raynal wrote:
> Hi Gustavo,
>
> "Gustavo A. R. Silva" <gustavoars@kernel.org> wrote on Fri, 20 Nov 2020
> 12:37:48 -0600:
>
>> In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple
>> of warnings by explicitly adding a couple of fallthrough pseudo-keywords
>> instead of letting the code fall through to the next case.
>>
>> Link: https://github.com/KSPP/linux/issues/115
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>> ---
>> drivers/mtd/nand/raw/stm32_fmc2_nand.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
>> index 550bda4d1415..002fa521036f 100644
>> --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c
>> +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
>> @@ -531,6 +531,7 @@ static int stm32_fmc2_nfc_ham_correct(struct nand_chip *chip, u8 *dat,
>> switch (b % 4) {
>> case 2:
>> bit_position += shifting;
>> + fallthrough;
>
> In patch 100, 101, 102, 103 you 'break' in this case (when the
> statement falls into the empty following statement which itself
> breaks). Please make it consistent and use break here, below, and in
> patch 132.
I'll address this and send separate patches.
> LGTM otherwise.
Thanks!
--
Gustavo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-02-08 15:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1605896059.git.gustavoars@kernel.org>
2020-11-20 18:37 ` [PATCH 098/141] mmc: sdhci-of-arasan: Fix fall-through warnings for Clang Gustavo A. R. Silva
2020-11-23 7:00 ` Michal Simek
2020-11-23 22:59 ` Gustavo A. R. Silva
2020-11-24 14:25 ` Ulf Hansson
2020-11-24 14:36 ` Gustavo A. R. Silva
2020-11-20 18:37 ` [PATCH 099/141] mt76: mt7615: " Gustavo A. R. Silva
2020-11-20 18:37 ` [PATCH 104/141] mtd: rawnand: stm32_fmc2: " Gustavo A. R. Silva
2020-11-23 8:33 ` Miquel Raynal
2021-02-08 15:15 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c04f2a2-6787-742e-d487-ed408b698151@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=alexandre.torgue@st.com \
--cc=gustavoars@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).