From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D173C6FD1F for ; Thu, 16 Mar 2023 11:35:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=z5jW9JFWaFkwRA7Cos7B8J/6Nkn3Ri74KoU1L9YC7y4=; b=Z7AwiBb5QwXAdj bZKapMkkjpiZNE/3OBzndJ9+4Uf6cUrZQMSZ2Ti3QfzwQ4B2ZgwmJsFafhWH4P/qVbi2fJMxwB5Sr 7Sa2R7U3U8uBqpZfzY/J2NmnsEVX7g9zhaRrfSYkQEH5ye5dDSE8kQUlePx7oRGAzgSgCsmZea+p2 R5XA3Goq/3tJQkobYUsiRmms3d+wuWb0LfEmYMY0V90SrCW00X1H+EzGobdkIyHVBzhPp1/vE/5b0 U0xQdqfZjLgaLxuQS8DGIOu+dpbGpdygrXHjsrAmd3YpZ6jEMOijcVIN0mhnZU7+5H0RDf906STH/ xuO/BfXzCETcKM62aG3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pclsD-00GFQA-2i; Thu, 16 Mar 2023 11:34:21 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pclsA-00GFPF-2p for linux-arm-kernel@lists.infradead.org; Thu, 16 Mar 2023 11:34:20 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 32GBYEfD080047; Thu, 16 Mar 2023 06:34:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1678966454; bh=XYYo2gC7Cqi/Od5kdMWy5Own2rBa/0vBzWGJw3l5yrY=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=ezHUZKklqyB92MLpl5Pw1IxfvdinpswpcgyUez5cb2FE2L4eFbylMZLjMYzMLyeRg R4OZKYc5Vs15VPL6ay+yJFSGXEb9unxsZ6yi3QOcWDawsdzcd0wOLeCHX85B2gSQE6 /IGdt4GkRi3VBII39aU8ZpT19YO87e23hwfSJE6E= Received: from DFLE101.ent.ti.com (dfle101.ent.ti.com [10.64.6.22]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 32GBYE7m072146 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 16 Mar 2023 06:34:14 -0500 Received: from DFLE104.ent.ti.com (10.64.6.25) by DFLE101.ent.ti.com (10.64.6.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Thu, 16 Mar 2023 06:34:13 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Thu, 16 Mar 2023 06:34:13 -0500 Received: from [10.24.69.114] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 32GBY8O6001003; Thu, 16 Mar 2023 06:34:09 -0500 Message-ID: <7c08d8be-06aa-1f70-8262-f7a4893f80e2@ti.com> Date: Thu, 16 Mar 2023 17:04:08 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [EXTERNAL] Re: [EXTERNAL] Re: [PATCH v4 3/5] soc: ti: pruss: Add pruss_cfg_read()/update() API Content-Language: en-US To: Roger Quadros , MD Danish Anwar , "Andrew F. Davis" , Suman Anna , Vignesh Raghavendra , Mathieu Poirier , Bjorn Andersson , Santosh Shilimkar , Nishanth Menon CC: , , , , , , References: <20230313111127.1229187-1-danishanwar@ti.com> <20230313111127.1229187-4-danishanwar@ti.com> <91481d4f-2005-7b33-d3be-df09b7d27ef6@kernel.org> From: Md Danish Anwar Organization: Texas Instruments In-Reply-To: X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230316_043418_997091_FD8392F3 X-CRM114-Status: GOOD ( 18.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/03/23 17:02, Roger Quadros wrote: > > > On 16/03/2023 13:29, Md Danish Anwar wrote: >> Roger, >> >> On 16/03/23 16:38, Md Danish Anwar wrote: >>> >>> On 15/03/23 17:37, Roger Quadros wrote: >>>> Danish, >>>> >>>> On 13/03/2023 13:11, MD Danish Anwar wrote: >>>>> From: Suman Anna >>>>> >>>>> Add two new generic API pruss_cfg_read() and pruss_cfg_update() to >>>>> the PRUSS platform driver to read and program respectively a register >>>>> within the PRUSS CFG sub-module represented by a syscon driver. >>>>> >>>>> These APIs are internal to PRUSS driver. Various useful registers >>>>> and macros for certain register bit-fields and their values have also >>>>> been added. >>>>> >>>>> Signed-off-by: Suman Anna >>>>> Co-developed-by: Grzegorz Jaszczyk >>>>> Signed-off-by: Grzegorz Jaszczyk >>>>> Signed-off-by: Puranjay Mohan >>>>> Signed-off-by: MD Danish Anwar >>>>> --- >>>>> drivers/soc/ti/pruss.c | 39 ++++++++++++++ >>>>> include/linux/remoteproc/pruss.h | 87 ++++++++++++++++++++++++++++++++ >>>>> 2 files changed, 126 insertions(+) >>>>> >>>>> diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c >>>>> index c8053c0d735f..26d8129b515c 100644 >>>>> --- a/drivers/soc/ti/pruss.c >>>>> +++ b/drivers/soc/ti/pruss.c >>>>> @@ -164,6 +164,45 @@ int pruss_release_mem_region(struct pruss *pruss, >>>>> } >>>>> EXPORT_SYMBOL_GPL(pruss_release_mem_region); >>>>> >>>>> +/** >>>>> + * pruss_cfg_read() - read a PRUSS CFG sub-module register >>>>> + * @pruss: the pruss instance handle >>>>> + * @reg: register offset within the CFG sub-module >>>>> + * @val: pointer to return the value in >>>>> + * >>>>> + * Reads a given register within the PRUSS CFG sub-module and >>>>> + * returns it through the passed-in @val pointer >>>>> + * >>>>> + * Return: 0 on success, or an error code otherwise >>>>> + */ >>>>> +static int pruss_cfg_read(struct pruss *pruss, unsigned int reg, unsigned int *val) >>>>> +{ >>>>> + if (IS_ERR_OR_NULL(pruss)) >>>>> + return -EINVAL; >>>>> + >>>>> + return regmap_read(pruss->cfg_regmap, reg, val); >>>>> +} >>>>> + >>>>> +/** >>>>> + * pruss_cfg_update() - configure a PRUSS CFG sub-module register >>>>> + * @pruss: the pruss instance handle >>>>> + * @reg: register offset within the CFG sub-module >>>>> + * @mask: bit mask to use for programming the @val >>>>> + * @val: value to write >>>>> + * >>>>> + * Programs a given register within the PRUSS CFG sub-module >>>>> + * >>>>> + * Return: 0 on success, or an error code otherwise >>>>> + */ >>>>> +static int pruss_cfg_update(struct pruss *pruss, unsigned int reg, >>>>> + unsigned int mask, unsigned int val) >>>>> +{ >>>>> + if (IS_ERR_OR_NULL(pruss)) >>>>> + return -EINVAL; >>>>> + >>>>> + return regmap_update_bits(pruss->cfg_regmap, reg, mask, val); >>>>> +} >>>>> + >>>>> static void pruss_of_free_clk_provider(void *data) >>>>> { >>>>> struct device_node *clk_mux_np = data; >>>>> diff --git a/include/linux/remoteproc/pruss.h b/include/linux/remoteproc/pruss.h >>>>> index 33f930e0a0ce..12ef10b9fe9a 100644 >>>>> --- a/include/linux/remoteproc/pruss.h >>>>> +++ b/include/linux/remoteproc/pruss.h >>>>> @@ -10,12 +10,99 @@ >>>>> #ifndef __LINUX_PRUSS_H >>>>> #define __LINUX_PRUSS_H >>>>> >>>>> +#include >>>>> #include >>>>> #include >>>>> #include >>>>> >>>>> #define PRU_RPROC_DRVNAME "pru-rproc" >>>>> >>>>> +/* >>>>> + * PRU_ICSS_CFG registers >>>>> + * SYSCFG, ISRP, ISP, IESP, IECP, SCRP applicable on AMxxxx devices only >>>>> + */ >>>>> +#define PRUSS_CFG_REVID 0x00 >>>>> +#define PRUSS_CFG_SYSCFG 0x04 >>>>> +#define PRUSS_CFG_GPCFG(x) (0x08 + (x) * 4) >>>>> +#define PRUSS_CFG_CGR 0x10 >>>>> +#define PRUSS_CFG_ISRP 0x14 >>>>> +#define PRUSS_CFG_ISP 0x18 >>>>> +#define PRUSS_CFG_IESP 0x1C >>>>> +#define PRUSS_CFG_IECP 0x20 >>>>> +#define PRUSS_CFG_SCRP 0x24 >>>>> +#define PRUSS_CFG_PMAO 0x28 >>>>> +#define PRUSS_CFG_MII_RT 0x2C >>>>> +#define PRUSS_CFG_IEPCLK 0x30 >>>>> +#define PRUSS_CFG_SPP 0x34 >>>>> +#define PRUSS_CFG_PIN_MX 0x40 >>>>> + >>>>> +/* PRUSS_GPCFG register bits */ >>>>> +#define PRUSS_GPCFG_PRU_GPO_SH_SEL BIT(25) >>>>> + >>>>> +#define PRUSS_GPCFG_PRU_DIV1_SHIFT 20 >>>>> +#define PRUSS_GPCFG_PRU_DIV1_MASK GENMASK(24, 20) >>>>> + >>>>> +#define PRUSS_GPCFG_PRU_DIV0_SHIFT 15 >>>>> +#define PRUSS_GPCFG_PRU_DIV0_MASK GENMASK(15, 19) >>>>> + >>>>> +#define PRUSS_GPCFG_PRU_GPO_MODE BIT(14) >>>>> +#define PRUSS_GPCFG_PRU_GPO_MODE_DIRECT 0 >>>>> +#define PRUSS_GPCFG_PRU_GPO_MODE_SERIAL BIT(14) >>>>> + >>>>> +#define PRUSS_GPCFG_PRU_GPI_SB BIT(13) >>>>> + >>>>> +#define PRUSS_GPCFG_PRU_GPI_DIV1_SHIFT 8 >>>>> +#define PRUSS_GPCFG_PRU_GPI_DIV1_MASK GENMASK(12, 8) >>>>> + >>>>> +#define PRUSS_GPCFG_PRU_GPI_DIV0_SHIFT 3 >>>>> +#define PRUSS_GPCFG_PRU_GPI_DIV0_MASK GENMASK(7, 3) >>>>> + >>>>> +#define PRUSS_GPCFG_PRU_GPI_CLK_MODE_POSITIVE 0 >>>>> +#define PRUSS_GPCFG_PRU_GPI_CLK_MODE_NEGATIVE BIT(2) >>>>> +#define PRUSS_GPCFG_PRU_GPI_CLK_MODE BIT(2) >>>>> + >>>>> +#define PRUSS_GPCFG_PRU_GPI_MODE_MASK GENMASK(1, 0) >>>>> +#define PRUSS_GPCFG_PRU_GPI_MODE_SHIFT 0 >>>>> + >>>>> +#define PRUSS_GPCFG_PRU_MUX_SEL_SHIFT 26 >>>>> +#define PRUSS_GPCFG_PRU_MUX_SEL_MASK GENMASK(29, 26) >>>>> + >>>>> +/* PRUSS_MII_RT register bits */ >>>>> +#define PRUSS_MII_RT_EVENT_EN BIT(0) >>>>> + >>>>> +/* PRUSS_SPP register bits */ >>>>> +#define PRUSS_SPP_XFER_SHIFT_EN BIT(1) >>>>> +#define PRUSS_SPP_PRU1_PAD_HP_EN BIT(0) >>>> >>>> Can we please move all the above definitions to private driver/soc/ti/pruss.h? >>>> You can also add pruss_cfg_read and pruss_cfg_update there. >>>> >> >> There is no driver/soc/ti/pruss.h. The pruss.h file is located in >> include/linux/remoteproc/pruss.h and there is one pruss_driver.h file which is >> located in include/linux/pruss_driver.h >> >> Do you want me to create another header file at driver/soc/ti/pruss.h and place >> all these definitions inside that? >> >> Please let me know. > > Yes. All private definitions should sit in driver/soc/ti/pruss.h > Should I keep the change the name to pruss_internal.h? As we already have a pruss.h inside include/linux/remoteproc, just to avoid any confusion. > > cheers, > roger -- Thanks and Regards, Danish. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel