From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E09EC10F0E for ; Tue, 9 Apr 2019 10:36:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D96E20818 for ; Tue, 9 Apr 2019 10:36:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="d7ZNQ0oV"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="blV4sA8E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D96E20818 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=cogentembedded.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3CEHXwTYvJdeZTTALDYStdN6EKLy/sHUc/Q6MDVLhsk=; b=d7ZNQ0oV1gEYzA Vlv6FOXNlsWjT5PjWjLoMN5ydfL0ahTFmT7y+Ambmh+haV0jF6DnwBQbuY2rts0JtX1npoHXWp4l+ WjkHqrmv9PmSmTLj7o376l0xOIXwkNm0YtwLnmj2wjsTZB7YlH5xLQISua0ulR5OOHz+MLkJ8AkNv 2f5WWqIah3kuaZ84DCl1G3X4VeU8FxcOReaszh9IrpC+MP0IKUa/0paeiwgj1N9+nS9zm2i4kRlGm zIgCzIofeEuF7qJiKNp9e2ZAGjqaTB0nHHxuQUlOq6hgErl8n0fwQDeLfgEs0nYa8OulqwtKCwQ6/ cODi+7tCmg6B0DIk3Bmg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDo74-0000pr-Eh; Tue, 09 Apr 2019 10:36:22 +0000 Received: from mail-lf1-x144.google.com ([2a00:1450:4864:20::144]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDo70-0000pI-1A for linux-arm-kernel@lists.infradead.org; Tue, 09 Apr 2019 10:36:20 +0000 Received: by mail-lf1-x144.google.com with SMTP id o19so11906775lfl.4 for ; Tue, 09 Apr 2019 03:36:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UAw9QiYDP8ZLR6rjqbOsp057BTBy4N/6x7Ni502ccbM=; b=blV4sA8E2tZ0+Gj2ekGzQGWHuPSgSyxG/zW1xetjm/mlCakJ88/z/wh7ZMu2CFOMGq av1Ho5mN+m1qZdyL8f5TcaoEJCnX8nWB8Zutaw/70hQNW1ATZ1sxOpnizUVQeixkshH6 NayXs8IKKbUm8gPWpbFqKNecbz0gJUdC1F9pj4RN7vsj/t6ilVlEcTwHo9AfaViIrh7u KUxiS7zztefUqo7wSJsLAk+gyIfbguaDMpU5JCuTCF8I4OgCfUUdtAogKllDkey6k5XI ZQIkXilwB7kZ09pJ/7iqs2aUVaAt8F/wmTjMd25RyjcHvBBedSbysxpWKei1U7NV4StF T2FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=UAw9QiYDP8ZLR6rjqbOsp057BTBy4N/6x7Ni502ccbM=; b=OiSe8xFJzIF6EMYZGArAASOufoEnhHlfOgv7waSRjgYJkXM7a8/USIXhBI2LnwR7QA 7hQcfoFzjp0CL/HM+hqyrNk9mlnvGWIiF3cH4MftL6U6KYVGhuaFfMzbZd5v4TXhRGkH j9/nXfGxEa+wxS0U1SN4UP1wkwa2osa17dOi3YdbhMs7zmt0dwc7FclVVqOqR43kbkPp vaMCc+BfWx/GdNScS9rO5/qWszCZSrHKa3d4tgYGRSY+RRiNU+wnMS0qVJoZ1Nb2TVQC kyqeIPCtyOwL/MM7HSgNl4wYV7xVvwfam2xNn3nlYICm3AEcqSkHR7sKRgMcRcpDIS0o pPbg== X-Gm-Message-State: APjAAAXhbsfGtKyOQVsnkI+BeKVs4EORn2E8x0psMBYFlkGs/7+l8eRs yX0DBgMEtlcHXHzQKiBQeH9JZw== X-Google-Smtp-Source: APXvYqy2mabD3xIsJEgr4+SjQt0GXR4BE6NUZHwOv5sQiYKZrh6xm3WLuAKC417d7KZv+WEXZl0rxw== X-Received: by 2002:a19:7503:: with SMTP id y3mr19059196lfe.83.1554806175295; Tue, 09 Apr 2019 03:36:15 -0700 (PDT) Received: from wasted.cogentembedded.com ([31.173.87.225]) by smtp.gmail.com with ESMTPSA id q5sm5129872lff.30.2019.04.09.03.36.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Apr 2019 03:36:14 -0700 (PDT) Subject: Re: [PATCH v3 2/6] usb: ohci-da8xx: let the regulator framework keep track of use count To: Bartosz Golaszewski , Sekhar Nori , Kevin Hilman , Alan Stern , Greg Kroah-Hartman References: <20190409082855.15373-1-brgl@bgdev.pl> <20190409082855.15373-3-brgl@bgdev.pl> From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <7c968006-0cdc-d4cf-622f-9cda52490aa1@cogentembedded.com> Date: Tue, 9 Apr 2019 13:36:12 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20190409082855.15373-3-brgl@bgdev.pl> Content-Language: en-MW X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190409_033618_493322_B2EAC18F X-CRM114-Status: GOOD ( 18.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bartosz Golaszewski , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/09/2019 11:28 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > There's no reason to have a separate variable to keep track of the > regulator state. The regulator core already does that. Remove > reg_enabled from struct da8xx_ohci_hcd. > > Signed-off-by: Bartosz Golaszewski > Acked-by: Alan Stern > --- > drivers/usb/host/ohci-da8xx.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/usb/host/ohci-da8xx.c b/drivers/usb/host/ohci-da8xx.c > index ca8a94f15ac0..9c6d1f03b871 100644 > --- a/drivers/usb/host/ohci-da8xx.c > +++ b/drivers/usb/host/ohci-da8xx.c [...] > @@ -100,21 +99,18 @@ static int ohci_da8xx_set_power(struct usb_hcd *hcd, int on) > if (!da8xx_ohci->vbus_reg) > return 0; > > - if (on && !da8xx_ohci->reg_enabled) { > + if (on) { > ret = regulator_enable(da8xx_ohci->vbus_reg); > if (ret) { > dev_err(dev, "Failed to enable regulator: %d\n", ret); > return ret; > } > - da8xx_ohci->reg_enabled = 1; > - > - } else if (!on && da8xx_ohci->reg_enabled) { > + } else if (!on) { This can be reduced to simple *else* now. > ret = regulator_disable(da8xx_ohci->vbus_reg); > if (ret) { > dev_err(dev, "Failed to disable regulator: %d\n", ret); > return ret; > } > - da8xx_ohci->reg_enabled = 0; > } > > return 0; MBR, Sergei _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel