From: Paolo Bonzini <pbonzini@redhat.com>
To: Oliver Upton <oupton@google.com>,
kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu
Cc: Sean Christopherson <seanjc@google.com>,
Marc Zyngier <maz@kernel.org>, Peter Shier <pshier@google.com>,
Jim Mattson <jmattson@google.com>,
David Matlack <dmatlack@google.com>,
Ricardo Koller <ricarkol@google.com>,
Jing Zhang <jingzhangos@google.com>,
Raghavendra Rao Anata <rananta@google.com>,
James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
linux-arm-kernel@lists.infradead.org,
Andrew Jones <drjones@redhat.com>,
Oliver Upton <oupton@gooogle.com>
Subject: Re: [PATCH v4 03/13] KVM: x86: Expose TSC offset controls to userspace
Date: Thu, 29 Jul 2021 11:30:25 +0200 [thread overview]
Message-ID: <7cb58a33-316c-58b5-b542-671a43dea89c@redhat.com> (raw)
In-Reply-To: <20210729001012.70394-4-oupton@google.com>
On 29/07/21 02:10, Oliver Upton wrote:
> +6. Adjust the guest TSC offsets for every vCPU to account for (1) time
> + elapsed since recording state and (2) difference in TSCs between the
> + source and destination machine:
> +
> + new_off_n = t_0 + off_n = (k_1 - k_0) * freq - t_1
The second = should be a +.
Otherwise the algorithm seems correct.
> +
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-29 9:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 0:09 [PATCH v4 00/13] KVM: Add idempotent controls for migrating system counter state Oliver Upton
2021-07-29 0:10 ` [PATCH v4 01/13] KVM: x86: Report host tsc and realtime values in KVM_GET_CLOCK Oliver Upton
2021-07-29 0:10 ` [PATCH v4 02/13] KVM: x86: Refactor tsc synchronization code Oliver Upton
2021-07-29 0:10 ` [PATCH v4 03/13] KVM: x86: Expose TSC offset controls to userspace Oliver Upton
2021-07-29 9:30 ` Paolo Bonzini [this message]
2021-07-29 0:10 ` [PATCH v4 04/13] tools: arch: x86: pull in pvclock headers Oliver Upton
2021-07-29 0:10 ` [PATCH v4 05/13] selftests: KVM: Add test for KVM_{GET,SET}_CLOCK Oliver Upton
2021-07-29 0:10 ` [PATCH v4 06/13] selftests: KVM: Fix kvm device helper ioctl assertions Oliver Upton
2021-07-29 16:22 ` Andrew Jones
2021-07-29 0:10 ` [PATCH v4 07/13] selftests: KVM: Add helpers for vCPU device attributes Oliver Upton
2021-07-29 0:10 ` [PATCH v4 08/13] selftests: KVM: Introduce system counter offset test Oliver Upton
2021-07-29 0:10 ` [PATCH v4 09/13] KVM: arm64: Allow userspace to configure a vCPU's virtual offset Oliver Upton
2021-07-29 0:10 ` [PATCH v4 10/13] selftests: KVM: Add support for aarch64 to system_counter_offset_test Oliver Upton
2021-07-29 0:10 ` [PATCH v4 11/13] KVM: arm64: Provide userspace access to the physical counter offset Oliver Upton
2021-07-29 16:33 ` Andrew Jones
2021-07-29 0:10 ` [PATCH v4 12/13] selftests: KVM: Test physical counter offsetting Oliver Upton
2021-07-29 0:10 ` [PATCH v4 13/13] selftests: KVM: Add counter emulation benchmark Oliver Upton
2021-07-29 16:55 ` Andrew Jones
2021-07-29 16:57 ` Oliver Upton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cb58a33-316c-58b5-b542-671a43dea89c@redhat.com \
--to=pbonzini@redhat.com \
--cc=alexandru.elisei@arm.com \
--cc=dmatlack@google.com \
--cc=drjones@redhat.com \
--cc=james.morse@arm.com \
--cc=jingzhangos@google.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=oupton@google.com \
--cc=oupton@gooogle.com \
--cc=pshier@google.com \
--cc=rananta@google.com \
--cc=ricarkol@google.com \
--cc=seanjc@google.com \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).