linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/5] ARM: davinci: fix label names in GPIO lookup entries
@ 2019-01-03 15:10 Bartosz Golaszewski
  2019-01-03 15:11 ` [PATCH 1/5] ARM: davinci: da830-evm: " Bartosz Golaszewski
                   ` (5 more replies)
  0 siblings, 6 replies; 9+ messages in thread
From: Bartosz Golaszewski @ 2019-01-03 15:10 UTC (permalink / raw)
  To: Sekhar Nori, Kevin Hilman
  Cc: Bartosz Golaszewski, Linus Walleij, linux-kernel,
	linux-arm-kernel, Andrew F . Davis

From: Bartosz Golaszewski <bgolaszewski@baylibre.com>

Hi Sekhar,

I noticed some more breakage resulting from commit 587f7a694f01 ("gpio:
davinci: Use dev name for label and automatic base selection"). This
series fixes GPIO lookups in legacy mode for DaVinci.

Bartosz Golaszewski (5):
  ARM: davinci: da830-evm: fix label names in GPIO lookup entries
  ARM: davinci: da850-evm: fix label names in GPIO lookup entries
  ARM: davinci: dm355-evm: fix label names in GPIO lookup entries
  ARM: davinci: dm644x-evm: fix label names in GPIO lookup entries
  ARM: davinci: omapl138-hawk: fix label names in GPIO lookup entries

 arch/arm/mach-davinci/board-da830-evm.c     | 4 ++--
 arch/arm/mach-davinci/board-da850-evm.c     | 4 ++--
 arch/arm/mach-davinci/board-dm355-evm.c     | 4 ++--
 arch/arm/mach-davinci/board-dm644x-evm.c    | 4 ++--
 arch/arm/mach-davinci/board-omapl138-hawk.c | 4 ++--
 5 files changed, 10 insertions(+), 10 deletions(-)

-- 
2.19.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 1/5] ARM: davinci: da830-evm: fix label names in GPIO lookup entries
  2019-01-03 15:10 [PATCH 0/5] ARM: davinci: fix label names in GPIO lookup entries Bartosz Golaszewski
@ 2019-01-03 15:11 ` Bartosz Golaszewski
  2019-01-11  9:38   ` Linus Walleij
  2019-01-03 15:11 ` [PATCH 2/5] ARM: davinci: da850-evm: " Bartosz Golaszewski
                   ` (4 subsequent siblings)
  5 siblings, 1 reply; 9+ messages in thread
From: Bartosz Golaszewski @ 2019-01-03 15:11 UTC (permalink / raw)
  To: Sekhar Nori, Kevin Hilman
  Cc: Linus Walleij, linux-kernel, stable, Andrew F . Davis,
	Bartosz Golaszewski, linux-arm-kernel

From: Bartosz Golaszewski <bgolaszewski@baylibre.com>

Since commit 587f7a694f01 ("gpio: davinci: Use dev name for label and
automatic base selection") the gpiochip label no longer has an ID
suffix. Update the GPIO lookup entries.

Fixes: 587f7a694f01 ("gpio: davinci: Use dev name for label and automatic base selection")
Cc: stable@vger.kernel.org
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
 arch/arm/mach-davinci/board-da830-evm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-davinci/board-da830-evm.c b/arch/arm/mach-davinci/board-da830-evm.c
index e52ec1619b70..c4da635ee4ce 100644
--- a/arch/arm/mach-davinci/board-da830-evm.c
+++ b/arch/arm/mach-davinci/board-da830-evm.c
@@ -208,9 +208,9 @@ static struct gpiod_lookup_table mmc_gpios_table = {
 	.dev_id = "da830-mmc.0",
 	.table = {
 		/* gpio chip 1 contains gpio range 32-63 */
-		GPIO_LOOKUP("davinci_gpio.0", DA830_MMCSD_CD_PIN, "cd",
+		GPIO_LOOKUP("davinci_gpio", DA830_MMCSD_CD_PIN, "cd",
 			    GPIO_ACTIVE_LOW),
-		GPIO_LOOKUP("davinci_gpio.0", DA830_MMCSD_WP_PIN, "wp",
+		GPIO_LOOKUP("davinci_gpio", DA830_MMCSD_WP_PIN, "wp",
 			    GPIO_ACTIVE_LOW),
 	},
 };
-- 
2.19.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 2/5] ARM: davinci: da850-evm: fix label names in GPIO lookup entries
  2019-01-03 15:10 [PATCH 0/5] ARM: davinci: fix label names in GPIO lookup entries Bartosz Golaszewski
  2019-01-03 15:11 ` [PATCH 1/5] ARM: davinci: da830-evm: " Bartosz Golaszewski
@ 2019-01-03 15:11 ` Bartosz Golaszewski
  2019-01-03 15:11 ` [PATCH 3/5] ARM: davinci: dm355-evm: " Bartosz Golaszewski
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 9+ messages in thread
From: Bartosz Golaszewski @ 2019-01-03 15:11 UTC (permalink / raw)
  To: Sekhar Nori, Kevin Hilman
  Cc: Linus Walleij, linux-kernel, stable, Andrew F . Davis,
	Bartosz Golaszewski, linux-arm-kernel

From: Bartosz Golaszewski <bgolaszewski@baylibre.com>

Since commit 587f7a694f01 ("gpio: davinci: Use dev name for label and
automatic base selection") the gpiochip label no longer has an ID
suffix. Update the GPIO lookup entries.

Fixes: 587f7a694f01 ("gpio: davinci: Use dev name for label and automatic base selection")
Cc: stable@vger.kernel.org
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
 arch/arm/mach-davinci/board-da850-evm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-davinci/board-da850-evm.c b/arch/arm/mach-davinci/board-da850-evm.c
index 6a29baf0a289..44bca048dfd0 100644
--- a/arch/arm/mach-davinci/board-da850-evm.c
+++ b/arch/arm/mach-davinci/board-da850-evm.c
@@ -805,9 +805,9 @@ static struct gpiod_lookup_table mmc_gpios_table = {
 	.dev_id = "da830-mmc.0",
 	.table = {
 		/* gpio chip 2 contains gpio range 64-95 */
-		GPIO_LOOKUP("davinci_gpio.0", DA850_MMCSD_CD_PIN, "cd",
+		GPIO_LOOKUP("davinci_gpio", DA850_MMCSD_CD_PIN, "cd",
 			    GPIO_ACTIVE_LOW),
-		GPIO_LOOKUP("davinci_gpio.0", DA850_MMCSD_WP_PIN, "wp",
+		GPIO_LOOKUP("davinci_gpio", DA850_MMCSD_WP_PIN, "wp",
 			    GPIO_ACTIVE_HIGH),
 	},
 };
-- 
2.19.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 3/5] ARM: davinci: dm355-evm: fix label names in GPIO lookup entries
  2019-01-03 15:10 [PATCH 0/5] ARM: davinci: fix label names in GPIO lookup entries Bartosz Golaszewski
  2019-01-03 15:11 ` [PATCH 1/5] ARM: davinci: da830-evm: " Bartosz Golaszewski
  2019-01-03 15:11 ` [PATCH 2/5] ARM: davinci: da850-evm: " Bartosz Golaszewski
@ 2019-01-03 15:11 ` Bartosz Golaszewski
  2019-01-03 15:11 ` [PATCH 4/5] ARM: davinci: dm644x-evm: " Bartosz Golaszewski
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 9+ messages in thread
From: Bartosz Golaszewski @ 2019-01-03 15:11 UTC (permalink / raw)
  To: Sekhar Nori, Kevin Hilman
  Cc: Linus Walleij, linux-kernel, stable, Andrew F . Davis,
	Bartosz Golaszewski, linux-arm-kernel

From: Bartosz Golaszewski <bgolaszewski@baylibre.com>

Since commit 587f7a694f01 ("gpio: davinci: Use dev name for label and
automatic base selection") the gpiochip label no longer has an ID
suffix. Update the GPIO lookup entries.

Fixes: 587f7a694f01 ("gpio: davinci: Use dev name for label and automatic base selection")
Cc: stable@vger.kernel.org
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
 arch/arm/mach-davinci/board-dm355-evm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-davinci/board-dm355-evm.c b/arch/arm/mach-davinci/board-dm355-evm.c
index f53a461a606f..f7fa960c23e3 100644
--- a/arch/arm/mach-davinci/board-dm355-evm.c
+++ b/arch/arm/mach-davinci/board-dm355-evm.c
@@ -117,9 +117,9 @@ static struct platform_device davinci_nand_device = {
 static struct gpiod_lookup_table i2c_recovery_gpiod_table = {
 	.dev_id = "i2c_davinci.1",
 	.table = {
-		GPIO_LOOKUP("davinci_gpio.0", DM355_I2C_SDA_PIN, "sda",
+		GPIO_LOOKUP("davinci_gpio", DM355_I2C_SDA_PIN, "sda",
 			    GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN),
-		GPIO_LOOKUP("davinci_gpio.0", DM355_I2C_SCL_PIN, "scl",
+		GPIO_LOOKUP("davinci_gpio", DM355_I2C_SCL_PIN, "scl",
 			    GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN),
 	},
 };
-- 
2.19.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 4/5] ARM: davinci: dm644x-evm: fix label names in GPIO lookup entries
  2019-01-03 15:10 [PATCH 0/5] ARM: davinci: fix label names in GPIO lookup entries Bartosz Golaszewski
                   ` (2 preceding siblings ...)
  2019-01-03 15:11 ` [PATCH 3/5] ARM: davinci: dm355-evm: " Bartosz Golaszewski
@ 2019-01-03 15:11 ` Bartosz Golaszewski
  2019-01-03 15:11 ` [PATCH 5/5] ARM: davinci: omapl138-hawk: " Bartosz Golaszewski
  2019-01-04  8:15 ` [PATCH 0/5] ARM: davinci: " Sekhar Nori
  5 siblings, 0 replies; 9+ messages in thread
From: Bartosz Golaszewski @ 2019-01-03 15:11 UTC (permalink / raw)
  To: Sekhar Nori, Kevin Hilman
  Cc: Linus Walleij, linux-kernel, stable, Andrew F . Davis,
	Bartosz Golaszewski, linux-arm-kernel

From: Bartosz Golaszewski <bgolaszewski@baylibre.com>

Since commit 587f7a694f01 ("gpio: davinci: Use dev name for label and
automatic base selection") the gpiochip label no longer has an ID
suffix. Update the GPIO lookup entries.

Fixes: 587f7a694f01 ("gpio: davinci: Use dev name for label and automatic base selection")
Cc: stable@vger.kernel.org
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
 arch/arm/mach-davinci/board-dm644x-evm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-davinci/board-dm644x-evm.c b/arch/arm/mach-davinci/board-dm644x-evm.c
index e1428115067f..b80c4ee76217 100644
--- a/arch/arm/mach-davinci/board-dm644x-evm.c
+++ b/arch/arm/mach-davinci/board-dm644x-evm.c
@@ -660,9 +660,9 @@ static struct i2c_board_info __initdata i2c_info[] =  {
 static struct gpiod_lookup_table i2c_recovery_gpiod_table = {
 	.dev_id = "i2c_davinci.1",
 	.table = {
-		GPIO_LOOKUP("davinci_gpio.0", DM644X_I2C_SDA_PIN, "sda",
+		GPIO_LOOKUP("davinci_gpio", DM644X_I2C_SDA_PIN, "sda",
 			    GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN),
-		GPIO_LOOKUP("davinci_gpio.0", DM644X_I2C_SCL_PIN, "scl",
+		GPIO_LOOKUP("davinci_gpio", DM644X_I2C_SCL_PIN, "scl",
 			    GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN),
 	},
 };
-- 
2.19.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 5/5] ARM: davinci: omapl138-hawk: fix label names in GPIO lookup entries
  2019-01-03 15:10 [PATCH 0/5] ARM: davinci: fix label names in GPIO lookup entries Bartosz Golaszewski
                   ` (3 preceding siblings ...)
  2019-01-03 15:11 ` [PATCH 4/5] ARM: davinci: dm644x-evm: " Bartosz Golaszewski
@ 2019-01-03 15:11 ` Bartosz Golaszewski
  2019-01-04  8:15 ` [PATCH 0/5] ARM: davinci: " Sekhar Nori
  5 siblings, 0 replies; 9+ messages in thread
From: Bartosz Golaszewski @ 2019-01-03 15:11 UTC (permalink / raw)
  To: Sekhar Nori, Kevin Hilman
  Cc: Linus Walleij, linux-kernel, stable, Andrew F . Davis,
	Bartosz Golaszewski, linux-arm-kernel

From: Bartosz Golaszewski <bgolaszewski@baylibre.com>

Since commit 587f7a694f01 ("gpio: davinci: Use dev name for label and
automatic base selection") the gpiochip label no longer has an ID
suffix. Update the GPIO lookup entries.

Fixes: 587f7a694f01 ("gpio: davinci: Use dev name for label and automatic base selection")
Cc: stable@vger.kernel.org
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
 arch/arm/mach-davinci/board-omapl138-hawk.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-davinci/board-omapl138-hawk.c b/arch/arm/mach-davinci/board-omapl138-hawk.c
index 8e8d51f4a276..94c4f126ef86 100644
--- a/arch/arm/mach-davinci/board-omapl138-hawk.c
+++ b/arch/arm/mach-davinci/board-omapl138-hawk.c
@@ -134,9 +134,9 @@ static const short hawk_mmcsd0_pins[] = {
 static struct gpiod_lookup_table mmc_gpios_table = {
 	.dev_id = "da830-mmc.0",
 	.table = {
-		GPIO_LOOKUP("davinci_gpio.0", DA850_HAWK_MMCSD_CD_PIN, "cd",
+		GPIO_LOOKUP("davinci_gpio", DA850_HAWK_MMCSD_CD_PIN, "cd",
 			    GPIO_ACTIVE_LOW),
-		GPIO_LOOKUP("davinci_gpio.0", DA850_HAWK_MMCSD_WP_PIN, "wp",
+		GPIO_LOOKUP("davinci_gpio", DA850_HAWK_MMCSD_WP_PIN, "wp",
 			    GPIO_ACTIVE_LOW),
 	},
 };
-- 
2.19.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH 0/5] ARM: davinci: fix label names in GPIO lookup entries
  2019-01-03 15:10 [PATCH 0/5] ARM: davinci: fix label names in GPIO lookup entries Bartosz Golaszewski
                   ` (4 preceding siblings ...)
  2019-01-03 15:11 ` [PATCH 5/5] ARM: davinci: omapl138-hawk: " Bartosz Golaszewski
@ 2019-01-04  8:15 ` Sekhar Nori
  5 siblings, 0 replies; 9+ messages in thread
From: Sekhar Nori @ 2019-01-04  8:15 UTC (permalink / raw)
  To: Bartosz Golaszewski, Kevin Hilman
  Cc: Bartosz Golaszewski, Linus Walleij, linux-kernel,
	linux-arm-kernel, Andrew F . Davis

Hi Bartosz,

On 03/01/19 8:40 PM, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> 
> Hi Sekhar,
> 
> I noticed some more breakage resulting from commit 587f7a694f01 ("gpio:
> davinci: Use dev name for label and automatic base selection"). This
> series fixes GPIO lookups in legacy mode for DaVinci.

Thanks for the fixes, look good to me. Will send them once v4.21-rc1
comes out.

Thanks,
Sekhar

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/5] ARM: davinci: da830-evm: fix label names in GPIO lookup entries
  2019-01-03 15:11 ` [PATCH 1/5] ARM: davinci: da830-evm: " Bartosz Golaszewski
@ 2019-01-11  9:38   ` Linus Walleij
  2019-01-11 10:56     ` Sekhar Nori
  0 siblings, 1 reply; 9+ messages in thread
From: Linus Walleij @ 2019-01-11  9:38 UTC (permalink / raw)
  To: Bartosz Golaszewski
  Cc: Kevin Hilman, Sekhar Nori, linux-kernel, stable,
	Andrew F . Davis, Bartosz Golaszewski, Linux ARM

On Thu, Jan 3, 2019 at 4:11 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:

> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> Since commit 587f7a694f01 ("gpio: davinci: Use dev name for label and
> automatic base selection") the gpiochip label no longer has an ID
> suffix. Update the GPIO lookup entries.
>
> Fixes: 587f7a694f01 ("gpio: davinci: Use dev name for label and automatic base selection")
> Cc: stable@vger.kernel.org
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

The series:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

I suppose you will push this upstream through ARM SoC.

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/5] ARM: davinci: da830-evm: fix label names in GPIO lookup entries
  2019-01-11  9:38   ` Linus Walleij
@ 2019-01-11 10:56     ` Sekhar Nori
  0 siblings, 0 replies; 9+ messages in thread
From: Sekhar Nori @ 2019-01-11 10:56 UTC (permalink / raw)
  To: Linus Walleij, Bartosz Golaszewski
  Cc: Kevin Hilman, linux-kernel, stable, Andrew F . Davis,
	Bartosz Golaszewski, Linux ARM

Hi Linus,

On 11/01/19 3:08 PM, Linus Walleij wrote:
> On Thu, Jan 3, 2019 at 4:11 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> 
>> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>>
>> Since commit 587f7a694f01 ("gpio: davinci: Use dev name for label and
>> automatic base selection") the gpiochip label no longer has an ID
>> suffix. Update the GPIO lookup entries.
>>
>> Fixes: 587f7a694f01 ("gpio: davinci: Use dev name for label and automatic base selection")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> 
> The series:
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> I suppose you will push this upstream through ARM SoC.

I sent a pull request with these applied to ARM SoC yesterday.

Thanks,
Sekhar

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2019-01-11 10:56 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-03 15:10 [PATCH 0/5] ARM: davinci: fix label names in GPIO lookup entries Bartosz Golaszewski
2019-01-03 15:11 ` [PATCH 1/5] ARM: davinci: da830-evm: " Bartosz Golaszewski
2019-01-11  9:38   ` Linus Walleij
2019-01-11 10:56     ` Sekhar Nori
2019-01-03 15:11 ` [PATCH 2/5] ARM: davinci: da850-evm: " Bartosz Golaszewski
2019-01-03 15:11 ` [PATCH 3/5] ARM: davinci: dm355-evm: " Bartosz Golaszewski
2019-01-03 15:11 ` [PATCH 4/5] ARM: davinci: dm644x-evm: " Bartosz Golaszewski
2019-01-03 15:11 ` [PATCH 5/5] ARM: davinci: omapl138-hawk: " Bartosz Golaszewski
2019-01-04  8:15 ` [PATCH 0/5] ARM: davinci: " Sekhar Nori

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).