From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 760D8C06510 for ; Tue, 2 Jul 2019 09:49:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C4AF206A2 for ; Tue, 2 Jul 2019 09:49:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tGSYxXG8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C4AF206A2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Qbpbv1xuR3NvkWpW0tkFTYO6L/cq4c6lDgadigxX2OE=; b=tGSYxXG8AV1J/yYJXiVD+0rui IvvaJDNYsZr4u/TwNnSFNukY61jmaCs1LLK77jXQy8XZvyrSgkBpSlQLT9B+DwTfMVFc219XtlEpL bL4UjZP5cqCUvI7UjuUjyzBrwEaIrKgQ5+nxP1emyyvrg4a/Zr826GUe5KXUH9JRQtbWu+ThZA3AO Ywh+p+BbZZISvn79jKMFtTAB8OFiZaHau5Ct0a74WMLMPdm20oEK/fPrd/0JHQDqIizy7bS8lI78Q +1a44O+TP+eHibpAQB+PChGhWd7PGW+2jB9MmBwnx1kkVvt89r3Sfksn07ecyY54hPFJjsp61E93J o6u9lEiLA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hiFPu-0003fb-F6; Tue, 02 Jul 2019 09:49:38 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hiFPq-0003et-PF for linux-arm-kernel@lists.infradead.org; Tue, 02 Jul 2019 09:49:35 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 56C71344; Tue, 2 Jul 2019 02:49:32 -0700 (PDT) Received: from [10.1.196.120] (e121650-lin.cambridge.arm.com [10.1.196.120]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 677CC3F718; Tue, 2 Jul 2019 02:49:31 -0700 (PDT) Subject: Re: [RFC V3 12/18] arm64: assembler: Add macro to annotate asm function having non standard stack-frame. To: Catalin Marinas References: <20190624095548.8578-1-raphael.gault@arm.com> <20190624095548.8578-13-raphael.gault@arm.com> <20190701144039.GD21774@arrakis.emea.arm.com> From: Raphael Gault Message-ID: <7ddc9d27-e4ea-c07a-ad12-3fac59aeb4fc@arm.com> Date: Tue, 2 Jul 2019 10:49:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190701144039.GD21774@arrakis.emea.arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190702_024934_865806_858956C1 X-CRM114-Status: GOOD ( 14.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: julien.thierry@arm.com, peterz@infradead.org, will.deacon@arm.com, linux-kernel@vger.kernel.org, jpoimboe@redhat.com, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 7/1/19 3:40 PM, Catalin Marinas wrote: > On Mon, Jun 24, 2019 at 10:55:42AM +0100, Raphael Gault wrote: >> --- a/arch/arm64/include/asm/assembler.h >> +++ b/arch/arm64/include/asm/assembler.h >> @@ -752,4 +752,17 @@ USER(\label, ic ivau, \tmp2) // invalidate I line PoU >> .Lyield_out_\@ : >> .endm >> >> + /* >> + * This macro is the arm64 assembler equivalent of the >> + * macro STACK_FRAME_NON_STANDARD define at >> + * ~/include/linux/frame.h >> + */ >> + .macro asm_stack_frame_non_standard func >> +#ifdef CONFIG_STACK_VALIDATION >> + .pushsection ".discard.func_stack_frame_non_standard" >> + .8byte \func > > Nitpicks: > > Does .quad vs .8byte make any difference? > No it doesn't, I'll use .quad then. > Could we place this in include/linux/frame.h directly with a generic > name (and some __ASSEMBLY__ guards)? It doesn't look to be arm specific. > It might be more consistent indeed, I'll do that. Thanks, -- Raphael Gault _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel