From: Johan Jonker <jbx6244@gmail.com>
To: cl@rock-chips.com, heiko@sntech.de
Cc: robh+dt@kernel.org, jagan@amarulasolutions.com, wens@csie.org,
uwe@kleine-koenig.org, mail@david-bauer.net,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
jensenhuang@friendlyarm.com, michael@amarulasolutions.com,
cnsztl@gmail.com, devicetree@vger.kernel.org,
ulf.hansson@linaro.org, linux-mmc@vger.kernel.org,
gregkh@linuxfoundation.org, linux-serial@vger.kernel.org,
linux-i2c@vger.kernel.org, jay.xu@rock-chips.com,
shawn.lin@rock-chips.com, david.wu@rock-chips.com,
zhangqing@rock-chips.com, huangtao@rock-chips.com
Subject: Re: [PATCH v1 3/5] dt-bindings: mmc: rockchip-dw-mshc: add description for rk3568
Date: Wed, 21 Apr 2021 11:26:58 +0200 [thread overview]
Message-ID: <7dde9617-9d71-9fdd-6f91-3fc327fa9bc1@gmail.com> (raw)
In-Reply-To: <20210421065921.23917-4-cl@rock-chips.com>
On 4/21/21 8:59 AM, cl@rock-chips.com wrote:
> From: Liang Chen <cl@rock-chips.com>
>
> add "rockchip,rk3568-dwcmshc", "snps,dwcmshc-sdhci" for mmc nodes on
> a rk3568 platform to rockchip-dw-mshc.yaml.
>
> Signed-off-by: Liang Chen <cl@rock-chips.com>
> ---
> Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml
> index 3762f1c8de96..2a6c1cee4887 100644
> --- a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml
> @@ -27,6 +27,8 @@ properties:
> - const: rockchip,rk2928-dw-mshc
> # for Rockchip RK3288
> - const: rockchip,rk3288-dw-mshc
> + # for Rockchip RK3568
> + - const: rockchip,rk3568-dwcmshc
Remove.
This would create two descriptions.
"rockchip,rk3568-dwcmshc"
"rockchip,rk3568-dwcmshc", "snps,dwcmshc-sdhci"
> - items:
> - enum:
> # for Rockchip PX30
Remove comments.
> @@ -41,6 +43,8 @@ properties:
> - rockchip,rk3328-dw-mshc
> # for Rockchip RK3368
Remove comments.
> - rockchip,rk3368-dw-mshc
> + # for Rockchip RK3568
Maybe remove the "#" comments in this enum part too.
This was one of the first Rockchip documents that was converted, but is
not really needed, as it both mentions the soc name.
> + - rockchip,rk3568-dw-mshc
Sort this below rockchip,rk3399-dw-mshc
> # for Rockchip RK3399
Remove comments.
> - rockchip,rk3399-dw-mshc
> # for Rockchip RV1108
Remove comments.
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-21 9:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 6:59 [PATCH v1 0/5] arm64: dts: rockchip: add basic dtsi/dts files for RK3568 SoC cl
2021-04-21 6:59 ` [PATCH v1 1/5] dt-bindings: i2c: i2c-rk3x: add description for rk3568 cl
2021-04-21 6:59 ` [PATCH v1 2/5] dt-bindings: serial: snps-dw-apb-uart: " cl
2021-04-21 9:11 ` Johan Jonker
2021-04-21 6:59 ` [PATCH v1 3/5] dt-bindings: mmc: rockchip-dw-mshc: " cl
2021-04-21 9:26 ` Johan Jonker [this message]
2021-04-21 6:59 ` [PATCH v1 4/5] arm64: dts: rockchip: add core dtsi for RK3568 SoC cl
2021-04-21 9:13 ` Heiko Stübner
2021-04-22 17:23 ` Ezequiel Garcia
2021-04-23 1:02 ` Kever Yang
2021-04-21 13:36 ` Marc Zyngier
2021-04-25 9:16 ` 陈亮
2021-04-25 10:20 ` Marc Zyngier
2021-04-21 7:01 ` [PATCH v1 5/5] arm64: dts: rockchip: add basic dts for RK3568 EVB cl
2021-04-21 10:38 ` Johan Jonker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dde9617-9d71-9fdd-6f91-3fc327fa9bc1@gmail.com \
--to=jbx6244@gmail.com \
--cc=cl@rock-chips.com \
--cc=cnsztl@gmail.com \
--cc=david.wu@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=jagan@amarulasolutions.com \
--cc=jay.xu@rock-chips.com \
--cc=jensenhuang@friendlyarm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=mail@david-bauer.net \
--cc=michael@amarulasolutions.com \
--cc=robh+dt@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
--cc=uwe@kleine-koenig.org \
--cc=wens@csie.org \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).