From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CB66C11F66 for ; Tue, 29 Jun 2021 07:50:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C505461DBC for ; Tue, 29 Jun 2021 07:50:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C505461DBC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kontron.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=3Rx9OZ0rYAkU3TowonXaNB0Q25pMfZ4P49ZFVYw8XlI=; b=uIXoaxGVkpX7ao8X+Jn/BNGpxV gvlHkxdLRmpax+74QCNg0d/Fb6Olusp2dNSAsUxaOoL3tzVJg5sYJTTK7PaZSrpA9OozpIXzcmFGI bmamsceK7Po8862ub471QOtEKVKpox4hq+XQNYul9CA8+x7ILluqILwpGLueYsW1Zoov9xqerq/Kk JblRvV4Q/u9OZyVRY2Lfof/W/EUGrrVFCPKi0drZq+0AaT1r6Wv+KMY1wnvFswLjeBUt0pg0hs4UZ gqQdlT3j5ZzybB17fEAUEOOW0j28dkcp3vloNe0fmdXi0J7DKg2/Q6JHOSBsRJmEn0KI7KE7cD22c 8vBSJKcg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ly8UA-00A61D-As; Tue, 29 Jun 2021 07:48:46 +0000 Received: from mail-am6eur05on2092.outbound.protection.outlook.com ([40.107.22.92] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ly8Tz-00A5zY-1d for linux-arm-kernel@lists.infradead.org; Tue, 29 Jun 2021 07:48:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YTSgAMADNGor+ccVnw0b5dBYDC1N83DfjvvT86V2YtBpiDRgSVifEHdEmUMrffpeiy664jnJLtqMA0HmlumZ3HDDwgXD1tBotP1s45w5kYLYt382XsOCtT0c7AKxexaXWp3MMe2n4n+BsLzT4f1Zk6YFOvQopKofncHpS6242Sm7M88jyED+czcalgID3ta710nfKkMhKt9Sxuo3HTQnMRX682Sypq1+nWgu2PPHPOcvsf9vyQHuIIhWVSTgPjHZSMzqEzW6moGd0XAMxuRdwJEZkpOTq4aOjM4VvlMcBgNwtXIote8HSTf5sH2zKqILPE3Y2bsKNpQ9DVMfb7isaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aEYKhrb/qdLzdPtHWiHSEQsJyxWtcal6B/8TLappXTo=; b=Gs8mEgsRkk2bTvDsTfm09BI3rit6OxYxXI1PHV0/OSNiKWSTE6347ELetNg9gmnsQK7l2Oth++CYTN91v7asFxrzyNSHm7IIJqGwrS/CJBsGZvvdetxc4EEtCuixJuYWRz1GrGHOriCr37E8M8ZLw9Um7h1DfFmv8ZXHy3FLdahwqyn5gnDKAdVwa5cINHBlHlTp/KnzApK4GeFSFSSVRZwKtDLNWb6pXOJ9F9xi14EfgH3pBI2KQAoglnUxXZImSKhtRaO7U3LB/D1bAakxdSbBk8RKiQF0Mvib4kJHHVZ4GqyQAEldJZXRsa+/vMyvBIHccE6A1slFEb6fmqIFVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=kontron.de; dmarc=pass action=none header.from=kontron.de; dkim=pass header.d=kontron.de; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mysnt.onmicrosoft.com; s=selector2-mysnt-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aEYKhrb/qdLzdPtHWiHSEQsJyxWtcal6B/8TLappXTo=; b=iEVV3JFG9+nAumU2amu5NvymfBLmXzFklBdxGciyKS47tuFQqmJ3E29XxcNmmc06Cw/wln+G5zhLP5iA3GCenasHhaS9VdcFzcb/6Q39t9xgJERiTezFIxeJ7OZCzDmjZZltyPF4qnCHdbw1mFdxdcs7tMHIJlnTbu6k/9bS1qs= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=none action=none header.from=kontron.de; Received: from AM0PR10MB2963.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:157::14) by AM8PR10MB4626.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:36a::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18; Tue, 29 Jun 2021 07:48:32 +0000 Received: from AM0PR10MB2963.EURPRD10.PROD.OUTLOOK.COM ([fe80::1133:8761:6cc9:9703]) by AM0PR10MB2963.EURPRD10.PROD.OUTLOOK.COM ([fe80::1133:8761:6cc9:9703%5]) with mapi id 15.20.4264.026; Tue, 29 Jun 2021 07:48:32 +0000 Subject: Re: [PATCH 1/4] arm64: dts: imx8mm-venice-gw700x: override thermal cfg for industrial temp To: Tim Harvey Cc: Jacky Bai , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , dl-linux-imx , Device Tree Mailing List , Linux ARM Mailing List , Zhang Rui , Daniel Lezcano , Amit Kucheria , "linux-pm@vger.kernel.org" References: <20210601174917.1979-1-tharvey@gateworks.com> <5eba4438-239c-71d1-56ec-4edd70e87ec3@kontron.de> <273e2859-7874-e273-9599-139274891023@kontron.de> <717608d8-685a-0435-aaa2-3bd4f82f3b97@kontron.de> From: Frieder Schrempf Message-ID: <7e148de0-a23d-a433-372f-861946416859@kontron.de> Date: Tue, 29 Jun 2021 09:48:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: Content-Language: en-US X-Originating-IP: [46.142.64.5] X-ClientProxiedBy: PR0P264CA0143.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1a::35) To AM0PR10MB2963.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:157::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.10.32] (46.142.64.5) by PR0P264CA0143.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1a::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.21 via Frontend Transport; Tue, 29 Jun 2021 07:48:31 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a05a732a-7e3d-439a-fe7d-08d93ad24ab6 X-MS-TrafficTypeDiagnostic: AM8PR10MB4626: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uHe7Q082hEIft0uWsFGxYo5fn5RYs6s0xNgIC5spHWTJnvTglf/9XUmwkSZaMGwD5rDQC2sedM/m3iDJjOeKnYNrZNysmz0HP1CUPv6WVvendKM1ujH/1rY7eCkdztDOwxSARN0cTPW6cnwVFLTgAZOV8fFwrcYX3l8a5OwUYOZQGQFXUXDz3fsoK0ZdVaIpIF0rr2KTL60/TknKm5uNwCV7ZBY+yBukYMU8kGpMxk2z/cl7xqFJL+r1DmPCd+eBAR1xb3sRA3rD5DfzQj3z1/S8XrU9Fy0rOFq4K8SUV8X3ygcC1svbV5ru+WYWwdrTatvm51BhLgBOBToohfx6f3u+tsaFDCoRjhKbgI4AlAvwbEsjDqKO1xt568rSxupJSQmaIKpZN/3LzQ6fIq5TPUYDJDvEliu5817ncXUPvaUrPeyw4BJDjqBoDQfAB9qmAXkWFNxvJZaxdCKpuH+gn6JiYFCtA2Rahqjlo2m4cPu5spG0/wsiF2rzy0wKfDBIKEuA7EDQ4x4TtNNd5k6yizW0MIouXm4PK4Kabhdgj1iROdSsAtWWabCLgJC7iwVhStuxRxA4YDFs/0WujLXXPSBB7yUmr3AO0ZVd22eXa/qOMuxv95Jw8m1M56RUF+7RiPy1dSMAFzl8PdYezJsxVCGY8GxxPEhlvVFd8wH9+vtC42pV5sd2hTTLkyRfFvdb9css1VvKp3goT8qkplhsVsGQQZetqSivZ43L8zfsp6aOnfjzIlHxzIjkAOfCwx1Pexft8f/F119brA6Y1B/IBA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR10MB2963.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(4636009)(396003)(376002)(136003)(366004)(346002)(39850400004)(16526019)(53546011)(186003)(7416002)(54906003)(36756003)(66946007)(16576012)(26005)(44832011)(6916009)(316002)(38100700002)(8936002)(6486002)(86362001)(83380400001)(2906002)(31686004)(2616005)(8676002)(5660300002)(956004)(478600001)(4326008)(31696002)(66476007)(66556008)(32563001)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aEhQd1JGNXhEeHN3VkFMMHdlMUhONnRXWlFrSlY4Z1VtK2RvSm9XcC9paW9n?= =?utf-8?B?WUdEVGpqMUJ5OWNpTnVxTHNuYXNGT0xBcit1YnJqeTBWUzRjUzNBT2xocnR2?= =?utf-8?B?KzFtaUcxdC9mZllQQXh0a0tuU0NrYmdPTnZkaEFhNHp3UHVpakh4K3pFZFJL?= =?utf-8?B?ZGxlMGcybWMvME1yYkErb09tR1I3K1BjK0tiSVNkQnR0V3F4UHNuVXlZS281?= =?utf-8?B?QUpqLzZkZW03OGloSHBxV2Z1ckRUMURIQVR1ZVJjeFI5dmpoc3JaekVXRnh1?= =?utf-8?B?dWtkMHRsRUlMN1g3ajlQQjdTK2wwRGhFamdGOFYwdzRyTlBjS2VjMnNVZmFQ?= =?utf-8?B?R0sxcHowZnAxTzlpUWRIaXV2dmF0VjNtNGRieHhVb2gxbFJJSXo5dkdJSzZS?= =?utf-8?B?cjV3eTJUT3A5SnVRa3gzeGtrclpQT2FZMHZWWWdrb3AxWEJ1Rmo0ZVJnUUVF?= =?utf-8?B?a3ZvUkVlOXJRZ1dudFF6cFNCZHlodzlpaFoyR1B5QlZBMlF5Nld2S3J0YzVY?= =?utf-8?B?ck5zbDFOaGNWSnU5ZkV3OG5WOUpMOWZqQlViTi9rRzQ0dmdxOWpiczVicm04?= =?utf-8?B?Y2xudmZ3TXZVWE5lVkhFK2lPZC9CTUYxQ3EzWnp5NGhlOFk1UjdoY0hLR2VO?= =?utf-8?B?NWdDT0JiM3NKakEvckF2elNraTRyYm9wL1kzdkpBOHFqUTVXdWFlZmM4bXlH?= =?utf-8?B?TVVWMzJyWEpZcE5wWEs4Sk5hRjdHMSt3aksvNUM0VFZPelE1bkYrZ28xSGpN?= =?utf-8?B?NjREb2cwSk1DTEN0VU1oeVlITklZTEN6UkRHVjk3MHRBSVhpTjlDS3ROelAv?= =?utf-8?B?Z2RRR0xJdFVOWFkxVGlzVjdhSjRsbXpqcUQrN01CcnhmTWRXY1k5NGRJMExt?= =?utf-8?B?emk2K0NNS0RONS9jNUQxcXpMK1RpWVdLNWwwVGxEVEsycXpQRFQvck51bklk?= =?utf-8?B?cmJaK1pCUnV0YllORWxGbnY0a1R4Nm05TzRUVGtoNkFQWlpwclRhb2hVVDJ3?= =?utf-8?B?c3VqN0dpdkJBYjZQZS9zMDFvTi9yUkwxMFU0VUd3blN6QUxhb25ieGRrL1lx?= =?utf-8?B?S2g4VzhxOTI0ZnZWT01FUU9RN1RieUYzd1Q5U3BHUlpWZFcwNzFQekVQT3Fh?= =?utf-8?B?Z2poTEQ3TmdIWXh6VlplNnZIcXhIb3VXMzRIMHhEQXp4OEwvWURsQWYyZFpm?= =?utf-8?B?MmdSa1psSHp3SGZmdUJIWURVU1ZyVVRqVWRDK0ZwY3Z5R1ZXNDExeTN1b1Fr?= =?utf-8?B?aG1UM0FySmF5OHp5NUZSdlpZa1dpVnBMbForTktKdWhFTkZKemM3MC9UUEZB?= =?utf-8?B?dDBmTnRUT0RydjlNOFVNR0NoM1BvOG9OYzh0YkgwM0RMVnVDbzZrTFlNWm1h?= =?utf-8?B?OTVPdGpPcVdnSDNoS3VQK1ZxckVkeTRBcm03cDhBM09CNzJmakRpK2M4NkE0?= =?utf-8?B?Y1g5Qk9DM29Sck1QeXdxQkl5REZxbitRZHRIWTU2N3YwNEQyaTVrNXdkY1pt?= =?utf-8?B?eGliblVBRW5oeHpCeW15bDN3bW1EVU5zZHpqM0N3SnNoc2dRQ0FmODFyNUxP?= =?utf-8?B?NU9VRGFtM0UwejhCWmJlUGJSNDhlRkcrVEFJcCtLRUhVNnpKaTV3dmEwNmt3?= =?utf-8?B?YzN5VTZ5TUxzU09tSTFQMllSSmxESWd4TlcranRwTVZtWVJMdVdBVXJrdXM2?= =?utf-8?B?NnBiMXpxbHlWaVM3VTFUS0xqZmNEMHpQeThzWmFiWHltZmUvZlMwUE5kbWJ3?= =?utf-8?Q?4iDMAebDz3DQJQHl4ug6tW+UtT5hNixXyU8D51q?= X-OriginatorOrg: kontron.de X-MS-Exchange-CrossTenant-Network-Message-Id: a05a732a-7e3d-439a-fe7d-08d93ad24ab6 X-MS-Exchange-CrossTenant-AuthSource: AM0PR10MB2963.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2021 07:48:32.2004 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SGW6S9fFnq8A0/TSYu5pYJB7ghoXxf0X7gyTJmfa6ZDwpalIB9v7i21aLphSFVBthyBe8ZtnCvyYwBf7+LUCwsSqx3XpUEkXmpqZAf2qCbA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR10MB4626 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210629_004835_225593_FF51E26F X-CRM114-Status: GOOD ( 32.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Tim, On 11.06.21 20:55, Tim Harvey wrote: > On Mon, Jun 7, 2021 at 1:34 AM Frieder Schrempf > wrote: >> >> On 07.06.21 10:00, Jacky Bai wrote: >>>> Subject: Re: [PATCH 1/4] arm64: dts: imx8mm-venice-gw700x: override >>>> thermal cfg for industrial temp >>>> >>>> On 07.06.21 09:30, Jacky Bai wrote: >>>>>> Subject: Re: [PATCH 1/4] arm64: dts: imx8mm-venice-gw700x: override >>>>>> thermal cfg for industrial temp >>>>>> >>>>>> On 04.06.21 17:42, Tim Harvey wrote: >>>>>>> On Wed, Jun 2, 2021 at 12:11 AM Frieder Schrempf >>>>>>> wrote: >>>>>>>> >>>>>>>> On 01.06.21 19:49, Tim Harvey wrote: >>>>>>>>> Override the default temperature alert/crit for Industrial temp >>>>>>>>> IMX8M Mini. >>>>>>>>> >>>>>>>>> Signed-off-by: Tim Harvey >>>>>>>>> --- >>>>>>>>> .../boot/dts/freescale/imx8mm-venice-gw700x.dtsi | 12 >>>>>> ++++++++++++ >>>>>>>>> 1 file changed, 12 insertions(+) >>>>>>>>> >>>>>>>>> diff --git >>>>>>>>> a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi >>>>>>>>> b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi >>>>>>>>> index c769fadbd008..512b76cd7c3b 100644 >>>>>>>>> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi >>>>>>>>> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi >>>>>>>>> @@ -493,3 +493,15 @@ >>>>>>>>> >; >>>>>>>>> }; >>>>>>>>> }; >>>>>>>>> + >>>>>>>>> +&cpu_alert0 { >>>>>>>>> + temperature = <95000>; >>>>>>>>> + hysteresis = <2000>; >>>>>>>>> + type = "passive"; >>>>>>>>> +}; >>>>>>>>> + >>>>>>>>> +&cpu_crit0 { >>>>>>>>> + temperature = <105000>; >>>>>>>>> + hysteresis = <2000>; >>>>>>>>> + type = "critical"; >>>>>>>>> +}; >>>>>>>> >>>>>>>> As this is not really board-specific, I think the proper way to >>>>>>>> handle this for >>>>>> all boards is to let the thermal driver read the temperature grading >>>>>> from the OTP fuses and set the trip-points accordingly, similar to >>>>>> what is done on i.MX6 [1]. >>>>>>>> >>>>> ... >>>>>>> >>>>>>> Frieder, >>>>>>> >>>>>>> Yes, I thought about adding that kind of support to imx8mm_thermal.c >>>>>>> but the difference is that imx8mm has alerts defined by dt and imx6 >>>>>>> does not so is it right to override dt alerts on imx8m? What if >>>>>>> someone designs a board that they specifically want a lower alert >>>>>>> than the cpu grade they are using based on something else on the board? >>>>>>> >>>>>>> My approach to this was to eventually actually adjust the imx8m dt >>>>>>> alerts in boot firmware based on some boot firmware setting or >>>>>>> specific board support and leave the kernel alone. >>>>>> >>>>>> Allowing board-specific trip points sounds like a valid request, but >>>>>> I still think we need a way to handle the temperature grading in the >>>>>> driver if no board-specific trip-points are given. >>>>>> >>>>>> What if we just set the temperature property in the trip nodes in >>>>>> imx8mm.dtsi to zero? The thermal driver would detect this and setup >>>>>> the correct values according to the grading. If the dt already >>>>>> provides non-zero temperature values (through the board dts) the >>>>>> driver will just leave the values and disregard the grading. >>>>>> >>>>>> I think this solution would be covering all needs. >>>>> >>>>> I thought to add the grading check in the imx8mm_thermal.c to >>>>> dynamically set the trip points temp, but it seems hard to do it due >>>>> to the fact of_thermal is used, as no helper API is exported by of_thermal, >>>> no better way to override the trip point temp. >>>>> >>>>> glad to see any good suggestions. >>>> >>>> Right, the driver doesn't handle the trip-points directly. This is all hidden in the >>>> framework. So this might not be so easy to implement. >>>> >>>> What about this other approach: Adding all the possible trip-points for the >>>> different gradings to the SoC-devicetree and then let the thermal driver >>>> remove the trip nodes from the dt that are not valid for the detected grading, >>>> just before the driver registers the sensor/zone. >>> >>> It is more reasonable for the firmware/bootloader to handle this by checking the grading. >> >> If possible, I would rather like to avoid creating another dependency on bootloader/firmware. I think the kernel should be able to detect the grading by itself and adjust its behavior accordingly. We also do this for the speed grading in cpufreq. > > Frieder and Jacky, > > I'm ok with dropping this dt patch and instead implementing something > in boot firmware that automatically detects and adjusts there. I'm not > given the time to work through a more complicated or more elegant > solution kernel-only approach for this and handling it in the boot > firmware will not break anything or create a dependence from where we > currently stand. We already have things in boot firmware that populate > mac addresses, mtd partition ids, etc in dt during runtime. >From my point of view you can also keep this patch until this is solved properly. Still, in the long run I think we need a solution that automatically handles the different SoC temperature gradings even if of_thermal is used and there is only a single devicetree to describe the SoC variants. It's similar to the case of the CPU's frequency/voltage setpoints in cpufreq. I'm Cc-ing people from the thermal subsystem. Maybe they have some suggestion or this case has already been discussed elsewhere. Best regards Frieder _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel