From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26B41C32771 for ; Wed, 21 Sep 2022 08:41:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NCBwhAgoCmAVQmhf3fiBlLaaVWuJtaHD1oCAqjbB2T8=; b=ISbqBaSRLRMiKj 61YvS6RNmL2i7YrKh/tGSqYRFv9qUK4IBh1O8nOkehva63LGbhOQLJHu/JXz02O+opOYuLq5xgyFC tz5DoYSVp2lb3extYuUxV/dZgvXfJbMNOrstVtZnrxK6pKOoNq7FmdmRK4+lhqKH3L8PcrTDnZ613 qswn90CysKPc7HpX20qDU/SyEHGjaFaXAHxvqJxzH4vrse1Enlkl4rKxI62CjlfsiWncZ2Ngk5mZs NVxG+i1WnGkB0kITGMXsWvhKJwLTFa6pi/EYPbOkeBpkUPx37Nz7afi3+LhqrvLxM2Wfgf9BJOdEu bMRSRkUj3XCyvcb11lng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oavGt-00A29m-M6; Wed, 21 Sep 2022 08:39:56 +0000 Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oav31-009w7Y-9U for linux-arm-kernel@lists.infradead.org; Wed, 21 Sep 2022 08:25:36 +0000 Received: by mail-lf1-x133.google.com with SMTP id a3so7929135lfk.9 for ; Wed, 21 Sep 2022 01:25:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=kllsaU+NrhBActC8/Ko962C+vx5weLH497C4j1ASf9o=; b=zWLXZoJJQ3xhYU/XcWK2I428YuQvun/7UY+WRs0+BYAAZKcmybbhZqBOE3OweGuGY4 1XHSKLHuXqUa9vJU7EoRVjf9weaO9bwDxbR3jMAzcRsqzCe8qMpDLnUSxHDMrsoiM01z Uau16EpBeQDeVz+urQlXrcatyvzv1bY/dsJyps3utYxS4jFm0Faj51cwy8sVz9MHfaTA pbvvzGCEkjH0bnsanues36FdO9hFUzPnn21WWOoJOI1RIq3epBujjl+cxwKdvjPxtwQa RmKNYIH4DnY8lCDYpdPGxJrdJMPmA8tht2L7GRe0YhG/CwAjwGfGjNEQYVuRL/VR/Dhd io1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=kllsaU+NrhBActC8/Ko962C+vx5weLH497C4j1ASf9o=; b=q7gyCMuz3SEp/6isuqTbiqfWsYxAW930Ut3JN9l55aKQQjFQvosxn+WfoExnYava4U BStTxu0mvHrLmxTuTCFkTn8NmnPzHTyxRA8F/aF7skw6tkoxdqR+SruyEr6828KJ5ozY 6ii2F+urlUbedBX606qNEy/vY6JZKDv4fw72dEfHMeX9xZ7tX+vb5M2gfz2OU8PEv3KR tUQd8ocJpvG3O/8UqI0zfkKZEdWsoe8H6xly5FmRqw5DyA/OCX6QCkBREoMToG+PS2ym +by/OpdV+G8l35nEXkziHrJhCtRKbjR68ELrfVBUxfpk0crNHc9+kxbpTiS/Bh2mwvmt zH8Q== X-Gm-Message-State: ACrzQf3wb7hDFuuVCCm9zkqaj2sa0x7nYgSttTeCe+O2QFTbEq1JMknc ZfmAW3DpevaI3ax+kUFSQmOAPQ== X-Google-Smtp-Source: AMsMyM5Qnrc77hlPHwoCJT5SM2C65rB7OQsSimZswtBSaPyKSq1NdLzlagQ3zPjvK3IlD/iswCJP1A== X-Received: by 2002:a05:6512:6c8:b0:49a:1765:335d with SMTP id u8-20020a05651206c800b0049a1765335dmr9283076lff.29.1663748732570; Wed, 21 Sep 2022 01:25:32 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id v18-20020a2ea612000000b0026c4113c150sm329526ljp.111.2022.09.21.01.25.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Sep 2022 01:25:31 -0700 (PDT) Message-ID: <7edc0445-c5d4-64a7-0261-f9db9b10158e@linaro.org> Date: Wed, 21 Sep 2022 10:25:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [RFC V2 PATCH 2/3] dt-bindings: net: xilinx_axienet: Introduce dmaengine binding support Content-Language: en-US To: "Pandey, Radhey Shyam" , "Gaddam, Sarath Babu Naidu" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "linux@armlinux.org.uk" Cc: "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "Simek, Michal" , "Sarangi, Anirudha" , "Katakam, Harini" , "git@xilinx.com" , "git (AMD-Xilinx)" References: <20220920055703.13246-1-sarath.babu.naidu.gaddam@amd.com> <20220920055703.13246-3-sarath.babu.naidu.gaddam@amd.com> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220921_012535_390680_9D169231 X-CRM114-Status: GOOD ( 19.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21/09/2022 10:23, Pandey, Radhey Shyam wrote: >>> required: >>> - compatible >>> - interrupts >>> - reg >>> - xlnx,rxmem >>> - phy-handle >>> + - dmas >>> + - dma-names >>> >>> additionalProperties: false >>> >>> @@ -132,11 +137,13 @@ examples: >>> axi_ethernet_eth: ethernet@40c00000 { >>> compatible = "xlnx,axi-ethernet-1.00.a"; >>> interrupt-parent = <µblaze_0_axi_intc>; >>> - interrupts = <2>, <0>, <1>; >>> + interrupts = <1>; >> >> This looks like an ABI break. How do you handle old DTS? Oh wait... you do >> not handle it at all. > > Yes, this is anticipated ABI break due to major changes in axiethernet > driver while adopting to dmaengine framework. Same is highlighted > in commit description - "DT changes are not backward compatible > due to major driver restructuring/cleanup done in adopting the > dmaengine framework". > > Some background - Factor out AXI DMA code into separate driver was > a TODO item (mentioned in driver changelog) and is being done as > part of this series. The DMA code is removed from axiethernet driver > and ethernet driver now make use of dmaengine framework to > communicate with AXIDMA IP. > > When DMA code is removed from axiethernet driver there is limitation > to support legacy DMA resources binding. One option is to inform > user to switch to new binding when old DTS is detected? (and at some > point we have to make this transition and remove dma code). If you keep ABI non-broken, such message is a good idea. > Please let us know if there are any other alternative to consider? You just cannot break ABI just because you want to refactor some code in driver. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel