* [PATCH v2 0/2] i2c: i2c-stm32f7: allow range of I2C bus frequency @ 2020-03-26 12:44 Alain Volmat 2020-03-26 12:44 ` [PATCH v2 1/2] dt-bindings: i2c: i2c-stm32f7: allow clock-frequency range Alain Volmat 2020-03-26 12:44 ` [PATCH v2 2/2] i2c: i2c-stm32f7: allows for any bus frequency Alain Volmat 0 siblings, 2 replies; 7+ messages in thread From: Alain Volmat @ 2020-03-26 12:44 UTC (permalink / raw) To: wsa, robh+dt Cc: mark.rutland, devicetree, alexandre.torgue, linux-kernel, pierre-yves.mordret, alain.volmat, linux-i2c, mcoquelin.stm32, fabrice.gasnier, linux-stm32, linux-arm-kernel This serie introduces the possibility to set bus frequency other than 100KHz, 400KHz and 1MHz. Changelog: v2: fix i2c: i2c-stm32f7: allows for any bus frequency patch Alain Volmat (2): dt-bindings: i2c: i2c-stm32f7: allow clock-frequency range i2c: i2c-stm32f7: allows for any bus frequency .../devicetree/bindings/i2c/st,stm32-i2c.yaml | 8 +- drivers/i2c/busses/i2c-stm32f7.c | 116 +++++++++--------- 2 files changed, 65 insertions(+), 59 deletions(-) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 1/2] dt-bindings: i2c: i2c-stm32f7: allow clock-frequency range 2020-03-26 12:44 [PATCH v2 0/2] i2c: i2c-stm32f7: allow range of I2C bus frequency Alain Volmat @ 2020-03-26 12:44 ` Alain Volmat 2020-04-04 17:18 ` Rob Herring 2020-03-26 12:44 ` [PATCH v2 2/2] i2c: i2c-stm32f7: allows for any bus frequency Alain Volmat 1 sibling, 1 reply; 7+ messages in thread From: Alain Volmat @ 2020-03-26 12:44 UTC (permalink / raw) To: wsa, robh+dt Cc: mark.rutland, devicetree, alexandre.torgue, linux-kernel, pierre-yves.mordret, alain.volmat, linux-i2c, mcoquelin.stm32, fabrice.gasnier, linux-stm32, linux-arm-kernel For STM32F7, STM32H7 and STM32MP1 SoCs, if timing parameters match, the bus clock frequency can be from 1Hz to 1MHz. Signed-off-by: Alain Volmat <alain.volmat@st.com> --- v2: identical to v1 Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml b/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml index 900ec1ab6a47..b50a2f420b36 100644 --- a/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml +++ b/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml @@ -80,11 +80,11 @@ properties: clock-frequency: description: Desired I2C bus clock frequency in Hz. If not specified, the default 100 kHz frequency will be used. - For STM32F7, STM32H7 and STM32MP1 SoCs, Standard-mode, - Fast-mode and Fast-mode Plus are supported, possible - values are 100000, 400000 and 1000000. + For STM32F7, STM32H7 and STM32MP1 SoCs, if timing parameters + match, the bus clock frequency can be from 1Hz to 1MHz. default: 100000 - enum: [100000, 400000, 1000000] + minimum: 1 + maximum: 1000000 required: - compatible -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: i2c: i2c-stm32f7: allow clock-frequency range 2020-03-26 12:44 ` [PATCH v2 1/2] dt-bindings: i2c: i2c-stm32f7: allow clock-frequency range Alain Volmat @ 2020-04-04 17:18 ` Rob Herring 0 siblings, 0 replies; 7+ messages in thread From: Rob Herring @ 2020-04-04 17:18 UTC (permalink / raw) To: Alain Volmat Cc: mark.rutland, devicetree, alexandre.torgue, wsa, linux-kernel, pierre-yves.mordret, alain.volmat, robh+dt, linux-i2c, mcoquelin.stm32, fabrice.gasnier, linux-stm32, linux-arm-kernel On Thu, 26 Mar 2020 13:44:20 +0100, Alain Volmat wrote: > For STM32F7, STM32H7 and STM32MP1 SoCs, if timing parameters > match, the bus clock frequency can be from 1Hz to 1MHz. > > Signed-off-by: Alain Volmat <alain.volmat@st.com> > --- > v2: identical to v1 > > Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 2/2] i2c: i2c-stm32f7: allows for any bus frequency 2020-03-26 12:44 [PATCH v2 0/2] i2c: i2c-stm32f7: allow range of I2C bus frequency Alain Volmat 2020-03-26 12:44 ` [PATCH v2 1/2] dt-bindings: i2c: i2c-stm32f7: allow clock-frequency range Alain Volmat @ 2020-03-26 12:44 ` Alain Volmat 2020-03-30 8:48 ` Pierre Yves MORDRET 2020-04-15 11:09 ` Wolfram Sang 1 sibling, 2 replies; 7+ messages in thread From: Alain Volmat @ 2020-03-26 12:44 UTC (permalink / raw) To: wsa, robh+dt Cc: mark.rutland, devicetree, alexandre.torgue, linux-kernel, pierre-yves.mordret, alain.volmat, linux-i2c, mcoquelin.stm32, fabrice.gasnier, linux-stm32, linux-arm-kernel Do not limitate to the 3 (100KHz, 400KHz, 1MHz) bus frequency but instead allows any frequency (if it matches timing requirements). Depending on the requested frequency, use the spec data from either Standard, Fast or Fast Plus mode. Hardcoding of min/max bus frequencies is removed and is instead computed. The driver do not use anymore speed identifier but instead handle directly the frequency and figure out the spec data (necessary for the computation of the timing register) based on the frequency. Signed-off-by: Alain Volmat <alain.volmat@st.com> --- v2: remove wrong "NOT REACHED" comment simplify get_lower_rate function drivers/i2c/busses/i2c-stm32f7.c | 115 ++++++++++++++++--------------- 1 file changed, 60 insertions(+), 55 deletions(-) diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c index 330ffed011e0..f369f086b9d0 100644 --- a/drivers/i2c/busses/i2c-stm32f7.c +++ b/drivers/i2c/busses/i2c-stm32f7.c @@ -189,8 +189,6 @@ struct stm32f7_i2c_regs { /** * struct stm32f7_i2c_spec - private i2c specification timing * @rate: I2C bus speed (Hz) - * @rate_min: 80% of I2C bus speed (Hz) - * @rate_max: 100% of I2C bus speed (Hz) * @fall_max: Max fall time of both SDA and SCL signals (ns) * @rise_max: Max rise time of both SDA and SCL signals (ns) * @hddat_min: Min data hold time (ns) @@ -201,8 +199,6 @@ struct stm32f7_i2c_regs { */ struct stm32f7_i2c_spec { u32 rate; - u32 rate_min; - u32 rate_max; u32 fall_max; u32 rise_max; u32 hddat_min; @@ -214,7 +210,6 @@ struct stm32f7_i2c_spec { /** * struct stm32f7_i2c_setup - private I2C timing setup parameters - * @speed: I2C speed mode (standard, Fast Plus) * @speed_freq: I2C speed frequency (Hz) * @clock_src: I2C clock source frequency (Hz) * @rise_time: Rise time (ns) @@ -224,7 +219,6 @@ struct stm32f7_i2c_spec { * @fmp_clr_offset: Fast Mode Plus clear register offset from set register */ struct stm32f7_i2c_setup { - enum stm32_i2c_speed speed; u32 speed_freq; u32 clock_src; u32 rise_time; @@ -287,7 +281,7 @@ struct stm32f7_i2c_msg { * @base: virtual memory area * @complete: completion of I2C message * @clk: hw i2c clock - * @speed: I2C clock frequency of the controller. Standard, Fast or Fast+ + * @bus_rate: I2C clock frequency of the controller * @msg: Pointer to data to be written * @msg_num: number of I2C messages to be executed * @msg_id: message identifiant @@ -314,7 +308,7 @@ struct stm32f7_i2c_dev { void __iomem *base; struct completion complete; struct clk *clk; - int speed; + unsigned int bus_rate; struct i2c_msg *msg; unsigned int msg_num; unsigned int msg_id; @@ -343,10 +337,8 @@ struct stm32f7_i2c_dev { * and Fast-mode Plus I2C-bus devices */ static struct stm32f7_i2c_spec i2c_specs[] = { - [STM32_I2C_SPEED_STANDARD] = { + { .rate = I2C_MAX_STANDARD_MODE_FREQ, - .rate_min = I2C_MAX_STANDARD_MODE_FREQ * 8 / 10, /* 80% */ - .rate_max = I2C_MAX_STANDARD_MODE_FREQ, .fall_max = 300, .rise_max = 1000, .hddat_min = 0, @@ -355,10 +347,8 @@ static struct stm32f7_i2c_spec i2c_specs[] = { .l_min = 4700, .h_min = 4000, }, - [STM32_I2C_SPEED_FAST] = { + { .rate = I2C_MAX_FAST_MODE_FREQ, - .rate_min = I2C_MAX_FAST_MODE_FREQ * 8 / 10, /* 80% */ - .rate_max = I2C_MAX_FAST_MODE_FREQ, .fall_max = 300, .rise_max = 300, .hddat_min = 0, @@ -367,10 +357,8 @@ static struct stm32f7_i2c_spec i2c_specs[] = { .l_min = 1300, .h_min = 600, }, - [STM32_I2C_SPEED_FAST_PLUS] = { + { .rate = I2C_MAX_FAST_MODE_PLUS_FREQ, - .rate_min = I2C_MAX_FAST_MODE_PLUS_FREQ * 8 / 10, /* 80% */ - .rate_max = I2C_MAX_FAST_MODE_PLUS_FREQ, .fall_max = 100, .rise_max = 120, .hddat_min = 0, @@ -411,10 +399,23 @@ static void stm32f7_i2c_disable_irq(struct stm32f7_i2c_dev *i2c_dev, u32 mask) stm32f7_i2c_clr_bits(i2c_dev->base + STM32F7_I2C_CR1, mask); } +static struct stm32f7_i2c_spec *get_specs(u32 rate) +{ + int i; + + for (i = 0; i < ARRAY_SIZE(i2c_specs); i++) + if (rate <= i2c_specs[i].rate) + return &i2c_specs[i]; + + return ERR_PTR(-EINVAL); +} + +#define RATE_MIN(rate) (rate * 8 / 10) static int stm32f7_i2c_compute_timing(struct stm32f7_i2c_dev *i2c_dev, struct stm32f7_i2c_setup *setup, struct stm32f7_i2c_timings *output) { + struct stm32f7_i2c_spec *specs; u32 p_prev = STM32F7_PRESC_MAX; u32 i2cclk = DIV_ROUND_CLOSEST(NSEC_PER_SEC, setup->clock_src); @@ -432,18 +433,19 @@ static int stm32f7_i2c_compute_timing(struct stm32f7_i2c_dev *i2c_dev, u16 p, l, a, h; int ret = 0; - if (setup->speed >= STM32_I2C_SPEED_END) { - dev_err(i2c_dev->dev, "speed out of bound {%d/%d}\n", - setup->speed, STM32_I2C_SPEED_END - 1); + specs = get_specs(setup->speed_freq); + if (specs == ERR_PTR(-EINVAL)) { + dev_err(i2c_dev->dev, "speed out of bound {%d}\n", + setup->speed_freq); return -EINVAL; } - if ((setup->rise_time > i2c_specs[setup->speed].rise_max) || - (setup->fall_time > i2c_specs[setup->speed].fall_max)) { + if ((setup->rise_time > specs->rise_max) || + (setup->fall_time > specs->fall_max)) { dev_err(i2c_dev->dev, "timings out of bound Rise{%d>%d}/Fall{%d>%d}\n", - setup->rise_time, i2c_specs[setup->speed].rise_max, - setup->fall_time, i2c_specs[setup->speed].fall_max); + setup->rise_time, specs->rise_max, + setup->fall_time, specs->fall_max); return -EINVAL; } @@ -454,12 +456,6 @@ static int stm32f7_i2c_compute_timing(struct stm32f7_i2c_dev *i2c_dev, return -EINVAL; } - if (setup->speed_freq > i2c_specs[setup->speed].rate) { - dev_err(i2c_dev->dev, "ERROR: Freq {%d/%d}\n", - setup->speed_freq, i2c_specs[setup->speed].rate); - return -EINVAL; - } - /* Analog and Digital Filters */ af_delay_min = (setup->analog_filter ? @@ -469,13 +465,13 @@ static int stm32f7_i2c_compute_timing(struct stm32f7_i2c_dev *i2c_dev, STM32F7_I2C_ANALOG_FILTER_DELAY_MAX : 0); dnf_delay = setup->dnf * i2cclk; - sdadel_min = i2c_specs[setup->speed].hddat_min + setup->fall_time - + sdadel_min = specs->hddat_min + setup->fall_time - af_delay_min - (setup->dnf + 3) * i2cclk; - sdadel_max = i2c_specs[setup->speed].vddat_max - setup->rise_time - + sdadel_max = specs->vddat_max - setup->rise_time - af_delay_max - (setup->dnf + 4) * i2cclk; - scldel_min = setup->rise_time + i2c_specs[setup->speed].sudat_min; + scldel_min = setup->rise_time + specs->sudat_min; if (sdadel_min < 0) sdadel_min = 0; @@ -530,8 +526,8 @@ static int stm32f7_i2c_compute_timing(struct stm32f7_i2c_dev *i2c_dev, tsync = af_delay_min + dnf_delay + (2 * i2cclk); s = NULL; - clk_max = NSEC_PER_SEC / i2c_specs[setup->speed].rate_min; - clk_min = NSEC_PER_SEC / i2c_specs[setup->speed].rate_max; + clk_max = NSEC_PER_SEC / RATE_MIN(setup->speed_freq); + clk_min = NSEC_PER_SEC / setup->speed_freq; /* * Among Prescaler possibilities discovered above figures out SCL Low @@ -549,7 +545,7 @@ static int stm32f7_i2c_compute_timing(struct stm32f7_i2c_dev *i2c_dev, for (l = 0; l < STM32F7_SCLL_MAX; l++) { u32 tscl_l = (l + 1) * prescaler + tsync; - if ((tscl_l < i2c_specs[setup->speed].l_min) || + if ((tscl_l < specs->l_min) || (i2cclk >= ((tscl_l - af_delay_min - dnf_delay) / 4))) { continue; @@ -561,7 +557,7 @@ static int stm32f7_i2c_compute_timing(struct stm32f7_i2c_dev *i2c_dev, setup->rise_time + setup->fall_time; if ((tscl >= clk_min) && (tscl <= clk_max) && - (tscl_h >= i2c_specs[setup->speed].h_min) && + (tscl_h >= specs->h_min) && (i2cclk < tscl_h)) { int clk_error = tscl - i2cbus; @@ -607,6 +603,17 @@ static int stm32f7_i2c_compute_timing(struct stm32f7_i2c_dev *i2c_dev, return ret; } +static u32 get_lower_rate(u32 rate) +{ + int i = ARRAY_SIZE(i2c_specs); + + while (i--) + if (i2c_specs[i].rate < rate) + break; + + return i2c_specs[i].rate; +} + static int stm32f7_i2c_setup_timing(struct stm32f7_i2c_dev *i2c_dev, struct stm32f7_i2c_setup *setup) { @@ -619,18 +626,15 @@ static int stm32f7_i2c_setup_timing(struct stm32f7_i2c_dev *i2c_dev, i2c_parse_fw_timings(i2c_dev->dev, t, false); - if (t->bus_freq_hz >= I2C_MAX_FAST_MODE_PLUS_FREQ) - i2c_dev->speed = STM32_I2C_SPEED_FAST_PLUS; - else if (t->bus_freq_hz >= I2C_MAX_FAST_MODE_FREQ) - i2c_dev->speed = STM32_I2C_SPEED_FAST; - else - i2c_dev->speed = STM32_I2C_SPEED_STANDARD; + if (t->bus_freq_hz > I2C_MAX_FAST_MODE_PLUS_FREQ) { + dev_err(i2c_dev->dev, "Invalid bus speed (%i>%i)\n", + t->bus_freq_hz, I2C_MAX_FAST_MODE_PLUS_FREQ); + return -EINVAL; + } + setup->speed_freq = t->bus_freq_hz; i2c_dev->setup.rise_time = t->scl_rise_ns; i2c_dev->setup.fall_time = t->scl_fall_ns; - - setup->speed = i2c_dev->speed; - setup->speed_freq = i2c_specs[setup->speed].rate; setup->clock_src = clk_get_rate(i2c_dev->clk); if (!setup->clock_src) { @@ -644,14 +648,12 @@ static int stm32f7_i2c_setup_timing(struct stm32f7_i2c_dev *i2c_dev, if (ret) { dev_err(i2c_dev->dev, "failed to compute I2C timings.\n"); - if (i2c_dev->speed > STM32_I2C_SPEED_STANDARD) { - i2c_dev->speed--; - setup->speed = i2c_dev->speed; + if (setup->speed_freq > I2C_MAX_STANDARD_MODE_FREQ) { setup->speed_freq = - i2c_specs[setup->speed].rate; + get_lower_rate(setup->speed_freq); dev_warn(i2c_dev->dev, "downgrade I2C Speed Freq to (%i)\n", - i2c_specs[setup->speed].rate); + setup->speed_freq); } else { break; } @@ -663,13 +665,15 @@ static int stm32f7_i2c_setup_timing(struct stm32f7_i2c_dev *i2c_dev, return ret; } - dev_dbg(i2c_dev->dev, "I2C Speed(%i), Freq(%i), Clk Source(%i)\n", - setup->speed, setup->speed_freq, setup->clock_src); + dev_dbg(i2c_dev->dev, "I2C Speed(%i), Clk Source(%i)\n", + setup->speed_freq, setup->clock_src); dev_dbg(i2c_dev->dev, "I2C Rise(%i) and Fall(%i) Time\n", setup->rise_time, setup->fall_time); dev_dbg(i2c_dev->dev, "I2C Analog Filter(%s), DNF(%i)\n", (setup->analog_filter ? "On" : "Off"), setup->dnf); + i2c_dev->bus_rate = setup->speed_freq; + return 0; } @@ -1866,7 +1870,7 @@ static int stm32f7_i2c_write_fm_plus_bits(struct stm32f7_i2c_dev *i2c_dev, { int ret; - if (i2c_dev->speed != STM32_I2C_SPEED_FAST_PLUS || + if (i2c_dev->bus_rate <= I2C_MAX_FAST_MODE_FREQ || IS_ERR_OR_NULL(i2c_dev->regmap)) /* Optional */ return 0; @@ -2020,7 +2024,8 @@ static int stm32f7_i2c_probe(struct platform_device *pdev) if (ret) goto clk_free; - if (i2c_dev->speed == STM32_I2C_SPEED_FAST_PLUS) { + /* Setup Fast mode plus if necessary */ + if (i2c_dev->bus_rate > I2C_MAX_FAST_MODE_FREQ) { ret = stm32f7_i2c_setup_fm_plus_bits(pdev, i2c_dev); if (ret) goto clk_free; -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/2] i2c: i2c-stm32f7: allows for any bus frequency 2020-03-26 12:44 ` [PATCH v2 2/2] i2c: i2c-stm32f7: allows for any bus frequency Alain Volmat @ 2020-03-30 8:48 ` Pierre Yves MORDRET 2020-04-15 11:09 ` Wolfram Sang 1 sibling, 0 replies; 7+ messages in thread From: Pierre Yves MORDRET @ 2020-03-30 8:48 UTC (permalink / raw) To: Alain Volmat, wsa, robh+dt Cc: mark.rutland, devicetree, alexandre.torgue, linux-kernel, linux-i2c, mcoquelin.stm32, fabrice.gasnier, linux-stm32, linux-arm-kernel Hello guys Reviewed-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com> Thanks On 3/26/20 1:44 PM, Alain Volmat wrote: > Do not limitate to the 3 (100KHz, 400KHz, 1MHz) bus frequency but > instead allows any frequency (if it matches timing requirements). > Depending on the requested frequency, use the spec data from either > Standard, Fast or Fast Plus mode. > > Hardcoding of min/max bus frequencies is removed and is instead computed. > > The driver do not use anymore speed identifier but instead handle > directly the frequency and figure out the spec data (necessary > for the computation of the timing register) based on the frequency. > > Signed-off-by: Alain Volmat <alain.volmat@st.com> > --- > v2: remove wrong "NOT REACHED" comment > simplify get_lower_rate function > > drivers/i2c/busses/i2c-stm32f7.c | 115 ++++++++++++++++--------------- > 1 file changed, 60 insertions(+), 55 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c > index 330ffed011e0..f369f086b9d0 100644 > --- a/drivers/i2c/busses/i2c-stm32f7.c > +++ b/drivers/i2c/busses/i2c-stm32f7.c > @@ -189,8 +189,6 @@ struct stm32f7_i2c_regs { > /** > * struct stm32f7_i2c_spec - private i2c specification timing > * @rate: I2C bus speed (Hz) > - * @rate_min: 80% of I2C bus speed (Hz) > - * @rate_max: 100% of I2C bus speed (Hz) > * @fall_max: Max fall time of both SDA and SCL signals (ns) > * @rise_max: Max rise time of both SDA and SCL signals (ns) > * @hddat_min: Min data hold time (ns) > @@ -201,8 +199,6 @@ struct stm32f7_i2c_regs { > */ > struct stm32f7_i2c_spec { > u32 rate; > - u32 rate_min; > - u32 rate_max; > u32 fall_max; > u32 rise_max; > u32 hddat_min; > @@ -214,7 +210,6 @@ struct stm32f7_i2c_spec { > > /** > * struct stm32f7_i2c_setup - private I2C timing setup parameters > - * @speed: I2C speed mode (standard, Fast Plus) > * @speed_freq: I2C speed frequency (Hz) > * @clock_src: I2C clock source frequency (Hz) > * @rise_time: Rise time (ns) > @@ -224,7 +219,6 @@ struct stm32f7_i2c_spec { > * @fmp_clr_offset: Fast Mode Plus clear register offset from set register > */ > struct stm32f7_i2c_setup { > - enum stm32_i2c_speed speed; > u32 speed_freq; > u32 clock_src; > u32 rise_time; > @@ -287,7 +281,7 @@ struct stm32f7_i2c_msg { > * @base: virtual memory area > * @complete: completion of I2C message > * @clk: hw i2c clock > - * @speed: I2C clock frequency of the controller. Standard, Fast or Fast+ > + * @bus_rate: I2C clock frequency of the controller > * @msg: Pointer to data to be written > * @msg_num: number of I2C messages to be executed > * @msg_id: message identifiant > @@ -314,7 +308,7 @@ struct stm32f7_i2c_dev { > void __iomem *base; > struct completion complete; > struct clk *clk; > - int speed; > + unsigned int bus_rate; > struct i2c_msg *msg; > unsigned int msg_num; > unsigned int msg_id; > @@ -343,10 +337,8 @@ struct stm32f7_i2c_dev { > * and Fast-mode Plus I2C-bus devices > */ > static struct stm32f7_i2c_spec i2c_specs[] = { > - [STM32_I2C_SPEED_STANDARD] = { > + { > .rate = I2C_MAX_STANDARD_MODE_FREQ, > - .rate_min = I2C_MAX_STANDARD_MODE_FREQ * 8 / 10, /* 80% */ > - .rate_max = I2C_MAX_STANDARD_MODE_FREQ, > .fall_max = 300, > .rise_max = 1000, > .hddat_min = 0, > @@ -355,10 +347,8 @@ static struct stm32f7_i2c_spec i2c_specs[] = { > .l_min = 4700, > .h_min = 4000, > }, > - [STM32_I2C_SPEED_FAST] = { > + { > .rate = I2C_MAX_FAST_MODE_FREQ, > - .rate_min = I2C_MAX_FAST_MODE_FREQ * 8 / 10, /* 80% */ > - .rate_max = I2C_MAX_FAST_MODE_FREQ, > .fall_max = 300, > .rise_max = 300, > .hddat_min = 0, > @@ -367,10 +357,8 @@ static struct stm32f7_i2c_spec i2c_specs[] = { > .l_min = 1300, > .h_min = 600, > }, > - [STM32_I2C_SPEED_FAST_PLUS] = { > + { > .rate = I2C_MAX_FAST_MODE_PLUS_FREQ, > - .rate_min = I2C_MAX_FAST_MODE_PLUS_FREQ * 8 / 10, /* 80% */ > - .rate_max = I2C_MAX_FAST_MODE_PLUS_FREQ, > .fall_max = 100, > .rise_max = 120, > .hddat_min = 0, > @@ -411,10 +399,23 @@ static void stm32f7_i2c_disable_irq(struct stm32f7_i2c_dev *i2c_dev, u32 mask) > stm32f7_i2c_clr_bits(i2c_dev->base + STM32F7_I2C_CR1, mask); > } > > +static struct stm32f7_i2c_spec *get_specs(u32 rate) > +{ > + int i; > + > + for (i = 0; i < ARRAY_SIZE(i2c_specs); i++) > + if (rate <= i2c_specs[i].rate) > + return &i2c_specs[i]; > + > + return ERR_PTR(-EINVAL); > +} > + > +#define RATE_MIN(rate) (rate * 8 / 10) > static int stm32f7_i2c_compute_timing(struct stm32f7_i2c_dev *i2c_dev, > struct stm32f7_i2c_setup *setup, > struct stm32f7_i2c_timings *output) > { > + struct stm32f7_i2c_spec *specs; > u32 p_prev = STM32F7_PRESC_MAX; > u32 i2cclk = DIV_ROUND_CLOSEST(NSEC_PER_SEC, > setup->clock_src); > @@ -432,18 +433,19 @@ static int stm32f7_i2c_compute_timing(struct stm32f7_i2c_dev *i2c_dev, > u16 p, l, a, h; > int ret = 0; > > - if (setup->speed >= STM32_I2C_SPEED_END) { > - dev_err(i2c_dev->dev, "speed out of bound {%d/%d}\n", > - setup->speed, STM32_I2C_SPEED_END - 1); > + specs = get_specs(setup->speed_freq); > + if (specs == ERR_PTR(-EINVAL)) { > + dev_err(i2c_dev->dev, "speed out of bound {%d}\n", > + setup->speed_freq); > return -EINVAL; > } > > - if ((setup->rise_time > i2c_specs[setup->speed].rise_max) || > - (setup->fall_time > i2c_specs[setup->speed].fall_max)) { > + if ((setup->rise_time > specs->rise_max) || > + (setup->fall_time > specs->fall_max)) { > dev_err(i2c_dev->dev, > "timings out of bound Rise{%d>%d}/Fall{%d>%d}\n", > - setup->rise_time, i2c_specs[setup->speed].rise_max, > - setup->fall_time, i2c_specs[setup->speed].fall_max); > + setup->rise_time, specs->rise_max, > + setup->fall_time, specs->fall_max); > return -EINVAL; > } > > @@ -454,12 +456,6 @@ static int stm32f7_i2c_compute_timing(struct stm32f7_i2c_dev *i2c_dev, > return -EINVAL; > } > > - if (setup->speed_freq > i2c_specs[setup->speed].rate) { > - dev_err(i2c_dev->dev, "ERROR: Freq {%d/%d}\n", > - setup->speed_freq, i2c_specs[setup->speed].rate); > - return -EINVAL; > - } > - > /* Analog and Digital Filters */ > af_delay_min = > (setup->analog_filter ? > @@ -469,13 +465,13 @@ static int stm32f7_i2c_compute_timing(struct stm32f7_i2c_dev *i2c_dev, > STM32F7_I2C_ANALOG_FILTER_DELAY_MAX : 0); > dnf_delay = setup->dnf * i2cclk; > > - sdadel_min = i2c_specs[setup->speed].hddat_min + setup->fall_time - > + sdadel_min = specs->hddat_min + setup->fall_time - > af_delay_min - (setup->dnf + 3) * i2cclk; > > - sdadel_max = i2c_specs[setup->speed].vddat_max - setup->rise_time - > + sdadel_max = specs->vddat_max - setup->rise_time - > af_delay_max - (setup->dnf + 4) * i2cclk; > > - scldel_min = setup->rise_time + i2c_specs[setup->speed].sudat_min; > + scldel_min = setup->rise_time + specs->sudat_min; > > if (sdadel_min < 0) > sdadel_min = 0; > @@ -530,8 +526,8 @@ static int stm32f7_i2c_compute_timing(struct stm32f7_i2c_dev *i2c_dev, > > tsync = af_delay_min + dnf_delay + (2 * i2cclk); > s = NULL; > - clk_max = NSEC_PER_SEC / i2c_specs[setup->speed].rate_min; > - clk_min = NSEC_PER_SEC / i2c_specs[setup->speed].rate_max; > + clk_max = NSEC_PER_SEC / RATE_MIN(setup->speed_freq); > + clk_min = NSEC_PER_SEC / setup->speed_freq; > > /* > * Among Prescaler possibilities discovered above figures out SCL Low > @@ -549,7 +545,7 @@ static int stm32f7_i2c_compute_timing(struct stm32f7_i2c_dev *i2c_dev, > for (l = 0; l < STM32F7_SCLL_MAX; l++) { > u32 tscl_l = (l + 1) * prescaler + tsync; > > - if ((tscl_l < i2c_specs[setup->speed].l_min) || > + if ((tscl_l < specs->l_min) || > (i2cclk >= > ((tscl_l - af_delay_min - dnf_delay) / 4))) { > continue; > @@ -561,7 +557,7 @@ static int stm32f7_i2c_compute_timing(struct stm32f7_i2c_dev *i2c_dev, > setup->rise_time + setup->fall_time; > > if ((tscl >= clk_min) && (tscl <= clk_max) && > - (tscl_h >= i2c_specs[setup->speed].h_min) && > + (tscl_h >= specs->h_min) && > (i2cclk < tscl_h)) { > int clk_error = tscl - i2cbus; > > @@ -607,6 +603,17 @@ static int stm32f7_i2c_compute_timing(struct stm32f7_i2c_dev *i2c_dev, > return ret; > } > > +static u32 get_lower_rate(u32 rate) > +{ > + int i = ARRAY_SIZE(i2c_specs); > + > + while (i--) > + if (i2c_specs[i].rate < rate) > + break; > + > + return i2c_specs[i].rate; > +} > + > static int stm32f7_i2c_setup_timing(struct stm32f7_i2c_dev *i2c_dev, > struct stm32f7_i2c_setup *setup) > { > @@ -619,18 +626,15 @@ static int stm32f7_i2c_setup_timing(struct stm32f7_i2c_dev *i2c_dev, > > i2c_parse_fw_timings(i2c_dev->dev, t, false); > > - if (t->bus_freq_hz >= I2C_MAX_FAST_MODE_PLUS_FREQ) > - i2c_dev->speed = STM32_I2C_SPEED_FAST_PLUS; > - else if (t->bus_freq_hz >= I2C_MAX_FAST_MODE_FREQ) > - i2c_dev->speed = STM32_I2C_SPEED_FAST; > - else > - i2c_dev->speed = STM32_I2C_SPEED_STANDARD; > + if (t->bus_freq_hz > I2C_MAX_FAST_MODE_PLUS_FREQ) { > + dev_err(i2c_dev->dev, "Invalid bus speed (%i>%i)\n", > + t->bus_freq_hz, I2C_MAX_FAST_MODE_PLUS_FREQ); > + return -EINVAL; > + } > > + setup->speed_freq = t->bus_freq_hz; > i2c_dev->setup.rise_time = t->scl_rise_ns; > i2c_dev->setup.fall_time = t->scl_fall_ns; > - > - setup->speed = i2c_dev->speed; > - setup->speed_freq = i2c_specs[setup->speed].rate; > setup->clock_src = clk_get_rate(i2c_dev->clk); > > if (!setup->clock_src) { > @@ -644,14 +648,12 @@ static int stm32f7_i2c_setup_timing(struct stm32f7_i2c_dev *i2c_dev, > if (ret) { > dev_err(i2c_dev->dev, > "failed to compute I2C timings.\n"); > - if (i2c_dev->speed > STM32_I2C_SPEED_STANDARD) { > - i2c_dev->speed--; > - setup->speed = i2c_dev->speed; > + if (setup->speed_freq > I2C_MAX_STANDARD_MODE_FREQ) { > setup->speed_freq = > - i2c_specs[setup->speed].rate; > + get_lower_rate(setup->speed_freq); > dev_warn(i2c_dev->dev, > "downgrade I2C Speed Freq to (%i)\n", > - i2c_specs[setup->speed].rate); > + setup->speed_freq); > } else { > break; > } > @@ -663,13 +665,15 @@ static int stm32f7_i2c_setup_timing(struct stm32f7_i2c_dev *i2c_dev, > return ret; > } > > - dev_dbg(i2c_dev->dev, "I2C Speed(%i), Freq(%i), Clk Source(%i)\n", > - setup->speed, setup->speed_freq, setup->clock_src); > + dev_dbg(i2c_dev->dev, "I2C Speed(%i), Clk Source(%i)\n", > + setup->speed_freq, setup->clock_src); > dev_dbg(i2c_dev->dev, "I2C Rise(%i) and Fall(%i) Time\n", > setup->rise_time, setup->fall_time); > dev_dbg(i2c_dev->dev, "I2C Analog Filter(%s), DNF(%i)\n", > (setup->analog_filter ? "On" : "Off"), setup->dnf); > > + i2c_dev->bus_rate = setup->speed_freq; > + > return 0; > } > > @@ -1866,7 +1870,7 @@ static int stm32f7_i2c_write_fm_plus_bits(struct stm32f7_i2c_dev *i2c_dev, > { > int ret; > > - if (i2c_dev->speed != STM32_I2C_SPEED_FAST_PLUS || > + if (i2c_dev->bus_rate <= I2C_MAX_FAST_MODE_FREQ || > IS_ERR_OR_NULL(i2c_dev->regmap)) > /* Optional */ > return 0; > @@ -2020,7 +2024,8 @@ static int stm32f7_i2c_probe(struct platform_device *pdev) > if (ret) > goto clk_free; > > - if (i2c_dev->speed == STM32_I2C_SPEED_FAST_PLUS) { > + /* Setup Fast mode plus if necessary */ > + if (i2c_dev->bus_rate > I2C_MAX_FAST_MODE_FREQ) { > ret = stm32f7_i2c_setup_fm_plus_bits(pdev, i2c_dev); > if (ret) > goto clk_free; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/2] i2c: i2c-stm32f7: allows for any bus frequency 2020-03-26 12:44 ` [PATCH v2 2/2] i2c: i2c-stm32f7: allows for any bus frequency Alain Volmat 2020-03-30 8:48 ` Pierre Yves MORDRET @ 2020-04-15 11:09 ` Wolfram Sang 2020-04-20 15:00 ` Alain Volmat 1 sibling, 1 reply; 7+ messages in thread From: Wolfram Sang @ 2020-04-15 11:09 UTC (permalink / raw) To: Alain Volmat Cc: mark.rutland, devicetree, alexandre.torgue, linux-kernel, pierre-yves.mordret, robh+dt, linux-i2c, mcoquelin.stm32, fabrice.gasnier, linux-stm32, linux-arm-kernel [-- Attachment #1.1: Type: text/plain, Size: 972 bytes --] Hi Alain, On Thu, Mar 26, 2020 at 01:44:21PM +0100, Alain Volmat wrote: > Do not limitate to the 3 (100KHz, 400KHz, 1MHz) bus frequency but > instead allows any frequency (if it matches timing requirements). > Depending on the requested frequency, use the spec data from either > Standard, Fast or Fast Plus mode. > > Hardcoding of min/max bus frequencies is removed and is instead computed. > > The driver do not use anymore speed identifier but instead handle > directly the frequency and figure out the spec data (necessary > for the computation of the timing register) based on the frequency. Useful improvement! > +static struct stm32f7_i2c_spec *get_specs(u32 rate) This is quite a generic namespace. Can we prefix stm32f7_<sth> here? > + if (rate <= i2c_specs[i].rate) > + return &i2c_specs[i]; Same for i2c_specs here? > +static u32 get_lower_rate(u32 rate) Here, too. Rest looks good to me. Regards, Wolfram [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/2] i2c: i2c-stm32f7: allows for any bus frequency 2020-04-15 11:09 ` Wolfram Sang @ 2020-04-20 15:00 ` Alain Volmat 0 siblings, 0 replies; 7+ messages in thread From: Alain Volmat @ 2020-04-20 15:00 UTC (permalink / raw) To: Wolfram Sang Cc: mark.rutland, devicetree, alexandre.torgue, linux-kernel, pierre-yves.mordret, robh+dt, linux-i2c, mcoquelin.stm32, fabrice.gasnier, linux-stm32, linux-arm-kernel Hi Wolfram, On Wed, Apr 15, 2020 at 01:09:16PM +0200, Wolfram Sang wrote: > Hi Alain, > > On Thu, Mar 26, 2020 at 01:44:21PM +0100, Alain Volmat wrote: > > Do not limitate to the 3 (100KHz, 400KHz, 1MHz) bus frequency but > > instead allows any frequency (if it matches timing requirements). > > Depending on the requested frequency, use the spec data from either > > Standard, Fast or Fast Plus mode. > > > > Hardcoding of min/max bus frequencies is removed and is instead computed. > > > > The driver do not use anymore speed identifier but instead handle > > directly the frequency and figure out the spec data (necessary > > for the computation of the timing register) based on the frequency. > > Useful improvement! > > > +static struct stm32f7_i2c_spec *get_specs(u32 rate) > > This is quite a generic namespace. Can we prefix stm32f7_<sth> here? Done in v3 > > > + if (rate <= i2c_specs[i].rate) > > + return &i2c_specs[i]; > > Same for i2c_specs here? Done in v3 > > > +static u32 get_lower_rate(u32 rate) > > Here, too. Done in v3 > > Rest looks good to me. > > Regards, > > Wolfram > Regards, Alain _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-04-20 15:00 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-03-26 12:44 [PATCH v2 0/2] i2c: i2c-stm32f7: allow range of I2C bus frequency Alain Volmat 2020-03-26 12:44 ` [PATCH v2 1/2] dt-bindings: i2c: i2c-stm32f7: allow clock-frequency range Alain Volmat 2020-04-04 17:18 ` Rob Herring 2020-03-26 12:44 ` [PATCH v2 2/2] i2c: i2c-stm32f7: allows for any bus frequency Alain Volmat 2020-03-30 8:48 ` Pierre Yves MORDRET 2020-04-15 11:09 ` Wolfram Sang 2020-04-20 15:00 ` Alain Volmat
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).