From: khilman@baylibre.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/7] ARM: OMAP2+: Improve omap_device error for driver writers
Date: Thu, 11 Feb 2016 17:13:23 -0800 [thread overview]
Message-ID: <7hfuwy6898.fsf@baylibre.com> (raw)
In-Reply-To: <1455145370-20301-7-git-send-email-tony@atomide.com> (Tony Lindgren's message of "Wed, 10 Feb 2016 15:02:49 -0800")
Tony Lindgren <tony@atomide.com> writes:
> Drivers using pm_runtime_use_autosuspend() may not get disabled after
> -EPROBE_DEFER. On the following device driver probe, hardware state
> is different from the PM runtime state causing omap_device to produce
> the following error:
>
> omap_device_enable() called from invalid state 1
>
> And with omap_device and omap hardware being picky for PM, this will
> block any deeper idle states in hardware.
>
> Let's add a proper error message so driver writers can easily fix
> their drivers for PM.
>
> In general, the solution is to fix the drivers to follow the PM
> runtime documentation:
>
> 1. For sections of code that needs the device disabled, use
> pm_runtime_put_sync_suspend() if pm_runtime_set_autosuspend() has
> been set.
>
> 2. For driver exit code, use pm_runtime_dont_use_autosuspend() before
> pm_runtime_put_sync() if pm_runtime_use_autosuspend() has been
> set.
>
> Let's not return with 0 from _od_runtime_resume() as that will
> eventually lead into new drivers with broken PM runtime that will
> block deeper idle states on omaps.
>
> Cc: Alan Stern <stern@rowland.harvard.edu>
> Cc: Kevin Hilman <khilman@baylibre.com>
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Rafael J. Wysocki <rafael@kernel.org>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Tero Kristo <t-kristo@ti.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Acked-by: Kevin Hilman <khilman@baylibre.com>
> ---
> arch/arm/mach-omap2/omap_device.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/omap_device.c b/arch/arm/mach-omap2/omap_device.c
> index 0437537..ebd8369 100644
> --- a/arch/arm/mach-omap2/omap_device.c
> +++ b/arch/arm/mach-omap2/omap_device.c
> @@ -602,8 +602,10 @@ static int _od_runtime_resume(struct device *dev)
> int ret;
>
> ret = omap_device_enable(pdev);
> - if (ret)
> + if (ret) {
> + dev_err(dev, "use pm_runtime_put_sync_suspend() in driver?\n");
> return ret;
> + }
>
> return pm_generic_runtime_resume(dev);
> }
next prev parent reply other threads:[~2016-02-12 1:13 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 23:02 [PATCH 0/7] PM runtime regression fixes for omaps Tony Lindgren
2016-02-10 23:02 ` [PATCH 1/7] mmc: omap_hsmmc: Fix PM regression with deferred probe for pm_runtime_reinit Tony Lindgren
2016-02-11 10:18 ` Ulf Hansson
2016-02-11 15:02 ` Tony Lindgren
2016-02-11 15:13 ` Ulf Hansson
2016-02-11 17:26 ` Tony Lindgren
2016-02-12 12:59 ` Ulf Hansson
2016-02-22 17:54 ` Tony Lindgren
2016-02-10 23:02 ` [PATCH 2/7] i2c: omap: " Tony Lindgren
2016-02-11 17:34 ` Wolfram Sang
2016-02-11 17:56 ` Tony Lindgren
2016-02-12 12:50 ` Ulf Hansson
2016-02-12 18:43 ` Wolfram Sang
2016-02-10 23:02 ` [PATCH 3/7] spi: omap2-mcspi: " Tony Lindgren
2016-02-11 11:51 ` Mark Brown
2016-02-11 15:08 ` Tony Lindgren
2016-02-11 15:52 ` Mark Brown
2016-02-11 17:36 ` Tony Lindgren
2016-02-11 18:36 ` Mark Brown
2016-02-11 18:52 ` Tony Lindgren
2016-02-12 12:51 ` Ulf Hansson
2016-02-10 23:02 ` [PATCH 4/7] serial: 8250_omap: " Tony Lindgren
2016-02-12 3:17 ` Greg Kroah-Hartman
2016-02-12 12:52 ` Ulf Hansson
2016-02-10 23:02 ` [PATCH 5/7] serial: omap: " Tony Lindgren
2016-02-12 12:52 ` Ulf Hansson
2016-02-10 23:02 ` [PATCH 6/7] ARM: OMAP2+: Improve omap_device error for driver writers Tony Lindgren
2016-02-12 1:13 ` Kevin Hilman [this message]
2016-02-12 12:53 ` Ulf Hansson
2016-02-10 23:02 ` [PATCH 7/7] ARM: OMAP2+: Fix omap_device for module reload on PM runtime forbid Tony Lindgren
2016-02-12 1:13 ` Kevin Hilman
2016-02-12 12:54 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hfuwy6898.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).