From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A075C433DF for ; Wed, 14 Oct 2020 14:58:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C22B222201 for ; Wed, 14 Oct 2020 14:58:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dMoxoU45" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C22B222201 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=30FA6KfY94QhZ5USIymArEOeLZge8kCbo0kqUoyRsrg=; b=dMoxoU45p/GuSjBdzsa9o8gqr RYF/hAXw0ao38/S6ZnOucJ8ruZiXkp82kbib8JzuJFt3ck/bcA0TXEu8jd1ITuy+fYZjDTahuWAUT rolSN8TUDYPkUm1BD2eM4oexwg0LL+Ujnc1AD4LQFp9vJCTP3N8QBE8s/2MobUu94gOM9kkralw8A mQCVfMzEF80AtYoFWs6UIhgd+uzGIW6c8swlJEDD/HPldr5WebMxDMkCp0mA/Lwg6VQ/hCXw0xRu1 FcV+UAwHpnIdWqv9JaJmnHPXOedKpGB3OuUEZpscXS94EKx1OXMKoWzKDqTUHVWCmIbW8KXnDmqEi jVb26WtIg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSiCm-0007PI-Kx; Wed, 14 Oct 2020 14:56:40 +0000 Received: from mail-out.m-online.net ([212.18.0.9]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSiBs-00070S-Vw for linux-arm-kernel@lists.infradead.org; Wed, 14 Oct 2020 14:55:46 +0000 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4CBFpR4ZjJz1qrfk; Wed, 14 Oct 2020 16:55:43 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4CBFpR3sgnz1qvgT; Wed, 14 Oct 2020 16:55:43 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id nqtM0Yd0cBB1; Wed, 14 Oct 2020 16:55:42 +0200 (CEST) X-Auth-Info: tNwAkfRU7WawolCE2fYNKgNvSG5C5MJ2HDuLlThs3FA= Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 14 Oct 2020 16:55:42 +0200 (CEST) Subject: Re: [Linux-stm32] [PATCH] ARM: dts: stm32: Consistently enable internal pull-ups for SD bus To: Yann GAUTIER , "linux-arm-kernel@lists.infradead.org" References: <20201009210820.243659-1-marex@denx.de> <99663cc5-f897-8233-518b-1a485a2e15b6@st.com> From: Marek Vasut Message-ID: <808c1e29-a96f-f3f4-7e5d-7ba2dfed4142@denx.de> Date: Wed, 14 Oct 2020 16:55:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <99663cc5-f897-8233-518b-1a485a2e15b6@st.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201014_105545_212412_36EFC380 X-CRM114-Status: GOOD ( 16.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre TORGUE , "a.fatoum@pengutronix.de" , Maxime Coquelin , Patrick DELAUNAY , "linux-stm32@st-md-mailman.stormreply.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/14/20 4:52 PM, Yann GAUTIER wrote: > > > On 10/14/20 3:30 PM, Marek Vasut wrote: >> On 10/14/20 3:26 PM, Yann GAUTIER wrote: >> [...] >>>> diff --git a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi >>>> index b2d19583450c..73d9a5b7f5ba 100644 >>>> --- a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi >>>> +++ b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi >>>> @@ -1291,13 +1291,13 @@ pins1 { >>>> ; /* SDMMC1_CMD */ >>>> slew-rate = <1>; >>>> drive-push-pull; >>>> - bias-disable; >>>> + bias-pull-up; >>> Hi Marek, >> >> Hi, >> >>> This pin config is used by ST board, where we have a level shifter. >>> This shouldn't be changed. We discussed this with Alex, and a new group >>> should be added in this case. >> >> Is it a problem if we enable the pulls up unconditionally with the level >> shifter present, to make the properties of the SD bus consistent ? >> > The risk of having 2 parallel pull-ups is that the resulting value could > be below the lower acceptable value for SD. I'll check if that can occur. That's a good idea, thank you! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel