From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1384AC43334 for ; Fri, 10 Jun 2022 10:00:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hfxIwPc2R7WEkNFq1sJy+wJZIBHO1KfhLU6O7c9dCQU=; b=3P3vyPT0DPN4lV RVBkm0A+lD+mLQpZGpxPfAZhTBRbw3gRtcf4T2dOHI2bmF4mWRl6lhce5TsSr/19OscwUUlibXLwS Eyjj/g4hKmyHg9zdHbGpx4qoRfs5mUTrief6mdvZKlMazm0gzRh3B7IG662Y3xj/NO7ycB7JDPQLU k5n7pQKKPCnYp2s+YlU4niFbdlcoVY2/4/MvUK7aWJqer6nDm2JsGcEJhAtbUVhhK5xwl89i7vL8Z /+egj7iiLWDo53DUvhDgcCaELXnEYy6RiQaMcrJVVtE0ffwoizUD8Ee2liFvIn0xnQWW8JcYRrPf0 6YrPBjHLuCj2nFGBBJIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzbPP-007Ovc-CX; Fri, 10 Jun 2022 09:58:28 +0000 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzbIv-007LoM-Fk for linux-arm-kernel@lists.infradead.org; Fri, 10 Jun 2022 09:51:47 +0000 Received: by mail-ed1-x52f.google.com with SMTP id c2so34516792edf.5 for ; Fri, 10 Jun 2022 02:51:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Su/vdY6lGj+Pr3dmdikt3VdGnrhvMFnJcFP72Ow7dC4=; b=zgRwcmTAgD0viyAxwBer3iPOUi0MEbyLAPXlWR/pLQzcQhksejfo8DVt5Rp8mk8mkA mWFDWHE1c6WTvhN81Xke8gzP9TCiZyoJPZc+rwPr0H1yzVpPx88rLkPWHn8jRAqgvvuE 2d17ZSiKC1ioFftJYlL+dL7TfeEfjY7PLCSdMuuSKxvSxPXAn/kYPRlfOmktVPXgNAu2 InKcNJ9OgyscXNdxac+SDgTm8uQeGyJrdF5GqYQjWSjXhy8TMAkCriZwItIKBlMNuGm0 Spjfvoscvy/uBhozkRybtDbBFL2Ws+ZfSlvv7KB3+OOOeTCh6eC4W85byY1xuRUIASIC TkDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Su/vdY6lGj+Pr3dmdikt3VdGnrhvMFnJcFP72Ow7dC4=; b=I2KmXoyelgpYknzS2HLsSwzXmaRoNwlY4C51fFvXviioov70LCnixsO4SqLoNd8nVN JpD40TAHhc/snRrUKuSP61RYXIWPnd9YZcijuZuczQTFbz5Dt7j3KjUtymMy0vvxMis4 hb2c8Q6fS06zpGSU8pmzn+dD3JCTyTHR7gkvUe0IOS335w9SKyzB/hz91eT1ITMoM8yA mI3LR5K82I/vkTbo1NfQ1+ewnkzJ0vctFKfFHit4R+XLwu0MG7AiWlyyY9Cy9vzSFlze QUE5cA/NacuwlvienueCz0c+Ug+UGR/cKIfGtdS7oFwx9lR7YW4INYF6ylf5jMKLo5pU +NUA== X-Gm-Message-State: AOAM531reP7g8EQmC9SjEF0yP9aDmXE0IYDAzXlZt4UXXeBkZvnIH4uW XlR8UaBtGTw0vnDRmsrUTD4h8uwKu5ymAA== X-Google-Smtp-Source: ABdhPJyj6TklRqD3zDYQVccZ7hzIqwXHNLa/IvjlZmFFmrZBmG/TM9HKYw08cXo1RRXjvutTxqKtgA== X-Received: by 2002:a05:6402:1907:b0:42d:e90e:337 with SMTP id e7-20020a056402190700b0042de90e0337mr51038751edz.405.1654854701058; Fri, 10 Jun 2022 02:51:41 -0700 (PDT) Received: from [192.168.0.201] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id de46-20020a1709069bee00b0070f6855b90bsm9492759ejc.170.2022.06.10.02.51.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jun 2022 02:51:40 -0700 (PDT) Message-ID: <80f9c2d5-52d9-b03d-c272-ac475ae8c69e@linaro.org> Date: Fri, 10 Jun 2022 11:51:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2 10/20] ARM: dts: nuvoton: add reset syscon property Content-Language: en-US To: Tomer Maimon Cc: Avi Fishman , Tali Perry , Joel Stanley , Patrick Venture , Nancy Yuen , Benjamin Fair , Rob Herring , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , Philipp Zabel , Greg KH , Daniel Lezcano , Thomas Gleixner , Wim Van Sebroeck , Guenter Roeck , Catalin Marinas , Will Deacon , Arnd Bergmann , Olof Johansson , Jiri Slaby , Shawn Guo , Bjorn Andersson , Geert Uytterhoeven , Marcel Ziswiler , Vinod Koul , Biju Das , Nobuhiro Iwamatsu , Robert Hancock , =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= , Lubomir Rintel , devicetree , Linux Kernel Mailing List , linux-clk , "open list:SERIAL DRIVERS" , LINUXWATCHDOG , Linux ARM References: <20220608095623.22327-1-tmaimon77@gmail.com> <20220608095623.22327-11-tmaimon77@gmail.com> <3aa70c91-d6d7-e2eb-9c45-a1fb0a5751ca@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220610_025145_586159_28E58C04 X-CRM114-Status: GOOD ( 17.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/06/2022 23:30, Tomer Maimon wrote: > Hi Krzysztof, > > Thanks for your comments > > On Wed, 8 Jun 2022 at 13:07, Krzysztof Kozlowski > wrote: >> >> On 08/06/2022 11:56, Tomer Maimon wrote: >>> Add nuvoton,sysgcr syscon property to the reset >>> node to handle the general control registers. >> >> Wrong wrapping. > it will be very helpful if you could point me what wrong wrapped in > the commit message, is it the explanation or the header? or something > else? I pointed you last time. I pointed the exact line, exact rule you need to follow. I pointed it three times already and three times I said wrapping is wrong: https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 "The body of the explanation, line wrapped at 75 columns, which will be copied to the permanent changelog to describe this patch." Your wrapping is not at 75 columns and it causes the commit to be less readable, without any reason. Please follow Linux kernel coding style/rules. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel