From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27906C433B4 for ; Mon, 17 May 2021 08:37:15 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5AC56100A for ; Mon, 17 May 2021 08:37:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5AC56100A Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YYieCLSMGs16JTk4rAbOtOvLz5hVd9/ggIaJnf6vIXc=; b=SG1JnAJ5GsRNLu0LwYtvVScuz bmHxbsKa4ONJjN4lsp+AVvhRP16R+TgKvSC3s9kcNzLHTHDRNK/71s0C1BieLPyaFb3JvIQuMiAcF N/SJbk95nIMI8AvsLYdf9nNhkYEs6ep4nNyFybGJRmxFG4n9qjeSQBNLr+b6RDXpxNZVYLQl/4ndO e/+Ev6+VcpvXwK2ihAgbQ8VyznWDhZZzTNhgA2lu2pbbt5KmMjTZeOlycOJbvmTihm8F2hPpzHzoN lRI72ABgy71sbPpR6sbavfrhVKIGvGYcS/4hgVkb5IBdcReliNYFY0AI1UwRzvsU7IMkEGLkAfoI/ J/wwJsMOQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1liYiY-00EGZo-GB; Mon, 17 May 2021 08:35:14 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1liYeV-00EFet-5y for linux-arm-kernel@desiato.infradead.org; Mon, 17 May 2021 08:31:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:CC:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=5+GQXpK8pVkLU17QoqgTrmAgiNWs/zpijoNBJuK5Now=; b=K1k4V4lUZdKM9VZBQpdNDyD1sy PUDuYuXUxNLfKNX9foVBrPMKZ2kkQ6UQOSjFCBci5E/StD2qZ8w2KO/y5Hb8ihxXw29lGsoFkHrPn zI3XtUNiEtCDjMEIWaGMH9vij6wxZ1Ny0RaAWaS+J49OMFhmHVTm9vW4NIwoOmBgDSjcgOlrKYp/Q q2vGrfTZw/yZxwbOj7cGmoaBk3AarapJkh1/eUMtbWB74EP8HvUsU4dUILsOHcwjlT5K1PBax+ktb gsFX1WHkaLZwGkhVp79JWNbydbtVGjiEvOSFLHDUe5sCMjAYaOBCCNvraoGG2jQbZIsfPbntLnbyG XMG3hH7A==; Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1liYeQ-00DbBk-8j for linux-arm-kernel@lists.infradead.org; Mon, 17 May 2021 08:31:01 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 14H8UukX001313; Mon, 17 May 2021 03:30:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1621240256; bh=5+GQXpK8pVkLU17QoqgTrmAgiNWs/zpijoNBJuK5Now=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=L0hBS7HT3nisWCzsrk816R8uPjpayQoFk3lP+fkvDl5wzzH5XZ8VvlvTtBwJuD/Et FLtfGL//iZ+PK/BFrjO3cJ7PRyNMDh7tK822XPQTjuPcliXdbED5slyTF49T835HSF TA2vrJlAoInGTwmzIhSGbUE5NjJoU5LJI4bXKvvA= Received: from DLEE100.ent.ti.com (dlee100.ent.ti.com [157.170.170.30]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 14H8Uu0J056190 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 17 May 2021 03:30:56 -0500 Received: from DLEE111.ent.ti.com (157.170.170.22) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 17 May 2021 03:30:56 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE111.ent.ti.com (157.170.170.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Mon, 17 May 2021 03:30:56 -0500 Received: from [10.250.232.247] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 14H8Uq8p086445; Mon, 17 May 2021 03:30:53 -0500 Subject: Re: [PATCH 1/4] arm64: dts: ti: k3-j721e-main: Fix external refclk input to SERDES To: Nishanth Menon CC: Tero Kristo , Rob Herring , , , , Lokesh Vutla References: <20210512151209.27560-1-kishon@ti.com> <20210512151209.27560-2-kishon@ti.com> <20210512185157.q5sr2xqf3w5igfte@imagines> <68c95cf1-84fa-2194-7bb1-e3c60e7f1fc0@ti.com> <20210513140137.5uvftgtsku3xfobz@engraving> From: Kishon Vijay Abraham I Message-ID: <81b7dc76-0918-0a95-5715-cf701e638bbe@ti.com> Date: Mon, 17 May 2021 14:00:51 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210513140137.5uvftgtsku3xfobz@engraving> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210517_013058_424535_BEFB947E X-CRM114-Status: GOOD ( 16.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Nishanth, On 13/05/21 7:31 pm, Nishanth Menon wrote: > On 17:41-20210513, Kishon Vijay Abraham I wrote: >> Hi Nishanth, >> >> On 13/05/21 12:21 am, Nishanth Menon wrote: >>> On 20:42-20210512, Kishon Vijay Abraham I wrote: >>>> Rename the external refclk inputs to the SERDES from >>>> dummy_cmn_refclk/dummy_cmn_refclk1 to cmn_refclk/cmn_refclk1 >>>> respectively. Also move the external refclk DT nodes outside the >>>> cbass_main DT node. Since in j721e common processor board, only the >>>> cmn_refclk1 is connected to 100MHz clock, fix the clock frequency. >>>> >>>> Fixes: afd094ebe69f ("arm64: dts: ti: k3-j721e-main: Add WIZ and SERDES PHY nodes") >>> >>> Assume we want this part of 5.13 fixes? >> >> This doesn't fix any functionality. Okay for me to go in 5.14 along with >> the rest of the series. > > >>> >>>> Signed-off-by: Kishon Vijay Abraham I >>>> --- >>>> .../dts/ti/k3-j721e-common-proc-board.dts | 4 ++ >>>> arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 58 ++++++++++--------- >>>> 2 files changed, 34 insertions(+), 28 deletions(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts >>>> index 60764366e22b..86f7ab511ee8 100644 >>>> --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts >>>> +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts >>>> @@ -635,6 +635,10 @@ >>>> status = "disabled"; >>>> }; >>>> >>>> +&cmn_refclk1 { >>>> + clock-frequency = <100000000>; >>>> +}; >>>> + >>>> &serdes0 { >>>> serdes0_pcie_link: link@0 { >>>> reg = <0>; >>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi >>>> index c2aa45a3ac79..002a0c1520ee 100644 >>>> --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi >>>> +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi >>>> @@ -8,6 +8,20 @@ >>>> #include >>>> #include >>>> >>>> +/ { >>>> + cmn_refclk: cmn-refclk { >>>> + #clock-cells = <0>; >>>> + compatible = "fixed-clock"; >>>> + clock-frequency = <0>; >>>> + }; >>>> + >>>> + cmn_refclk1: cmn-refclk1 { >>> >>> Just curious: why cant we use the standard nodenames with clock? >> >> We can use standard names here. Is there any defined nodename for >> clocks? clk or clock? Don't see $nodename defined for clocks in >> dt-schema repository. > > Looking at the fixed-clock example, lets go with clock Since I have two clocks here adding clock@0 and clock@1 introduces the following error. /home/a0393678/repos/linux-wip/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml: /: clock@0: 'anyOf' conditional failed, one must be fixed: 'reg' is a required property 'ranges' is a required property The current "fixed-clock" binding doesn't allow adding "reg" property. We'll stick to non standard names? or do you think the binding has to be fixed? Thanks Kishon _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel