From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9B63C433ED for ; Tue, 11 May 2021 13:19:19 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7ADAC613DE for ; Tue, 11 May 2021 13:19:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7ADAC613DE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dHaSgWNWQv7SuBlLvjL7J8Mym040Gv2TM5ZvO3v1pFI=; b=hNuYrSZPdjJ1YD0KRok4bBIWF frTpd/Aji4PtlbWwMG3tUgRKICkq9jmJMKD2QlJshrd0E3I+tbzK2RNs3hAX+kIRP9IdDkOvgRn9D dDjXfKZvPlnShZj+2RFmzgaDaSmPxEyiNbySMeBK0KGODIOsCoEjSHEwrQXod9IrcVILvzrqZ6qz6 uoeDeik+P9wz537t+oHmsZ5kI5C5pdwqoM3nni3taxLtnuuwNIGflg0m6ixc9ZNN6sIVZ5Yv05BK6 4hkmE7dKtn389fsfEbwxRE5qYyR/IFWhypfoJFfRbaZvlheMRC3vlPNT37P9+sJ10ysAaHGmUFzTo cqAMBRDOQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgSGW-0002ad-9d; Tue, 11 May 2021 13:17:36 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgRBQ-00HITA-Ev for linux-arm-kernel@desiato.infradead.org; Tue, 11 May 2021 12:08:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Message-ID:References:In-Reply-To: Subject:Cc:To:From:Date:Content-Transfer-Encoding:Content-Type:MIME-Version: Sender:Reply-To:Content-ID:Content-Description; bh=tfzFTZQrMHou0w2FqN3CD+KngZ6YJ+lXzOpQ6e0wKgM=; b=OAGsFGsOEgOEAdKFKOwJ68ToEz fjH6sEsVAbvU+0wufYlki99VaGsmR0Zm7SNHvKp0Iyn6WvUWvf1A0SXqkdwkexoNg3sYHBeTCBv/g 7Ft3j2WmOa5j1mRe8SYRTHt+hLbkdtH9co8sBSfhRoPHvqq9vtXKYxh6s8gucyWHFn42RNH9JLJfb CVIqh1xcEfUbKE8ayA/R97mcEpKN3uH8RPkmGy6xcNo3IikPjXD1wLsQez8WEVLaLPhOtfecLH2cI WOSYih/xezKFmJJ3v6MVNXvwCN82lt3yp7w12aqPMXbm1xSIJ5plOVWoFpCCEOTtpGIUHH33gvVov AGa3/zig==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgRBN-009YFi-Rc for linux-arm-kernel@lists.infradead.org; Tue, 11 May 2021 12:08:15 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 43A2C615FF; Tue, 11 May 2021 12:08:13 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1lgRBL-000fkU-4q; Tue, 11 May 2021 13:08:11 +0100 MIME-Version: 1.0 Date: Tue, 11 May 2021 13:08:11 +0100 From: Marc Zyngier To: Zhen Lei Cc: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Thomas Gleixner , linux-arm-kernel Subject: Re: [PATCH 1/1] irqchip/irq-mvebu-icu: Remove redundant error printing in mvebu_icu_probe() In-Reply-To: <20210511120107.5781-1-thunder.leizhen@huawei.com> References: <20210511120107.5781-1-thunder.leizhen@huawei.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <8244b6349a60783f8d0cb7edd12a0292@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: thunder.leizhen@huawei.com, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_050813_957341_98CE4416 X-CRM114-Status: GOOD ( 12.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Zhen, On 2021-05-11 13:01, Zhen Lei wrote: > When devm_ioremap_resource() fails, a clear enough error message will > be > printed by its subfunction __devm_ioremap_resource(). The error > information contains the device name, failure cause, and possibly > resource > information. > > Therefore, remove the error printing here to simplify code and reduce > the > binary size. > > Reported-by: Hulk Robot > Signed-off-by: Zhen Lei I'm all grateful for these changes, but can you please organise them in a series and send all the irqchip-related changes at once, instead of one patch every two hours? Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel