From: Joe Perches <joe@perches.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Felipe Balbi <balbi@kernel.org>,
Vladimir Zapolskiy <vz@mleia.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, James Grant <james.grant@jci.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Sylvain Lemieux <slemieux.tyco@gmail.com>
Subject: Re: [PATCH] usb: gadget: udc: lpc32xx: allocate descriptor with GFP_ATOMIC
Date: Fri, 10 May 2019 08:59:51 -0700 [thread overview]
Message-ID: <82974f50ad02342abd59b800a802f7adecabc0b9.camel@perches.com> (raw)
In-Reply-To: <20190510124248.2430-1-alexandre.belloni@bootlin.com>
On Fri, 2019-05-10 at 14:42 +0200, Alexandre Belloni wrote:
> Gadget drivers may queue request in interrupt context. This would lead to
> a descriptor allocation in that context. In that case we would hit
> BUG_ON(in_interrupt()) in __get_vm_area_node.
[]
> diff --git a/drivers/usb/gadget/udc/lpc32xx_udc.c b/drivers/usb/gadget/udc/lpc32xx_udc.c
[]
> @@ -938,7 +938,7 @@ static struct lpc32xx_usbd_dd_gad *udc_dd_alloc(struct lpc32xx_udc *udc)
> struct lpc32xx_usbd_dd_gad *dd;
>
> dd = (struct lpc32xx_usbd_dd_gad *) dma_pool_alloc(
> - udc->dd_cache, (GFP_KERNEL | GFP_DMA), &dma);
> + udc->dd_cache, (GFP_ATOMIC | GFP_DMA), &dma);
trivia:
This could fit nicely on a single line without the
unnecessary cast and the unnecessary parentheses
around the GFP_ types.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-10 16:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 12:42 [PATCH] usb: gadget: udc: lpc32xx: allocate descriptor with GFP_ATOMIC Alexandre Belloni
2019-05-10 15:59 ` Joe Perches [this message]
2019-05-13 11:33 ` James Grant
2019-06-18 7:33 ` Felipe Balbi
2019-06-18 7:46 ` Alexandre Belloni
2019-06-18 8:45 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82974f50ad02342abd59b800a802f7adecabc0b9.camel@perches.com \
--to=joe@perches.com \
--cc=alexandre.belloni@bootlin.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=james.grant@jci.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=slemieux.tyco@gmail.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).