From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9998C19F28 for ; Wed, 3 Aug 2022 14:17:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/KzUh6xdtyMemXUGypssYdemUKh9DYVTcCSOLIeE9mw=; b=ywryN/euDZiBhs BZOD+Qp0MaY6Dden98j6nFYlrWfSsNJN76kiAlF7QvFbi4IRywEs71KsXWOQRlhDhjXrQOyFOD/QU ZsyRBodI7qInanijRX8oPvk/4dhQbfoc3BjvBo6U//VQTYyN9HFKvB9wmFrNuLea0kCxY9mSssGS9 i368oe43ui5gr65lZOl0JUl44WSbn+LreVYi0/6g0I0gxhFO8Dmv2rRzfLfbtlFxLxi7MwtTdTsoA FNWwXZBBtHoSiqyBqrycsJXgEkq4e3rYX31/Wdn+rdsfQB67YaGJSP4uerrl9ZB7AUWum562LiQd2 KFfZu5c0ROW4Fl4SHAkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJFAg-006fBt-48; Wed, 03 Aug 2022 14:16:26 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJFAb-006f8w-Kk for linux-arm-kernel@lists.infradead.org; Wed, 03 Aug 2022 14:16:23 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8DBD211FB; Wed, 3 Aug 2022 07:16:18 -0700 (PDT) Received: from [10.57.12.36] (unknown [10.57.12.36]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3D6933F70D; Wed, 3 Aug 2022 07:16:16 -0700 (PDT) Message-ID: <846c663a-5999-977b-8a69-89c8ca522cea@arm.com> Date: Wed, 3 Aug 2022 15:16:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [RFC PATCH 0/2] add support for CDX bus MSI domain Content-Language: en-GB To: Nipun Gupta , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org, rafael@kernel.org, maz@kernel.org, tglx@linutronix.de Cc: okaya@kernel.org, harpreet.anand@amd.com, michal.simek@amd.com, nikhil.agarwal@amd.com References: <20220803122655.100254-1-nipun.gupta@amd.com> From: Robin Murphy In-Reply-To: <20220803122655.100254-1-nipun.gupta@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220803_071621_801340_3071339A X-CRM114-Status: GOOD ( 14.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-08-03 13:26, Nipun Gupta wrote: > Devices in FPGA can be added/modified dynamically on run-time. > These devices are exposed on system bus to embedded CPUs. > > CDX is an upcoming bus, that caters to the requirement for > dynamically discovered FPGA devices. These devices are added > as platform devices where fwnode is created using 'software > nodes' in Linux framework. > > This RFC targets to solves 2 issues when adding devices > dynamically using platform_device_register API. > > 1. It creates a MSI domain for CDX bus devices, which can > discover device ID used by GIC ITS without depending > on of_node. > 2. Since these devices are not present in device tree, it > creates a sysfs entry to expose the compatible string. Isn't this pretty much what CONFIG_OF_DYNAMIC is for? From the look of these patches this thing is still completely tied to devicetree, so why reinvent that wheel? Robin. > Nipun Gupta (2): > irqchip: cdx-bus: add cdx-MSI domain with gic-its domain as parent > driver core: add compatible string in sysfs for platform devices > > drivers/base/platform.c | 15 +++ > drivers/irqchip/Makefile | 1 + > drivers/irqchip/irq-gic-v3-its-cdx-msi.c | 114 +++++++++++++++++++++++ > include/linux/cdx/cdx.h | 15 +++ > 4 files changed, 145 insertions(+) > create mode 100644 drivers/irqchip/irq-gic-v3-its-cdx-msi.c > create mode 100644 include/linux/cdx/cdx.h > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel