Re: [PATCH 2/7] arm64: dts: ti: k3-j721e-common-proc-board: Add mailboxes to C66x DSPs

From: Suman Anna <s-anna@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: Tero Kristo <t-kristo@ti.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/7] arm64: dts: ti: k3-j721e-common-proc-board: Add mailboxes to C66x DSPs
Date: Thu, 20 Aug 2020 08:25:12 -0500	[thread overview]
Message-ID: <8491a1bf-3665-8f23-6b75-34890566fcae@ti.com> (raw)
In-Reply-To: <20200820114238.7ovvxq5n3fogzowi@akan>

Hi Nishanth,

On 8/20/20 6:42 AM, Nishanth Menon wrote:
> On 20:03-20200819, Suman Anna wrote:
>> Add the required 'mboxes' property to both the C66x DSP processors on the
>> TI J721E common processor board. The mailboxes and some shared memory
> 
> I am not sure I understand the logic here. The carveout is added to
> p0 SOM - and the mbox is added to common_proc_board. I am not sure I
> get the difference. The C66x processors are on the SoC, stack is as
> follows: - SoC - SoM - Common Proc board
> 
> I am just wondering if the carveouts and mbox linkage should be in the
> common processor board? if that makes sense at all? I know we already
> have other definitions.. Trying to see if we are making it harder to
> understand the definition than that is necessary..

In general, I consider these as stuff that needs to be added to the board dts
files. You will see that this is what I have followed on all the TI
AM57xx/DRA7xx boards. For J721E, we have a weird organization as the memory
node, typically a board property, is defined in the som dtsi file, so the
reserved memory nodes are also added in the som dtsi file. The convention I
followed in general is to have the reserved-memory and memory nodes together.

If you think the mailbox nodes should be moved into the SoM dts file, I could do
it as a follow-on cleanup series, but would wait for the ABI 3.0 changes to be
merged first.

regards
Suman

> 
>> are required for running the Remote Processor Messaging (RPMsg) stack
>> between the host processor and each of the R5Fs. The chosen sub-mailboxes
>> match the values used in the current firmware images. This can be changed,
>> if needed, as per the system integration needs after making appropriate
>> changes on the firmware side as well.
>>
>> Signed-off-by: Suman Anna <s-anna@ti.com>
>> ---
>>  arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
>> index e8fc01d97ada..ff541dc09eca 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
>> @@ -379,6 +379,14 @@ &mailbox0_cluster11 {
>>  	status = "disabled";
>>  };
>>  
>> +&c66_0 {
>> +	mboxes = <&mailbox0_cluster3 &mbox_c66_0>;
>> +};
>> +
>> +&c66_1 {
>> +	mboxes = <&mailbox0_cluster3 &mbox_c66_1>;
>> +};
>> +
>>  &main_sdhci0 {
>>  	/* eMMC */
>>  	non-removable;
>> -- 
>> 2.28.0
>>
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel