From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2EC4C4332F for ; Wed, 9 Nov 2022 09:20:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tBfGTxK+wixsGi/pW2Vy7i0hKq59i9q/8XTzajrIJYg=; b=NX8tUflFCCbA4m YEuQ+Dlsx+0SGy5vUNjRwX8B+0hUeMpGMYjdfTVw5jzwr03VZhqRwQcEcFaEmPd72IQUG/YhHc4oT RO0J35PF2kmR56mIltxnkYBBBlVWWdtFrWmLMKXlJc6ySVye1MbxCq8/A5eikpvd716KuhkVCEjIq ha0k0UamzhTydYRHcEavpaEj4GNPSfXinFoHuiciYK0YNjzz/mWwc4dL1hY3F4GdOdJP0CpZJmUlQ xbQZeC8o657nXb6cT8F1SMgyDoQ2sZ0mOdGWVLxVLP5CaqJ6BC2xgIAYAj2181V4gRDFlcCuO/C1f xuIRlXteXeHxhgQxA+Pw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oshFJ-00CF2j-QA; Wed, 09 Nov 2022 09:19:45 +0000 Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oshFG-00CExP-5q for linux-arm-kernel@lists.infradead.org; Wed, 09 Nov 2022 09:19:43 +0000 Received: by mail-lj1-x22b.google.com with SMTP id z24so24815591ljn.4 for ; Wed, 09 Nov 2022 01:19:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VyOwHIx2eFYER6svy54TwgyRrhxCzE5HFZfbjyKkFTY=; b=D76zlyzf8ZHfHyT+XBBZb6eqdJWPJL2LUpXnJWdG4HrxIKHrGV+vMC4KLANVtRU7Q8 GvkKLbNz+v0geOE6AfhzelWvsNe0leMER1eq36PMH1eKUMAavWhFxVe+yR08oYHvGwy4 HCLznAFy6/Xx6e95ZufqZq4lTH9GTHiXD0d+gmQ3nBllkBzqNf7DUWrHy/Fx6WQ2jlrA 34T4SbQvDOfuYJiIypUaGXkXPk5w4MZWij3G+o8tk8CuW6Wkopj3laQPfvYKOisvoc+y 4sKLPng89ZCITyS+GJFVq0s1kDXG+afP98vA6Ymtfzbv3mhGOAH1CLFisdw9j96fnteT 2DbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VyOwHIx2eFYER6svy54TwgyRrhxCzE5HFZfbjyKkFTY=; b=PlawLld/j8jS7K3+5Nqll5FcGOMHco0rr0hAR13Pd4eargnvLxWDRnXOwXrV5AmBVG vIbcceUfQhf5Ige67xWHj1D333OfXS3zIKXtp0JRzOHwLz8j15EoachLI417knDCb9qt ikSXsqodBqsS6W8uDkIe9ZUltQ1Za0zEfrV/SWh2w7Vw9vSXne7wbb0Vto1jVKbgeEYy lrLxtsvZSYpAVbTE5BPVU8XP9CkSwo233SEu6oWb9KtbEj9F/AntvUyuBmU7Z7g0Paxo Q36s3M3h0Q7ctcDAjK9HVK/XvWa7Rn9KojbADNtngtE/GcpXWcef576QwIBh+ZM9iVZC tJ3w== X-Gm-Message-State: ACrzQf19N08Ut7n+9AD0X+9Bi4956u/DjRvuMm762OJMLTNRYmTHbBlj v5MDgu2FvWsGvUvBwW27B8mj+g== X-Google-Smtp-Source: AMsMyM7uEpQrCQmOl2lKJhvkvbR44SkmDPc+he6Vt7mjd6PxA45ieuuzM/uNpq1Vl1tAhGRH1XAHnw== X-Received: by 2002:a2e:80da:0:b0:277:34b:1bfe with SMTP id r26-20020a2e80da000000b00277034b1bfemr7779668ljg.8.1667985578370; Wed, 09 Nov 2022 01:19:38 -0800 (PST) Received: from [192.168.0.20] (088156142199.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.199]) by smtp.gmail.com with ESMTPSA id i26-20020a0565123e1a00b00485caa0f5dfsm2142118lfv.44.2022.11.09.01.19.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Nov 2022 01:19:37 -0800 (PST) Message-ID: <85a5d025-e72f-aefa-b748-8c19ff247309@linaro.org> Date: Wed, 9 Nov 2022 10:19:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 6/7] dt-bindings: gpio: add binding for the GPIO block for Apple Mac SMC Content-Language: en-US To: "Russell King (Oracle)" Cc: Linus Walleij , Bartosz Golaszewski , Rob Herring , Lee Jones , Alyssa Rosenzweig , Andy Shevchenko , asahi@lists.linux.dev, devicetree@vger.kernel.org, Hector Martin , Jonathan Corbet , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-gpio@vger.kernel.org, Petr Mladek , Rasmus Villemoes , Sergey Senozhatsky , Steven Rostedt , Sven Peter References: <3d51c0e2-1e59-5767-4be1-5754ca8dc902@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221109_011942_276957_33E93223 X-CRM114-Status: GOOD ( 22.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/11/2022 10:12, Russell King (Oracle) wrote: > On Wed, Nov 09, 2022 at 09:36:12AM +0100, Krzysztof Kozlowski wrote: >> On 08/11/2022 23:09, Russell King (Oracle) wrote: >>> On Tue, Nov 08, 2022 at 09:56:40PM +0100, Krzysztof Kozlowski wrote: >>>> On 08/11/2022 17:33, Russell King (Oracle) wrote: >>>>> Add the DT binding for the Apple Mac System Management Controller GPIOs. >>>>> >>>>> Signed-off-by: Russell King (Oracle) >>>>> --- >>>>> .../bindings/gpio/apple,smc-gpio.yaml | 37 +++++++++++++++++++ >>>>> 1 file changed, 37 insertions(+) >>>>> create mode 100644 Documentation/devicetree/bindings/gpio/apple,smc-gpio.yaml >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/gpio/apple,smc-gpio.yaml b/Documentation/devicetree/bindings/gpio/apple,smc-gpio.yaml >>>>> new file mode 100644 >>>>> index 000000000000..1a415b78760b >>>>> --- /dev/null >>>>> +++ b/Documentation/devicetree/bindings/gpio/apple,smc-gpio.yaml >>>>> @@ -0,0 +1,37 @@ >>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>>> +%YAML 1.2 >>>>> +--- >>>>> +$id: http://devicetree.org/schemas/gpio/gpio-macsmc.yaml# >>>> >>>> Does not look like you tested the bindings. Please run `make >>>> dt_binding_check` (see >>>> Documentation/devicetree/bindings/writing-schema.rst for instructions). >>> >>> Oh ffs. DT bindings are utterly impossible to get correct. >> >> Why? You write, you test and then you see the error. Srsly... > > It's utterly impossible for me to remember the dependencies. It's > utterly impossible for me to remember the make incantation to test > this bloody things - especially as I need to limit it otherwise it > takes a very long time to test. Then this is where I can help - you can test just one, specific binding or few of them: make dt_binding_check DT_SCHEMA_FILES=apple,smc-gpio.yaml make dt_binding_check DT_SCHEMA_FILES=apple,smc So before you format patches, just do `git rebase -i HEAD~7`, change to re-word or edit and go one-by-one testing your bisectability. The same we are always doing for regular kernel builds when having a big patchset, right? Each commit must compile, not just the last one in patchset. Or push each of the commit to a service which can do it for you. For example, for kernel building (not yet ready for DT binding check) I am using something like: https://github.com/krzk/tools/tree/master/git-build-kernel > > The whole bloody thing is just too sodding difficult. > > I'm not going to bother with this patch set any more. Too frustrated > with this piecemeal approach and the crappy slow tooling and the > idiotic incomprehensible error messages it spits out. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel