From: Souradeep Chowdhury <quic_schowdhu@quicinc.com>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Alex Elder <elder@ieee.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<devicetree@vger.kernel.org>,
Sai Prakash Ranjan <quic_saipraka@quicinc.com>,
Sibi Sankar <quic_sibis@quicinc.com>,
Rajendra Nayak <quic_rjendra@quicinc.com>, <vkoul@kernel.org>
Subject: Re: [PATCH V9 1/7] dt-bindings: Added the yaml bindings for DCC
Date: Thu, 15 Sep 2022 17:05:10 +0530 [thread overview]
Message-ID: <85b71c83-feba-bfd8-a60e-585474239485@quicinc.com> (raw)
In-Reply-To: <20220915033540.jb4q4bjd3oomsfl4@builder.lan>
On 9/15/2022 9:05 AM, Bjorn Andersson wrote:
> On Wed, Sep 14, 2022 at 10:31:11PM +0530, Souradeep Chowdhury wrote:
>> Documentation for Data Capture and Compare(DCC) device tree bindings
>> in yaml format.
>>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> Signed-off-by: Souradeep Chowdhury <quic_schowdhu@quicinc.com>
>> ---
>> .../devicetree/bindings/arm/msm/qcom,dcc.yaml | 43 ++++++++++++++++++++++
>> 1 file changed, 43 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml b/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml
>> new file mode 100644
>> index 0000000..b7a6619
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml
>> @@ -0,0 +1,43 @@
>> +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/arm/msm/qcom,dcc.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Data Capture and Compare
>> +
>> +maintainers:
>> + - Souradeep Chowdhury <schowdhu@codeaurora.org>
> Please update your email address.
Ack
>
>> +
>> +description: |
>> + DCC (Data Capture and Compare) is a DMA engine which is used to save
>> + configuration data or system memory contents during catastrophic failure
>> + or SW trigger. DCC is used to capture and store data for debugging purpose
> An empty line inbetween description and properties would be nice.
Ack
>
>> +properties:
>> + compatible:
>> + items:
>> + - enum:
>> + - qcom,sm8150-dcc
>> + - qcom,sc7280-dcc
>> + - qcom,sc7180-dcc
>> + - qcom,sdm845-dcc
>> + - const: qcom,dcc
>> +
>> + reg:
>> + items:
>> + - description: DCC base register region
>> + - description: DCC RAM base register region
>> +
>> +required:
>> + - compatible
>> + - reg
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + dma@10a2000{
>> + compatible = "qcom,sm8150-dcc","qcom,dcc";
>> + reg = <0x010a2000 0x1000>,
>> + <0x010ad000 0x2000>;
> Please remove the double space between address and size.
Ack
>
> Regards,
> Bjorn
>
>
>> + };
>> --
>> 2.7.4
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-15 11:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 17:01 [PATCH V9 0/7] Add driver support for Data Capture and Compare Engine(DCC) for SM8150,SC7280,SC7180,SDM845 Souradeep Chowdhury
2022-09-14 17:01 ` [PATCH V9 1/7] dt-bindings: Added the yaml bindings for DCC Souradeep Chowdhury
2022-09-15 3:35 ` Bjorn Andersson
2022-09-15 11:35 ` Souradeep Chowdhury [this message]
2022-09-15 9:37 ` Krzysztof Kozlowski
2022-09-15 11:36 ` Souradeep Chowdhury
2022-09-15 12:00 ` Rob Herring
2022-09-14 17:01 ` [PATCH V9 2/7] soc: qcom: dcc:Add driver support for Data Capture and Compare unit(DCC) Souradeep Chowdhury
2022-09-15 3:33 ` Bjorn Andersson
2022-09-15 11:32 ` Souradeep Chowdhury
2022-09-14 17:01 ` [PATCH V9 3/7] MAINTAINERS: Add the entry for DCC(Data Capture and Compare) driver support Souradeep Chowdhury
2022-09-14 17:01 ` [PATCH V9 4/7] arm64: dts: qcom: sm8150: Add Data Capture and Compare(DCC) support node Souradeep Chowdhury
2022-09-14 17:01 ` [PATCH V9 5/7] arm64: dts: qcom: sc7280: " Souradeep Chowdhury
2022-09-14 17:01 ` [PATCH V9 6/7] arm64: dts: qcom: sc7180: " Souradeep Chowdhury
2022-09-14 17:01 ` [PATCH V9 7/7] arm64: dts: qcom: sdm845: " Souradeep Chowdhury
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85b71c83-feba-bfd8-a60e-585474239485@quicinc.com \
--to=quic_schowdhu@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=elder@ieee.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_rjendra@quicinc.com \
--cc=quic_saipraka@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).