From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Rob Herring <robh+dt@kernel.org>,
Lee Jones <lee.jones@linaro.org>, Mark Brown <broonie@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: samsung,exynos-adc: add common clock properties
Date: Mon, 15 Feb 2021 10:01:48 +0100 [thread overview]
Message-ID: <85ed4a70-5cd8-3bce-100f-33a1fba7f3fa@samsung.com> (raw)
In-Reply-To: <20210212163816.70058-1-krzk@kernel.org>
Hi Krzysztof,
On 12.02.2021 17:38, Krzysztof Kozlowski wrote:
> Add common properties appearing in DTSes (assigned-clocks and similar)
> to fix dtbs_check warnings like:
>
> arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:
> adc@126c0000: assigned-clock-rates: [[6000000]] is not of type 'object'
> arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:
> adc@126c0000: assigned-clocks: [[7, 238]] is not of type 'object'
Does it mean that assigned-clocks related properties have to be added to
almost all bindings? IMHO this is an over-engineering and this has to be
handled somewhere else...
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> .../bindings/iio/adc/samsung,exynos-adc.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> index c65921e66dc1..ce03132f8ebc 100644
> --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> @@ -27,6 +27,18 @@ properties:
> reg:
> maxItems: 1
>
> + assigned-clocks:
> + minItems: 1
> + maxItems: 3
> +
> + assigned-clock-parents:
> + minItems: 1
> + maxItems: 3
> +
> + assigned-clock-rates:
> + minItems: 1
> + maxItems: 3
> +
> clocks:
> description:
> Phandle to ADC bus clock. For Exynos3250 additional clock is needed.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-15 9:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210212164148eucas1p2ab09436a82d50161ff1a9fc1a169f7d7@eucas1p2.samsung.com>
2021-02-12 16:38 ` [PATCH] dt-bindings: iio: samsung, exynos-adc: add common clock properties Krzysztof Kozlowski
2021-02-15 9:01 ` Marek Szyprowski [this message]
2021-02-15 9:29 ` [PATCH] dt-bindings: iio: samsung,exynos-adc: " Krzysztof Kozlowski
2021-03-05 20:41 ` Rob Herring
2021-03-07 11:44 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85ed4a70-5cd8-3bce-100f-33a1fba7f3fa@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzk@kernel.org \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).