From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10C03C169C4 for ; Mon, 11 Feb 2019 08:50:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CDD4320823 for ; Mon, 11 Feb 2019 08:50:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="r3+lgoAs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDD4320823 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mezd/JLB4cfow4tqyn6upz5E+2GT31HHIwdr32cws0g=; b=r3+lgoAsV6rjma Ue9XaoMpr3+bumabTPRu8ieKRGf1w4DE+IYj/UzIDOtphMbJsouBFrmVgwel7XvyKxZtyHUhccbeV PDGmnYBT+HG54Ho8H3bBGlT3q5XWIggmvEnrqsDLgiOv3A5e4h7VDX7ucoc6KR4bZpq79/cOaJkB4 6nnwi7RxOJJch/LBNDqVLDvxB27gVK3hq8PCn6Sn26VQO3NfNXWgIj5Z+KA74Hh2vXvngnSNT+g+h btrAWMm1ENfOUMnHsjee2EPOcvNAAogvgflke5HU7kNYSWU3ufyxD7By6aak5SXR1K67l4oviD0sM qgQOXq2bZrw+JALRH4EA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gt7Ii-0005KO-Cw; Mon, 11 Feb 2019 08:50:52 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gt7Ie-0005FW-Ek; Mon, 11 Feb 2019 08:50:50 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B8FD480D; Mon, 11 Feb 2019 00:50:44 -0800 (PST) Received: from big-swifty.misterjones.org (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EF2233F575; Mon, 11 Feb 2019 00:50:36 -0800 (PST) Date: Mon, 11 Feb 2019 08:50:27 +0000 Message-ID: <868symu2ss.wl-marc.zyngier@arm.com> From: Marc Zyngier To: Seiya Wang Subject: Re: [PATCH v6 1/6] irqchip/mtk-sysirq: support 4 interrupt parameters for sysirq In-Reply-To: <1549866929.22817.20.camel@mtksdccf07> References: <1548317240-44682-1-git-send-email-erin.lo@mediatek.com> <1548317240-44682-2-git-send-email-erin.lo@mediatek.com> <898ca3d9-002b-e28e-fc97-86bc2538e9de@gmail.com> <626b5b46-aac7-1532-386e-2fed85bf4ad9@arm.com> <1549866929.22817.20.camel@mtksdccf07> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/25.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Organization: ARM Ltd MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190211_005048_552677_6E9EDDD0 X-CRM114-Status: GOOD ( 24.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Jason Cooper , srv_heupstream , Greg Kroah-Hartman , Erin Lo , Stephen Boyd , linux-kernel@vger.kernel.org, Rob Herring , linux-mediatek@lists.infradead.org, linux-serial@vger.kernel.org, mars.cheng@mediatek.com, Matthias Brugger , yingjoe.chen@mediatek.com, Thomas Gleixner , eddie.huang@mediatek.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 11 Feb 2019 06:35:29 +0000, Seiya Wang wrote: > > On Thu, 2019-02-07 at 15:52 +0000, Marc Zyngier wrote: > > On 07/02/2019 15:47, Marc Zyngier wrote: > > > On 07/02/2019 15:20, Matthias Brugger wrote: > > >> > > >> > > >> On 24/01/2019 09:07, Erin Lo wrote: > > >>> From: Seiya Wang > > >>> > > >>> To support partitioned PPIs, 4 interrupt parameters should be valid > > >>> for sysirq. > > >>> > > >>> Signed-off-by: Seiya Wang > > >>> Signed-off-by: Erin Lo > > >>> --- > > >>> drivers/irqchip/irq-mtk-sysirq.c | 4 ++-- > > >>> 1 file changed, 2 insertions(+), 2 deletions(-) > > >>> > > >>> diff --git a/drivers/irqchip/irq-mtk-sysirq.c b/drivers/irqchip/irq-mtk-sysirq.c > > >>> index 90aaf19..282736a 100644 > > >>> --- a/drivers/irqchip/irq-mtk-sysirq.c > > >>> +++ b/drivers/irqchip/irq-mtk-sysirq.c > > >>> @@ -81,7 +81,7 @@ static int mtk_sysirq_domain_translate(struct irq_domain *d, > > >>> unsigned int *type) > > >>> { > > >>> if (is_of_node(fwspec->fwnode)) { > > >>> - if (fwspec->param_count != 3) > > >>> + if (fwspec->param_count != 3 && fwspec->param_count != 4) > > >> > > >> Where is this 4th parameter used? > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt#n14 > > Sorry, I fired Send way too early. > > > > What I wanted to add is that it is not clear to me why this change would > > be required here, as this driver only supports SPIs. It could be fixed > > by just relaxing the binding itself. > > > > Thanks, > > > > M. > > Do you mean that we should change #interrupt-cells back to 3 for sysirq > and remove the 4th parameters of every spi interrupts in mt8183.dtsi > (i.e. 3 parameters for spi, 4 for ppi) such that we can discard this > patch? It is more subtle than that: - PPIs must have the affinity parameter in their int-spec (since you need that for the PMU) - SPIs that are directly routed to the GIC must also have the affinity parameter (although set to zero). - SPIs that are routed via the sysirq block (or any other) can use the 3 parameter variant, as they are not resolved in the context of the GIC, but in that of the sysirq. But in short, yes. You should be able to drop this patch altogether. > If yes, we may need some time to verify the change before resending the > patch. That's absolutely fine. Thanks, M. -- Jazz is not dead, it just smell funny. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel