From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3419CC43381 for ; Thu, 14 Feb 2019 10:55:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 04EC1222A4 for ; Thu, 14 Feb 2019 10:55:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FABIakQY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04EC1222A4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wxqGTmr7WDVojUYQmK+mgb7UQGq07EObi+by9hxjmxY=; b=FABIakQYMlKqBd xcc0NCc6wwQVvKEw53I/YTVg0nzi3ghxyRxZLgjMn1X3VNRcsQtwdg9jdkbljZHaInci8WNXK9lOO McaJZlLoyY11YM/rb2r0XatOEHI6i5WkOFNTxEej+RZ1sUk10qOZJ4Vn3i5QsNWgbDWltO97Pawut oMrMUwIrh9yEaDHwr4cMLmar9L7bTDlFMCEuqFym9FGEkf3b1HUE/VUs0Ssv2fr8e6XxxxOEGbWMr MG/q9+Tw+HMWja/7RmCVHlkOshvcTHYI/9HcjN9gM/q6O9NN3Y87SBuTDoFu4w3geM3i+Q9l+Wvr4 dZJT4zgNZXFaMZ2RwE0Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1guEft-0002jO-Rb; Thu, 14 Feb 2019 10:55:25 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1guEfp-0002fk-Gi for linux-arm-kernel@lists.infradead.org; Thu, 14 Feb 2019 10:55:24 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E7CEDEBD; Thu, 14 Feb 2019 02:55:20 -0800 (PST) Received: from big-swifty.misterjones.org (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9EEE93F575; Thu, 14 Feb 2019 02:55:18 -0800 (PST) Date: Thu, 14 Feb 2019 10:55:15 +0000 Message-ID: <86o97eskq4.wl-marc.zyngier@arm.com> From: Marc Zyngier To: Sekhar Nori Subject: Re: [RESEND PATCH v2 17/33] ARM: davinci: aintc: move timer-specific irq_set_handler() out of irq.c In-Reply-To: References: <20190211122606.8662-1-brgl@bgdev.pl> <20190211122606.8662-18-brgl@bgdev.pl> <67127a57-3d1f-5cf4-efb8-f1a2a49b3a2a@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/25.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Organization: ARM Ltd MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190214_025521_870327_3964A065 X-CRM114-Status: GOOD ( 17.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Lechner , Kevin Hilman , Bartosz Golaszewski , linux-kernel@vger.kernel.org, Bartosz Golaszewski , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Jason Cooper Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 12 Feb 2019 05:51:11 +0000, Sekhar Nori wrote: > > On 11/02/19 6:30 PM, Marc Zyngier wrote: > > On 11/02/2019 12:25, Bartosz Golaszewski wrote: > > >> + /* > >> + * Nobody knows why anymore, but this interrupt has been handled as > >> + * a level irq from the very beginning of davinci support in mainline > >> + * linux. > >> + */ > >> + irq_set_handler(DAVINCI_INTC_IRQ(IRQ_TINT1_TINT34), handle_level_irq); > >> + > > > > Now, the real question is: why isn't that set as part of the > > set_irq_type() callback, instead of hardcoding it in the platform? > > > > This is exactly the kind of information that should come as part of the > > DT or from the driver as one of the request_irq() flags. > > > > It would save quite a bit of boilerplate code. > > True, but I would keep this series feature/bug compatible with existing > code. Without that, tracking regression reports will be a nightmare. Its > a pretty major change already. > > We can (and should) fix this, but I prefer thats done as follow-up patch > after this series is merged. That way a revert is easy. And I'd rather see it done already, as a preliminary to this series. If I'm going to take 35 patches that are mostly churn, surely we can another couple to fix something that is a real bug. > BTW, I don't quite see which in-kernel module uses this interrupt. It > might be some out-of-tree code, or some code that since got removed from > kernel. Yet another reason to fix it now. Thanks, M. -- Jazz is not dead, it just smell funny. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel