From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB910C169C4 for ; Mon, 11 Feb 2019 14:07:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C88C21B1A for ; Mon, 11 Feb 2019 14:07:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="d7Self9Z"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="QuHAGxx0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C88C21B1A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date: In-reply-to:Subject:To:From:References:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=PdEfhEnq3QFit5DHvGHFqNN4ajeMD4GNTsVJQdkK6xo=; b=d7Self9ZjqBCagXeQK3cZcJo0i YaJ7kVGsN3LIHH5DunuPvbbe7yBkD/lEEjI/3p/lrkXA6XJ0bvPSdCADpRMaeaa9fK5iUcnIWrzPn 5X9cckpkYgFPKRsZ80bPbUK3XNTHAjLKuvl9lSC3Dz2BwUIcIXswCZTnvkOhJX7P1+CXxDRtOgYrW bnZUEjBp/fPon1wKJzQtUKnuOTXet+wvJBKOx39vhDTIyixyYk531NR6M+JuN3e2dclKCzHplOncZ Dgpseo/57aAa/awBhYF4ZaRxMdSlhhZlS9woHXVCh+2ftabvtbWbYaYXCDJTnwIAmhfQ6c804kJxQ DtNu0HGA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtCEf-0007v7-QG; Mon, 11 Feb 2019 14:07:01 +0000 Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtCEa-0007tN-FL for linux-arm-kernel@lists.infradead.org; Mon, 11 Feb 2019 14:06:59 +0000 Received: by mail-ed1-x541.google.com with SMTP id y56so8932446edd.11 for ; Mon, 11 Feb 2019 06:06:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=6up0/2CWLW2mHT8pB2BYsiR1F95jgx3Z8tSp/xeu/rY=; b=QuHAGxx0C8NpYb7B2IIFj8pXvOVbJUU98LmlerVAlK4SEzDyUf+EzsLKZwZDPHb0j7 u52euAa/Nl5Azxyzib9EowUim8sdwTS3dHT9Qi35e2+hujzYuCfN45HTaU5cvqCrfShP nEA1cc8F2yKoLAolMcHjSJHuuDQlP7nZDqmAFLJg3G0wX6u629jXNaL8pQiGJ93kMo9q w+BIOlj3ditkPr+cJEgFP6/+z68UfHcZGoz+hITYVwuCgblRY50qqeIgLeubmAJOZ6ku NWDZRdnLdpumiiy3/nGuZ8+jafiQf6rLvwCZCTM4V3/PWL9UF+PvS1iTvL9A7CfgEQot Y/hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=6up0/2CWLW2mHT8pB2BYsiR1F95jgx3Z8tSp/xeu/rY=; b=kABDoy/jBMmrCFlYVihTfQtih4Zfwfo+ZZcYNSXPxf34wqlmScMgeebM3j1cvv+wq0 eUD+OvsGWMmoEQaEnhMnzccOTscXalQFLrPBgeqG/5IGESqmCM5UPvoyu9UzM8cfzHQm YUW0vN0iyrZoY8TR0bPKH9SuTPtsWbA55OL0SF440dJfFmlt0Gn0D9ieHAV16Yw4sxnu kX/8dySvlxTOGx/aZ/tifplcyCC6c/BDAMbJnKNmgSD7hDXE/IivYQTTenwna2HNjuKL +QB8RwxRyfI3pSc1evG1POM8I17NjP4HeIPANXQDWAulak5/qWX8VxFUXZNZp41L/TMM Jj8A== X-Gm-Message-State: AHQUAub73QP9TLHV4CRWzdATAB1uJsm/qpXNDMVWvCyT6DkNnNyiHEK2 TMM7pQw4/8umhA+hcTrwQeNXDqhrei/smsk2 X-Google-Smtp-Source: AHgI3IYdy6zkKwBeQYluvpgQrFC7/eqeirtldBfC4BSiFgEh4fIN7hyHUbaDgMl8civGo2+qRCRIhA== X-Received: by 2002:aa7:d487:: with SMTP id b7mr28130054edr.256.1549894013672; Mon, 11 Feb 2019 06:06:53 -0800 (PST) Received: from localhost ([2620:10d:c092:180::1:7e84]) by smtp.gmail.com with ESMTPSA id t12sm856202ejk.37.2019.02.11.06.06.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Feb 2019 06:06:52 -0800 (PST) References: <1548693481-1162-1-git-send-email-lollivier@baylibre.com> <1548693481-1162-3-git-send-email-lollivier@baylibre.com> <20190130155016.GA26536@bogus> <20190211092251.GV4686@localhost> User-agent: mu4e 1.0; emacs 25.3.2 From: Loys Ollivier To: Johan Hovold Subject: Re: [PATCH v3 2/4] dt-bindings: gnss: add mediatek binding In-reply-to: <20190211092251.GV4686@localhost> Date: Mon, 11 Feb 2019 15:06:50 +0100 Message-ID: <86o97iv2px.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190211_060656_518038_13A5D0DA X-CRM114-Status: GOOD ( 24.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Rob Herring , devicetree@vger.kernel.org, Martin Blumenstingl , Kevin Hilman , Loys Ollivier , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon 11 Feb 2019 at 09:22, Johan Hovold wrote: > On Wed, Jan 30, 2019 at 09:50:16AM -0600, Rob Herring wrote: >> On Mon, Jan 28, 2019 at 05:37:59PM +0100, Loys Ollivier wrote: >> > Add binding for Mediatek-based GNSS receivers. >> > >> > Signed-off-by: Loys Ollivier >> > --- >> > >> > v3: >> > Removed the I2C and SPI interfaces references. >> > Removed the "mediatek,mt3339" compatible line. >> > Added the optional propertied (reset, fix) >> > Added the pin names for the optional properties. >> > >> > v2: >> > Renamed bindings from Globaltop/gtop to Mediatek/mtk. >> > Moved current-speed as an optional propertie. >> > Removed the status line in the example. >> > Added "mediatek,mt3339" compatible. >> > >> > .../devicetree/bindings/gnss/mediatek.txt | 37 ++++++++++++++++++++++ >> > 1 file changed, 37 insertions(+) >> > create mode 100644 Documentation/devicetree/bindings/gnss/mediatek.txt >> > >> > diff --git a/Documentation/devicetree/bindings/gnss/mediatek.txt b/Documentation/devicetree/bindings/gnss/mediatek.txt >> > new file mode 100644 >> > index 000000000000..00650d81c5c8 >> > --- /dev/null >> > +++ b/Documentation/devicetree/bindings/gnss/mediatek.txt >> > @@ -0,0 +1,37 @@ >> > +Mediatek-based GNSS Receiver DT binding >> > + >> > +Mediatek chipsets are used in GNSS-receiver modules produced by several >> > +vendors and can use an UART interface. > > s/an/a/ > ok >> > + >> > +Please see Documentation/devicetree/bindings/gnss/gnss.txt for generic >> > +properties. >> > + >> > +Required properties: >> > + >> > +- compatible : Must be >> > + >> > + "globaltop,pa6h" >> > + >> > +- vcc-supply : Main voltage regulator (pin name: VCC) >> > + >> > +Optional properties: >> > + >> > +- gtop,reset-gpios : GPIO used to reset the device >> > + (pin name: RESET, NRESET) >> >> reset-gpios is the standard name. >> >> > +- gtop,fix-gpios : GPIO used to determine device position fix state >> > + (pin name: FIX, 3D_FIX) > > I'm thinking we might need a standard name for fix-gpios as well. This > isn't a feature that is globaltop (or mediatek) specific, and other > manufacturers provide similar functionality through pins named UI_FIX, > or even LCKIND (lock indicator). > > The pin is typically used to drive an indicator LED AFAIU, but the > characteristics of the signal varies from device to device (fw to fw), > for example, pulse when no lock and low otherwise, or pulse when a 2d or > 3d-fix is acquired, etc. > Yes most GNSS recevivers provide a similar feature even if behavior of the line differs. > I'm not sure how useful the pulsing would be for software, but someone > might find a use for it in some form. > Well it is useful to know when you start acquiring "valid" positionning data. I'm using this as a trigger to start recording position. > Rob, is this something we want to keep in the binding, and if so, how > about using a generic name such as "gnss-fix-gpios"? > Name "gnss-fix-gpios" sounds good to me. Loys > Johan -- -L _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel