Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] ARM: mvebu_v7_defconfig: fix Ethernet on Clearfog
@ 2019-05-17 15:01 Jan Kundrát
  2019-05-17 19:31 ` Gregory CLEMENT
  0 siblings, 1 reply; 14+ messages in thread
From: Jan Kundrát @ 2019-05-17 15:01 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Baruch Siach, Maxime Chevallier, Russell King, Gregory CLEMENT,
	David S. Miller

Compared to kernel 5.1, patches merged for 5.2 added support for A38x'
PHY guarded by a config option which was not enabled by default. As a
result, there was no eth1 and eth2 on a Solid Run Clearfog Base.

Ensure that A38x PHY is enabled on mvebu.

Signed-off-by: Jan Kundrát <jan.kundrat@cesnet.cz>
Cc: Baruch Siach <baruch@tkos.co.il>
Cc: Gregory CLEMENT <gregory.clement@bootlin.com>
Cc: Russell King <rmk+kernel@armlinux.org.uk>
Cc: David S. Miller <davem@davemloft.net>
Cc: Maxime Chevallier <maxime.chevallier@bootlin.com>
---
 arch/arm/configs/mvebu_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/mvebu_v7_defconfig b/arch/arm/configs/mvebu_v7_defconfig
index 48f7b4277b8d..3ac2e84fdeaa 100644
--- a/arch/arm/configs/mvebu_v7_defconfig
+++ b/arch/arm/configs/mvebu_v7_defconfig
@@ -131,6 +131,7 @@ CONFIG_MV_XOR=y
 # CONFIG_IOMMU_SUPPORT is not set
 CONFIG_MEMORY=y
 CONFIG_PWM=y
+CONFIG_PHY_MVEBU_A38X_COMPHY=y
 CONFIG_EXT4_FS=y
 CONFIG_ISO9660_FS=y
 CONFIG_JOLIET=y
-- 
2.21.0



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] ARM: mvebu_v7_defconfig: fix Ethernet on Clearfog
  2019-05-17 15:01 [PATCH] ARM: mvebu_v7_defconfig: fix Ethernet on Clearfog Jan Kundrát
@ 2019-05-17 19:31 ` Gregory CLEMENT
  2019-05-17 19:34   ` Jan Kundrát
  0 siblings, 1 reply; 14+ messages in thread
From: Gregory CLEMENT @ 2019-05-17 19:31 UTC (permalink / raw)
  To: Jan Kundrát, linux-arm-kernel
  Cc: Baruch Siach, Maxime Chevallier, Russell King, David S. Miller

Hi Jan Kundrát,

> Compared to kernel 5.1, patches merged for 5.2 added support for A38x'
> PHY guarded by a config option which was not enabled by default. As a
> result, there was no eth1 and eth2 on a Solid Run Clearfog Base.
>
> Ensure that A38x PHY is enabled on mvebu.
>

Applied on mvebu/arm-5.3

Thanks,

Gregory

> Signed-off-by: Jan Kundrát <jan.kundrat@cesnet.cz>
> Cc: Baruch Siach <baruch@tkos.co.il>
> Cc: Gregory CLEMENT <gregory.clement@bootlin.com>
> Cc: Russell King <rmk+kernel@armlinux.org.uk>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Maxime Chevallier <maxime.chevallier@bootlin.com>
> ---
>  arch/arm/configs/mvebu_v7_defconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/mvebu_v7_defconfig b/arch/arm/configs/mvebu_v7_defconfig
> index 48f7b4277b8d..3ac2e84fdeaa 100644
> --- a/arch/arm/configs/mvebu_v7_defconfig
> +++ b/arch/arm/configs/mvebu_v7_defconfig
> @@ -131,6 +131,7 @@ CONFIG_MV_XOR=y
>  # CONFIG_IOMMU_SUPPORT is not set
>  CONFIG_MEMORY=y
>  CONFIG_PWM=y
> +CONFIG_PHY_MVEBU_A38X_COMPHY=y
>  CONFIG_EXT4_FS=y
>  CONFIG_ISO9660_FS=y
>  CONFIG_JOLIET=y
> -- 
> 2.21.0
>
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] ARM: mvebu_v7_defconfig: fix Ethernet on Clearfog
  2019-05-17 19:31 ` Gregory CLEMENT
@ 2019-05-17 19:34   ` Jan Kundrát
  2019-05-17 19:53     ` Gregory CLEMENT
  0 siblings, 1 reply; 14+ messages in thread
From: Jan Kundrát @ 2019-05-17 19:34 UTC (permalink / raw)
  To: Gregory CLEMENT
  Cc: Baruch Siach, Maxime Chevallier, Russell King, linux-arm-kernel,
	David S. Miller

> Applied on mvebu/arm-5.3

To me this looks like a 5.2 material because it fixes a regression that got 
introduced within the 5.2 cycle. Or did I get the process wrong and this is 
perhaps just a first step?

Cheers,
Jan

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] ARM: mvebu_v7_defconfig: fix Ethernet on Clearfog
  2019-05-17 19:34   ` Jan Kundrát
@ 2019-05-17 19:53     ` Gregory CLEMENT
  2019-05-17 22:50       ` Jan Kundrát
  0 siblings, 1 reply; 14+ messages in thread
From: Gregory CLEMENT @ 2019-05-17 19:53 UTC (permalink / raw)
  To: Jan Kundrát
  Cc: Baruch Siach, Maxime Chevallier, Russell King, linux-arm-kernel,
	David S. Miller

Jan Kundrát <jan.kundrat@cesnet.cz> writes:

>> Applied on mvebu/arm-5.3
>
> To me this looks like a 5.2 material because it fixes a regression that got 
> introduced within the 5.2 cycle. Or did I get the process wrong and this is 
> perhaps just a first step?

Well, this is just about configuration, I don't consider this is
something that is a candidate for a fix.

If there is a regression, then, it is maybe located in the Kconfig
dependency.

Of course I can change my mind with good arguments :)

Gregory

>
> Cheers,
> Jan

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] ARM: mvebu_v7_defconfig: fix Ethernet on Clearfog
  2019-05-17 19:53     ` Gregory CLEMENT
@ 2019-05-17 22:50       ` Jan Kundrát
  2019-05-27 15:57         ` Jan Kundrát
  0 siblings, 1 reply; 14+ messages in thread
From: Jan Kundrát @ 2019-05-17 22:50 UTC (permalink / raw)
  To: Gregory CLEMENT
  Cc: Baruch Siach, Maxime Chevallier, Russell King, linux-arm-kernel,
	David S. Miller

> Well, this is just about configuration, I don't consider this is
> something that is a candidate for a fix.
>
> If there is a regression, then, it is maybe located in the Kconfig
> dependency.
>
> Of course I can change my mind with good arguments :)

Hi Gregory,
I agree that it's just a config bug, but it's also something which can 
silently produce broken systems. If this is not fixed, people building 
their 5.2 kernels will not have working network on Clearfog unless they 
take an extra action. For example, a Buildroot defconfig that's been 
available for quite some time (and which uses just `mvebu_v7_defconfig` for 
kernel) suddenly becomes broken.

Isn't the whole point of the -rc release to find *and* fix bugs early? This 
trivial patch does not introduce any new or untested code. I made a choice 
to test a pre-release kernel, I hit a bug -- no big deal. I found the root 
cause, I sent a trivial fix upstream, and now I'm told by a maintainer that 
they will let the next kernel version, which is about seven -rc releases 
away, be released without a fully functioning network, I am surprised by 
that. I would have understood this better if we were at the final -rc 
stage, but during the merge window? Or is that perhaps a misunderstanding 
and you're planning to send this in time after -rc1?

Cheers,
Jan

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] ARM: mvebu_v7_defconfig: fix Ethernet on Clearfog
  2019-05-17 22:50       ` Jan Kundrát
@ 2019-05-27 15:57         ` Jan Kundrát
  2019-06-11 11:28           ` Gregory CLEMENT
  0 siblings, 1 reply; 14+ messages in thread
From: Jan Kundrát @ 2019-05-27 15:57 UTC (permalink / raw)
  To: Gregory CLEMENT
  Cc: Baruch Siach, Maxime Chevallier, Russell King, linux-arm-kernel,
	David S. Miller

On sobota 18. května 2019 0:50:28 CEST, Jan Kundrát wrote:
>> Well, this is just about configuration, I don't consider this is
>> something that is a candidate for a fix.
>> 
>> If there is a regression, then, it is maybe located in the Kconfig
>> dependency.
>> 
>> Of course I can change my mind with good arguments :)
>
> Hi Gregory,
> I agree that it's just a config bug, but it's also something 
> which can silently produce broken systems. If this is not fixed, 
> people building their 5.2 kernels will not have working network 
> on Clearfog unless they take an extra action. For example, a 
> Buildroot defconfig that's been available for quite some time 
> (and which uses just `mvebu_v7_defconfig` for kernel) suddenly 
> becomes broken.
>
> Isn't the whole point of the -rc release to find *and* fix bugs 
> early? This trivial patch does not introduce any new or untested 
> code. I made a choice to test a pre-release kernel, I hit a bug 
> -- no big deal. I found the root cause, I sent a trivial fix 
> upstream, and now I'm told by a maintainer that they will let 
> the next kernel version, which is about seven -rc releases away, 
> be released without a fully functioning network, I am surprised 
> by that. I would have understood this better if we were at the 
> final -rc stage, but during the merge window? Or is that perhaps 
> a misunderstanding and you're planning to send this in time 
> after -rc1?

Hi Gregory,
was I successful in persuading you that this patch should be included in 
the 5.2 tree, so that Clearfog Base has all three Ethernet interfaces?

With kind regards,
Jan

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] ARM: mvebu_v7_defconfig: fix Ethernet on Clearfog
  2019-05-27 15:57         ` Jan Kundrát
@ 2019-06-11 11:28           ` Gregory CLEMENT
  2019-06-11 14:15             ` Jan Kundrát
  2019-06-11 14:32             ` Russell King - ARM Linux admin
  0 siblings, 2 replies; 14+ messages in thread
From: Gregory CLEMENT @ 2019-06-11 11:28 UTC (permalink / raw)
  To: Jan Kundrát
  Cc: Baruch Siach, Maxime Chevallier, Russell King, linux-arm-kernel,
	David S. Miller

Jan Kundrát <jan.kundrat@cesnet.cz> writes:

> On sobota 18. května 2019 0:50:28 CEST, Jan Kundrát wrote:
>>> Well, this is just about configuration, I don't consider this is
>>> something that is a candidate for a fix.
>>> 
>>> If there is a regression, then, it is maybe located in the Kconfig
>>> dependency.
>>> 
>>> Of course I can change my mind with good arguments :)
>>
>> Hi Gregory,
>> I agree that it's just a config bug, but it's also something 
>> which can silently produce broken systems. If this is not fixed, 
>> people building their 5.2 kernels will not have working network 
>> on Clearfog unless they take an extra action. For example, a 
>> Buildroot defconfig that's been available for quite some time 
>> (and which uses just `mvebu_v7_defconfig` for kernel) suddenly 
>> becomes broken.
>>
>> Isn't the whole point of the -rc release to find *and* fix bugs 
>> early? This trivial patch does not introduce any new or untested 
>> code. I made a choice to test a pre-release kernel, I hit a bug 
>> -- no big deal. I found the root cause, I sent a trivial fix 
>> upstream, and now I'm told by a maintainer that they will let 
>> the next kernel version, which is about seven -rc releases away, 
>> be released without a fully functioning network, I am surprised 
>> by that. I would have understood this better if we were at the 
>> final -rc stage, but during the merge window? Or is that perhaps 
>> a misunderstanding and you're planning to send this in time 
>> after -rc1?
>
> Hi Gregory,
> was I successful in persuading you that this patch should be included in 
> the 5.2 tree, so that Clearfog Base has all three Ethernet interfaces?

Finally I moved the commit from mvebu/arm to mvebu/fixes. I still think
the problem is at driver level, but I didn't take enough time to find
where and we didn't have any feedback from the author of the initila
patch.

So let's try to push it to fixes, I will do the pull request for arm-soc
before end of the week.

Gregory

>
> With kind regards,
> Jan

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] ARM: mvebu_v7_defconfig: fix Ethernet on Clearfog
  2019-06-11 11:28           ` Gregory CLEMENT
@ 2019-06-11 14:15             ` Jan Kundrát
  2019-06-11 14:32             ` Russell King - ARM Linux admin
  1 sibling, 0 replies; 14+ messages in thread
From: Jan Kundrát @ 2019-06-11 14:15 UTC (permalink / raw)
  To: Gregory CLEMENT
  Cc: Baruch Siach, Maxime Chevallier, Russell King, linux-arm-kernel,
	David S. Miller

On úterý 11. června 2019 13:28:32 CEST, Gregory CLEMENT wrote:
> Jan Kundrát <jan.kundrat@cesnet.cz> writes:
>
>> On sobota 18. května 2019 0:50:28 CEST, Jan Kundrát wrote: ...
>
> Finally I moved the commit from mvebu/arm to mvebu/fixes. I still think
> the problem is at driver level, but I didn't take enough time to find
> where and we didn't have any feedback from the author of the initila
> patch.
>
> So let's try to push it to fixes, I will do the pull request for arm-soc
> before end of the week.

Thanks!

Jan

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] ARM: mvebu_v7_defconfig: fix Ethernet on Clearfog
  2019-06-11 11:28           ` Gregory CLEMENT
  2019-06-11 14:15             ` Jan Kundrát
@ 2019-06-11 14:32             ` Russell King - ARM Linux admin
  2019-06-11 15:04               ` Gregory CLEMENT
  1 sibling, 1 reply; 14+ messages in thread
From: Russell King - ARM Linux admin @ 2019-06-11 14:32 UTC (permalink / raw)
  To: Gregory CLEMENT
  Cc: Jan Kundrát, Maxime Chevallier, Baruch Siach,
	linux-arm-kernel, David S. Miller

On Tue, Jun 11, 2019 at 01:28:32PM +0200, Gregory CLEMENT wrote:
> Jan Kundrát <jan.kundrat@cesnet.cz> writes:
> 
> > On sobota 18. května 2019 0:50:28 CEST, Jan Kundrát wrote:
> >>> Well, this is just about configuration, I don't consider this is
> >>> something that is a candidate for a fix.
> >>> 
> >>> If there is a regression, then, it is maybe located in the Kconfig
> >>> dependency.
> >>> 
> >>> Of course I can change my mind with good arguments :)
> >>
> >> Hi Gregory,
> >> I agree that it's just a config bug, but it's also something 
> >> which can silently produce broken systems. If this is not fixed, 
> >> people building their 5.2 kernels will not have working network 
> >> on Clearfog unless they take an extra action. For example, a 
> >> Buildroot defconfig that's been available for quite some time 
> >> (and which uses just `mvebu_v7_defconfig` for kernel) suddenly 
> >> becomes broken.
> >>
> >> Isn't the whole point of the -rc release to find *and* fix bugs 
> >> early? This trivial patch does not introduce any new or untested 
> >> code. I made a choice to test a pre-release kernel, I hit a bug 
> >> -- no big deal. I found the root cause, I sent a trivial fix 
> >> upstream, and now I'm told by a maintainer that they will let 
> >> the next kernel version, which is about seven -rc releases away, 
> >> be released without a fully functioning network, I am surprised 
> >> by that. I would have understood this better if we were at the 
> >> final -rc stage, but during the merge window? Or is that perhaps 
> >> a misunderstanding and you're planning to send this in time 
> >> after -rc1?
> >
> > Hi Gregory,
> > was I successful in persuading you that this patch should be included in 
> > the 5.2 tree, so that Clearfog Base has all three Ethernet interfaces?
> 
> Finally I moved the commit from mvebu/arm to mvebu/fixes. I still think
> the problem is at driver level, but I didn't take enough time to find
> where and we didn't have any feedback from the author of the initila
> patch.

I don't see that there's much that I need to say, and I'm at a total
loss to work out why you think it's a problem at driver level.

Why do you think it's appropriate for mvneta to know whether the a38x
comphy driver is configured for the current kernel or not, given that
mvneta is not exclusively used on Armada 38x systems?

We're already doing the best we can do with ignoring the comphy if
not present; the only case that we defer probe is when
devm_of_phy_get() returns -EPROBE_DEFER, which could mean "the comphy
driver is a module but is not loaded yet" or "the comphy driver has
not been probed yet" - we can't ignore those.

> So let's try to push it to fixes, I will do the pull request for arm-soc
> before end of the week.

That's the correct solution, and it should also have a Fixes: tag on
it.  Unfortunately, keeping the defconfigs up to date is quite a hard
problem unless you have lots of computing power to build and boot all
the defconfigs on all platforms (I don't.)

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] ARM: mvebu_v7_defconfig: fix Ethernet on Clearfog
  2019-06-11 14:32             ` Russell King - ARM Linux admin
@ 2019-06-11 15:04               ` Gregory CLEMENT
  2019-06-11 15:12                 ` Jan Kundrát
  0 siblings, 1 reply; 14+ messages in thread
From: Gregory CLEMENT @ 2019-06-11 15:04 UTC (permalink / raw)
  To: Russell King - ARM Linux admin
  Cc: Jan Kundrát, Maxime Chevallier, Baruch Siach,
	linux-arm-kernel, David S. Miller

Hello Russell King,

> On Tue, Jun 11, 2019 at 01:28:32PM +0200, Gregory CLEMENT wrote:
>> Jan Kundrát <jan.kundrat@cesnet.cz> writes:
>> 
>> > On sobota 18. května 2019 0:50:28 CEST, Jan Kundrát wrote:
>> >>> Well, this is just about configuration, I don't consider this is
>> >>> something that is a candidate for a fix.
>> >>> 
>> >>> If there is a regression, then, it is maybe located in the Kconfig
>> >>> dependency.
>> >>> 
>> >>> Of course I can change my mind with good arguments :)
>> >>
>> >> Hi Gregory,
>> >> I agree that it's just a config bug, but it's also something 
>> >> which can silently produce broken systems. If this is not fixed, 
>> >> people building their 5.2 kernels will not have working network 
>> >> on Clearfog unless they take an extra action. For example, a 
>> >> Buildroot defconfig that's been available for quite some time 
>> >> (and which uses just `mvebu_v7_defconfig` for kernel) suddenly 
>> >> becomes broken.
>> >>
>> >> Isn't the whole point of the -rc release to find *and* fix bugs 
>> >> early? This trivial patch does not introduce any new or untested 
>> >> code. I made a choice to test a pre-release kernel, I hit a bug 
>> >> -- no big deal. I found the root cause, I sent a trivial fix 
>> >> upstream, and now I'm told by a maintainer that they will let 
>> >> the next kernel version, which is about seven -rc releases away, 
>> >> be released without a fully functioning network, I am surprised 
>> >> by that. I would have understood this better if we were at the 
>> >> final -rc stage, but during the merge window? Or is that perhaps 
>> >> a misunderstanding and you're planning to send this in time 
>> >> after -rc1?
>> >
>> > Hi Gregory,
>> > was I successful in persuading you that this patch should be included in 
>> > the 5.2 tree, so that Clearfog Base has all three Ethernet interfaces?
>> 
>> Finally I moved the commit from mvebu/arm to mvebu/fixes. I still think
>> the problem is at driver level, but I didn't take enough time to find
>> where and we didn't have any feedback from the author of the initila
>> patch.
>
> I don't see that there's much that I need to say, and I'm at a total
> loss to work out why you think it's a problem at driver level.
>
> Why do you think it's appropriate for mvneta to know whether the a38x
> comphy driver is configured for the current kernel or not, given that
> mvneta is not exclusively used on Armada 38x systems?
>
> We're already doing the best we can do with ignoring the comphy if
> not present; the only case that we defer probe is when
> devm_of_phy_get() returns -EPROBE_DEFER, which could mean "the comphy
> driver is a module but is not loaded yet" or "the comphy driver has
> not been probed yet" - we can't ignore those.
>
>> So let's try to push it to fixes, I will do the pull request for arm-soc
>> before end of the week.
>
> That's the correct solution, and it should also have a Fixes: tag on
> it.  Unfortunately, keeping the defconfigs up to date is quite a hard
> problem unless you have lots of computing power to build and boot all
> the defconfigs on all platforms (I don't.)

Thanks for the explanation and confirmation. As the issue appeared only
in 5.2-rc1 then it won't be backported and for my point of view the main
interest of Fixes is for the backport, that's I though that not having a
Fixes tag was an issue.

But I don't mind adding a Fixes: tag.

Jan, do you find which exact commit cause this regression?

Thanks,

Gregory

>
> -- 
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
> According to speedtest.net: 11.9Mbps down 500kbps up

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] ARM: mvebu_v7_defconfig: fix Ethernet on Clearfog
  2019-06-11 15:04               ` Gregory CLEMENT
@ 2019-06-11 15:12                 ` Jan Kundrát
  2019-06-11 15:31                   ` Russell King - ARM Linux admin
  0 siblings, 1 reply; 14+ messages in thread
From: Jan Kundrát @ 2019-06-11 15:12 UTC (permalink / raw)
  To: Gregory CLEMENT
  Cc: Baruch Siach, Maxime Chevallier, Russell King - ARM Linux admin,
	linux-arm-kernel, David S. Miller

On úterý 11. června 2019 17:04:38 CEST, Gregory CLEMENT wrote:
> Jan, do you find which exact commit cause this regression?

I have not bisected, but I think that it is due to 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a10c1c8191e04c21769656c2ca8e1c69a6218954

No guarantees there, though.

Cheers,
Jan

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] ARM: mvebu_v7_defconfig: fix Ethernet on Clearfog
  2019-06-11 15:12                 ` Jan Kundrát
@ 2019-06-11 15:31                   ` Russell King - ARM Linux admin
  2019-06-11 15:36                     ` Jan Kundrát
  0 siblings, 1 reply; 14+ messages in thread
From: Russell King - ARM Linux admin @ 2019-06-11 15:31 UTC (permalink / raw)
  To: Jan Kundrát
  Cc: Gregory CLEMENT, David S. Miller, Baruch Siach, linux-arm-kernel,
	Maxime Chevallier

On Tue, Jun 11, 2019 at 05:12:45PM +0200, Jan Kundrát wrote:
> On úterý 11. června 2019 17:04:38 CEST, Gregory CLEMENT wrote:
> > Jan, do you find which exact commit cause this regression?
> 
> I have not bisected, but I think that it is due to https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a10c1c8191e04c21769656c2ca8e1c69a6218954
> 
> No guarantees there, though.

Correct, which means it does need backporting to 5.1, since that was
introduced in the 5.1 merge window.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] ARM: mvebu_v7_defconfig: fix Ethernet on Clearfog
  2019-06-11 15:31                   ` Russell King - ARM Linux admin
@ 2019-06-11 15:36                     ` Jan Kundrát
  2019-06-12  8:44                       ` Gregory CLEMENT
  0 siblings, 1 reply; 14+ messages in thread
From: Jan Kundrát @ 2019-06-11 15:36 UTC (permalink / raw)
  To: Russell King - ARM Linux admin
  Cc: Gregory CLEMENT, David S. Miller, Baruch Siach, linux-arm-kernel,
	Maxime Chevallier

>> I have not bisected, but I think that it is due to 
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a10c1c8191e04c21769656c2ca8e1c69a6218954
>> 
>> No guarantees there, though.
>
> Correct, which means it does need backporting to 5.1, since that was
> introduced in the 5.1 merge window.

...which means that I made a mistake during my initial report. If it's in 
5.1 already, then 5.1 could not have worked for me. Sorry for confusion, 
it's quite possible that I compared 5.2-rcX with 5.0.y.

Jan

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] ARM: mvebu_v7_defconfig: fix Ethernet on Clearfog
  2019-06-11 15:36                     ` Jan Kundrát
@ 2019-06-12  8:44                       ` Gregory CLEMENT
  0 siblings, 0 replies; 14+ messages in thread
From: Gregory CLEMENT @ 2019-06-12  8:44 UTC (permalink / raw)
  To: Jan Kundrát, Russell King - ARM Linux admin
  Cc: Baruch Siach, David S. Miller, linux-arm-kernel, Maxime Chevallier

Jan Kundrát <jan.kundrat@cesnet.cz> writes:

>>> I have not bisected, but I think that it is due to 
>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a10c1c8191e04c21769656c2ca8e1c69a6218954
>>> 
>>> No guarantees there, though.
>>
>> Correct, which means it does need backporting to 5.1, since that was
>> introduced in the 5.1 merge window.
>
> ...which means that I made a mistake during my initial report. If it's in 
> 5.1 already, then 5.1 could not have worked for me. Sorry for confusion, 
> it's quite possible that I compared 5.2-rcX with 5.0.y.

So I added the Fixes tag and correct the commit log, mentioning 5.1
instead of 5.2.

The commit is in mvebu/fixes and for-next on
git://git.infradead.org/linux-mvebu.git and will be part of the Fixes
pull request I will do at the end of the week.

Gregory

>
> Jan
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, back to index

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-17 15:01 [PATCH] ARM: mvebu_v7_defconfig: fix Ethernet on Clearfog Jan Kundrát
2019-05-17 19:31 ` Gregory CLEMENT
2019-05-17 19:34   ` Jan Kundrát
2019-05-17 19:53     ` Gregory CLEMENT
2019-05-17 22:50       ` Jan Kundrát
2019-05-27 15:57         ` Jan Kundrát
2019-06-11 11:28           ` Gregory CLEMENT
2019-06-11 14:15             ` Jan Kundrát
2019-06-11 14:32             ` Russell King - ARM Linux admin
2019-06-11 15:04               ` Gregory CLEMENT
2019-06-11 15:12                 ` Jan Kundrát
2019-06-11 15:31                   ` Russell King - ARM Linux admin
2019-06-11 15:36                     ` Jan Kundrát
2019-06-12  8:44                       ` Gregory CLEMENT

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org infradead-linux-arm-kernel@archiver.kernel.org
	public-inbox-index linux-arm-kernel


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox