linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Frank Li <frank.li@nxp.com>
Cc: Rob Herring <robh@kernel.org>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"kw@linux.com" <kw@linux.com>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	Peng Fan <peng.fan@nxp.com>, Aisheng Dong <aisheng.dong@nxp.com>,
	"jdmason@kudzu.us" <jdmason@kudzu.us>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	dl-linux-imx <linux-imx@nxp.com>, "kishon@ti.com" <kishon@ti.com>,
	"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
	"ntb@lists.linux.dev" <ntb@lists.linux.dev>,
	"lznuaa@gmail.com" <lznuaa@gmail.com>
Subject: Re: [EXT] Re: [PATCH v7 3/4] dt-bindings: irqchip: imx mu work as msi controller
Date: Fri, 26 Aug 2022 19:35:12 +0100	[thread overview]
Message-ID: <871qt2x38f.wl-maz@kernel.org> (raw)
In-Reply-To: <PAXPR04MB9186201A03037BA7DC74D52B88729@PAXPR04MB9186.eurprd04.prod.outlook.com>

On Thu, 25 Aug 2022 22:42:38 +0100,
Frank Li <frank.li@nxp.com> wrote:
> 
> 
> 
> > -----Original Message-----
> > From: Rob Herring <robh@kernel.org>
> > Sent: Thursday, August 25, 2022 4:22 PM
> > To: Frank Li <frank.li@nxp.com>
> > Cc: maz@kernel.org; tglx@linutronix.de; krzysztof.kozlowski+dt@linaro.org;
> > shawnguo@kernel.org; s.hauer@pengutronix.de; kw@linux.com;
> > bhelgaas@google.com; linux-kernel@vger.kernel.org;
> > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> > pci@vger.kernel.org; Peng Fan <peng.fan@nxp.com>; Aisheng Dong
> > <aisheng.dong@nxp.com>; jdmason@kudzu.us; kernel@pengutronix.de;
> > festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>; kishon@ti.com;
> > lorenzo.pieralisi@arm.com; ntb@lists.linux.dev; lznuaa@gmail.com
> > Subject: [EXT] Re: [PATCH v7 3/4] dt-bindings: irqchip: imx mu work as msi
> > controller
> > 
> > Caution: EXT Email
> > 
> > On Mon, Aug 22, 2022 at 10:51:29AM -0500, Frank Li wrote:
> > > I.MX mu support generate irq by write a register. Provide msi controller
> > > support so other driver such as PCI EP can use it by standard msi
> > > interface as doorbell.
> > >
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > ---
> > >  .../interrupt-controller/fsl,mu-msi.yaml      | 98 +++++++++++++++++++
> > >  1 file changed, 98 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/interrupt-
> > controller/fsl,mu-msi.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,mu-
> > msi.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,mu-
> > msi.yaml
> > > new file mode 100644
> > > index 0000000000000..ac07b138e24c0
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,mu-
> > msi.yaml
> > > @@ -0,0 +1,98 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id:
> > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicet
> > ree.org%2Fschemas%2Finterrupt-controller%2Ffsl%2Cmu-
> > msi.yaml%23&amp;data=05%7C01%7CFrank.Li%40nxp.com%7Cbff8f186128d
> > 44209f4108da86dfc975%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> > %7C637970592959950791%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLj
> > AwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%
> > 7C%7C&amp;sdata=DHCOhmaJAhwb8Gl%2FEbPj32B6lR2zcIvyMY%2BTuPACb
> > zI%3D&amp;reserved=0
> > > +$schema:
> > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicet
> > ree.org%2Fmeta-
> > schemas%2Fcore.yaml%23&amp;data=05%7C01%7CFrank.Li%40nxp.com%7
> > Cbff8f186128d44209f4108da86dfc975%7C686ea1d3bc2b4c6fa92cd99c5c3016
> > 35%7C0%7C0%7C637970592959950791%7CUnknown%7CTWFpbGZsb3d8eyJ
> > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%
> > 7C3000%7C%7C%7C&amp;sdata=J4znEXyHnMyQOssSUsoxE2Mlhe2qCDC%2F
> > 9WN6SKv69aM%3D&amp;reserved=0
> > > +
> > > +title: Freescale/NXP i.MX Messaging Unit (MU) work as msi controller
> > > +
> > > +maintainers:
> > > +  - Frank Li <Frank.Li@nxp.com>
> > > +
> > > +description: |
> > > +  The Messaging Unit module enables two processors within the SoC to
> > > +  communicate and coordinate by passing messages (e.g. data, status
> > > +  and control) through the MU interface. The MU also provides the ability
> > > +  for one processor (A side) to signal the other processor (B side) using
> > > +  interrupts.
> > > +
> > > +  Because the MU manages the messaging between processors, the MU
> > uses
> > > +  different clocks (from each side of the different peripheral buses).
> > > +  Therefore, the MU must synchronize the accesses from one side to the
> > > +  other. The MU accomplishes synchronization using two sets of matching
> > > +  registers (Processor A-facing, Processor B-facing).
> > > +
> > > +  MU can work as msi interrupt controller to do doorbell
> > > +
> > > +allOf:
> > > +  - $ref: /schemas/interrupt-controller/msi-controller.yaml#
> > > +
> > > +properties:
> > > +  compatible:
> > > +    enum:
> > > +      - fsl,imx6sx-mu-msi
> > > +      - fsl,imx7ulp-mu-msi
> > > +      - fsl,imx8ulp-mu-msi
> > > +      - fsl,imx8ulp-mu-msi-s4
> > > +
> > > +  reg:
> > > +    items:
> > > +      - description: a side register base address
> > > +      - description: b side register base address
> > > +
> > > +  reg-names:
> > > +    items:
> > > +      - const: processor a-facing
> > > +      - const: processor b-facing
> > 
> > Isn't 'a' and 'b' sufficient to distinguish? Personally, doesn't really
> > look like a case that benefits from -names at all.
> > 
> > In any case, -names shouldn't have spaces.
> 
> I like "a" and "b".
> 
> But Marc Zyngier suggested use above name.
> https://www.spinics.net/lists/linux-pci/msg128783.html
> 
> @Marc Zyngier

And I stand by my initial request. "a" doesn't convey any sort of
useful information. Why not "I" and "II", while we're at it? Or
something even funkier?

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-08-26 19:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-22 15:51 [PATCH v7 0/4] PCI EP driver support MSI doorbell from host Frank Li
2022-08-22 15:51 ` [PATCH v7 1/4] irqchip: allow pass down .pm field at IRQCHIP_PLATFORM_DRIVER_END Frank Li
2022-08-22 15:51 ` [PATCH v7 2/4] irqchip: Add IMX MU MSI controller driver Frank Li
2022-08-22 15:51 ` [PATCH v7 3/4] dt-bindings: irqchip: imx mu work as msi controller Frank Li
2022-08-25 21:21   ` Rob Herring
2022-08-25 21:42     ` [EXT] " Frank Li
2022-08-26 18:35       ` Marc Zyngier [this message]
2022-08-26 18:59         ` Frank Li
2022-08-26 21:44           ` Marc Zyngier
2022-08-29 14:47             ` Frank Li
2022-09-01 14:39               ` Frank Li
2022-09-02 16:35             ` Rob Herring
2022-08-22 15:51 ` [PATCH v7 4/4] PCI: endpoint: Add NTB MSI support Frank Li
2022-08-22 21:32   ` kernel test robot
2022-08-23  0:45   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871qt2x38f.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=aisheng.dong@nxp.com \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=frank.li@nxp.com \
    --cc=jdmason@kudzu.us \
    --cc=kernel@pengutronix.de \
    --cc=kishon@ti.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kw@linux.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=lznuaa@gmail.com \
    --cc=ntb@lists.linux.dev \
    --cc=peng.fan@nxp.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).