From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0810CA9EC0 for ; Mon, 28 Oct 2019 20:57:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C0B2A208C0 for ; Mon, 28 Oct 2019 20:57:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IQioeZPS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C0B2A208C0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=free.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=B3x+0/FOgRBGDM/NjJGg+kSfiukEmxaKC+6W8ScQkw8=; b=IQioeZPSWCn0kt heKZRbb+KuI2NNi6PeMCjwNwiTYcEyubf4/EJ6xgcPNRnDeEV9yiNmpT9wWHxpCi4dsXWFnSxtSOy 7F2JjyNwuCRHw9wWZNTujKOp6rDk4zyDPLU6S4lr3QcucpyNrRXZr5ATz8/nC+MLZzBk0iGydor7Y f4ivjLRw+PZAjfPaoHLr/2PHJm/aDG7r9NWaxSXqRA56awC40Jhx/tGPXgVwbb5Ba4IoTNMoRRvHk Jkn35qdvq+WROQOhaa8JvHBs/VuUQEC+SNO5pylaxU60fqO8zA7gcnzSnxNERZlsMNj7LNXjTRRer 8gumWs5+4BjBxAYstPoA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPC4V-0003PJ-3A; Mon, 28 Oct 2019 20:57:03 +0000 Received: from smtp09.smtpout.orange.fr ([80.12.242.131] helo=smtp.smtpout.orange.fr) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPC4R-0003Om-Iu for linux-arm-kernel@lists.infradead.org; Mon, 28 Oct 2019 20:57:01 +0000 Received: from belgarion ([90.55.204.252]) by mwinf5d17 with ME id K8wx210045TFNlm038wxR7; Mon, 28 Oct 2019 21:56:57 +0100 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Mon, 28 Oct 2019 21:56:57 +0100 X-ME-IP: 90.55.204.252 From: Robert Jarzmik To: Arnd Bergmann Subject: Re: [PATCH 18/46] ARM: pxa: corgi: use gpio descriptors for audio References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-18-arnd@arndb.de> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 28 Oct 2019 21:56:56 +0100 In-Reply-To: <20191018154201.1276638-18-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 18 Oct 2019 17:41:33 +0200") Message-ID: <871ruwmvvr.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/26 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191028_135659_902564_D2A0165D X-CRM114-Status: GOOD ( 15.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Linus Walleij , linux-kernel@vger.kernel.org, Haojian Zhuang , Mark Brown , Daniel Mack , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Arnd Bergmann writes: > The audio driver should not use a hardwired gpio number > from the header. Change it to use a lookup table. > > Cc: Mark Brown > Cc: alsa-devel@alsa-project.org > Signed-off-by: Arnd Bergmann > @@ -41,6 +40,8 @@ > static int corgi_jack_func; > static int corgi_spk_func; > > +struct gpio_desc *gpiod_mute_l, *gpiod_mute_r, *gpiod_apm_on, > *gpiod_mic_bias; Can't this be static ? Otherwise : Acked-by: Robert Jarzmik Cheers. -- Robert _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel