From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C01B1C48BD5 for ; Tue, 25 Jun 2019 13:39:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 89DA92133F for ; Tue, 25 Jun 2019 13:39:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PIloQGd4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 89DA92133F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C+IygMnm+5o7HICP772PJmDFbBtIE7HZuhG18xH4DDw=; b=PIloQGd4iwXMbc VbsYGxOOOXTiwdBtobDqQ7dxN5Ce/kFM3X2IXGX/BKmgHaWBZqR0BsRenVAxuaRHSwXUcCDMN949Q fQ4lwwBiRLH1bSmycy1O2n/s5odaB74bjW62ETb8ZIxduOOyxC/low1YCq7/C3JGfG+LaSRFLpKIz dYVDSRlWYdRqVYC80PQ27sjnp3DbbQLr/LrWBPKdYckj2EOGSUZjofdU7bZgcCqvEwnY9qBrGt1pH 8073qVrFZCQ919tDhtE7bnZi285k62iagj2MhQ/u0WPzLE+I0AppYdniiBpoGmmMvnaVtjhxRH0hz ByQ6mSkS6WHF2h9txitA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hflfJ-0004um-Me; Tue, 25 Jun 2019 13:39:17 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hflfE-0004pb-JD for linux-arm-kernel@lists.infradead.org; Tue, 25 Jun 2019 13:39:14 +0000 X-Originating-IP: 92.137.69.152 Received: from localhost (alyon-656-1-672-152.w92-137.abo.wanadoo.fr [92.137.69.152]) (Authenticated sender: gregory.clement@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 1C7AD4000C; Tue, 25 Jun 2019 13:38:59 +0000 (UTC) From: Gregory CLEMENT To: Linus Walleij , alpawi@amazon.com Subject: Re: [PATCH 0/2] pinctl: armada-37xx: fix for pins 32+ In-Reply-To: References: <20190618160105.26343-1-alpawi@amazon.com> Date: Tue, 25 Jun 2019 15:38:59 +0200 Message-ID: <871rzhlr7w.fsf@FE-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190625_063912_795793_952661A8 X-CRM114-Status: GOOD ( 10.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Benjamin Herrenschmidt , Jason Cooper , Andrew Lunn , "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" , Linux ARM , Sebastian Hesselbarth Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, > On Tue, Jun 18, 2019 at 6:01 PM wrote: > >> From: Patrick Williams >> >> The 37xx GPIO config registers are only 32 bits long and >> span 2 registers for the NB GPIO controller. The function >> to calculate the offset was missing the increase to the >> config register. >> >> I have tested both raw gpio access and interrupts using >> libgpiod utilities on an Espressonbin. >> >> The first patch is a simple rename of a function because >> the original name implied it was doing IO itself ("update >> reg"). This patch could be dropped if undesired. >> >> The second patch contains the fix for GPIOs 32+. First you can add my Acked-by: Gregory CLEMENT Then as the second patch is a fix, you should add the fix tag: "Fixes: 5715092a458c ("pinctrl: armada-37xx: Add gpio support") " as well as the 'CC: " tags. But your change in the first patch made this second patch more difficult to backport. Actually, when I wrote "_update_reg" I was thinking to the update of the variable, whereas with a function named "_calculate_reg" I am expecting having the result as a return of the function. However I am not against your change, as I pointed my main concern is about the backport of the patch to the stable branch. Maybe you could change the order of those 2 patches? Thanks, Gregory > > This looks good overall. I am waiting for a maintainer review. > If nothing happens in a week, poke me and I'll just apply > the patches. > > Yours, > Linus Walleij > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel