From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Baruch Siach <baruch@tkos.co.il>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Baruch Siach <baruch@tkos.co.il>,
Thomas Schreiber <tschreibe@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: clearfog-gt-8k: add wlan_disable signal hog
Date: Sun, 21 Apr 2019 19:25:06 +0200 [thread overview]
Message-ID: <871s1v8e4t.fsf@FE-laptop> (raw)
In-Reply-To: <936a9930fee3f285ee5538205181ca2ef1f5cbe5.1551163571.git.baruch@tkos.co.il>
Hi Baruch,
> From: Thomas Schreiber <tschreibe@gmail.com>
>
> There is currently no DT binding for GPIO rfkill signals. To make
> mini-PCIe attached WiFi devices work, use gpio-hog to hold the
> wlan_disable signal de-asserted.
>
> Signed-off-by: Thomas Schreiber <tschreibe@gmail.com>
> [baruch: add pinctrl node; rename tag]
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Applied on mvebu/dt64
Thanks,
Gregory
> ---
> .../boot/dts/marvell/armada-8040-clearfog-gt-8k.dts | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
> index 2468762283a5..9143aa13ceb1 100644
> --- a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
> @@ -226,6 +226,11 @@
> marvell,function = "gpio";
> };
>
> + cp0_wlan_disable_pins: wlan-disable-pins {
> + marvell,pins = "mpp51";
> + marvell,function = "gpio";
> + };
> +
> cp0_sdhci_pins: sdhci-pins {
> marvell,pins = "mpp55", "mpp56", "mpp57", "mpp58", "mpp59",
> "mpp60", "mpp61";
> @@ -235,7 +240,7 @@
>
> &cp0_pcie0 {
> pinctrl-names = "default";
> - pinctrl-0 = <&cp0_pci0_reset_pins>;
> + pinctrl-0 = <&cp0_pci0_reset_pins &cp0_wlan_disable_pins>;
> reset-gpios = <&cp0_gpio2 0 GPIO_ACTIVE_LOW>;
> status = "okay";
> };
> @@ -253,6 +258,12 @@
> output-low;
> };
>
> + wlan_disable {
> + gpio-hog;
> + gpios = <19 GPIO_ACTIVE_LOW>;
> + output-low;
> + };
> +
> lte_disable {
> gpio-hog;
> gpios = <21 GPIO_ACTIVE_LOW>;
> --
> 2.20.1
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-04-21 17:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 6:46 [PATCH] arm64: dts: clearfog-gt-8k: add wlan_disable signal hog Baruch Siach
2019-04-21 17:25 ` Gregory CLEMENT [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871s1v8e4t.fsf@FE-laptop \
--to=gregory.clement@bootlin.com \
--cc=andrew@lunn.ch \
--cc=baruch@tkos.co.il \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tschreibe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).