From: robert.jarzmik@free.fr (Robert Jarzmik)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Revert "ARM: pxa: call debug_ll_io_init for earlyprintk"
Date: Mon, 06 Oct 2014 23:44:52 +0200 [thread overview]
Message-ID: <871tqkc1pn.fsf@free.fr> (raw)
In-Reply-To: <6310030.SmNYckCtJ4@wuerfel> (Arnd Bergmann's message of "Mon, 06 Oct 2014 23:18:43 +0200")
Arnd Bergmann <arnd@arndb.de> writes:
> On Monday 06 October 2014 16:02:09 Andrew Ruder wrote:
>> On Mon, Oct 06, 2014 at 09:29:36PM +0200, Robert Jarzmik wrote:
>> > Actually, I have a question for Andrew : was your commit aimed at the 3 or 4
>> > available UARTs (ie. in peripheral address space), or is it a case where an
>> > external UART is mapped on the system bus (if that is possible) ?
>>
>> My apologies! I'm actually on a really long-term project of getting my
>> board (similar to zeus board already in the kernel) fully running off of
>> devicetree. For this particular board, all of the UARTS are on the
>> system bus and not the built in ones. But yes - I do see how the
>> built-in UARTS would overlap and hit the BUG_ON on other boards. Any
>> thoughts on a better way of solving this than just reverting the patch
>> back into only working on the built-in UARTs?
>
> I think the best way forward is to make the built-in UARTs work with
> debug_ll_io_init and then apply your patch again.
Yes, and that means revert, right ?
The best approach I'd see for pxa_map_io() would be to call debug_ll_io_init()
conditionally, when the CONFIG_DEBUG_UART_PHYS is defined and is not within the
peripheral bus range, ie. within [ PERIPH_PHYS .. PERIPH_PHYS + PERIPH_SIZE ].
I don't see how to do it without ugly ifdefery though such as :
#if defined(CONFIG_DEBUG_UART_PHYS) && \
((CONFIG_DEBUG_UART_PHYS < PERIPH_PHYS) || (CONFIG_DEBUG_UART_PHYS >=
PERIPH_PHYS + PERIPH_SIZE))
debug_ll_io_init();
#endif
But that's awfull, there should be another better way ...
--
Robert
next prev parent reply other threads:[~2014-10-06 21:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 13:32 [PATCH] Revert "ARM: pxa: call debug_ll_io_init for earlyprintk" Dmitry Eremin-Solenikov
2014-10-06 18:59 ` Robert Jarzmik
2014-10-06 19:29 ` Robert Jarzmik
2014-10-06 21:02 ` Andrew Ruder
2014-10-06 21:18 ` Arnd Bergmann
2014-10-06 21:44 ` Robert Jarzmik [this message]
2014-10-06 21:59 ` Andrew Ruder
2014-10-07 9:18 ` Arnd Bergmann
2014-10-07 19:33 ` Robert Jarzmik
2014-10-07 21:36 ` Arnd Bergmann
2014-10-12 13:37 ` Robert Jarzmik
2014-10-13 22:17 ` Andrew Ruder
2014-10-19 19:19 ` Robert Jarzmik
2014-10-06 21:55 ` Andrew Ruder
2014-10-06 19:30 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871tqkc1pn.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).