From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 099E9C4338F for ; Mon, 9 Aug 2021 10:10:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C0BB16105A for ; Mon, 9 Aug 2021 10:10:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C0BB16105A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W1Xndm3J+nq9tEURy+tL1UBnQYOS1YvbHs2XNMQqsxg=; b=czPCwU4L+VHuPJ XtfC5irkNY0gbqKEo4+uUqDcWyaNTAuL/ZIvmYHTmwGZXpnbhcpS7SlObn2j1L4eZIPH0zx5BS0c4 SiOnOW+AgE2WcmDTCi0uTUQelg27o3PwZdt/g5L4rXOYHRpSX1S0aMWx3D+BO0EPvN+t1JoKZZj5o 55L86EJTV8/QJlSlGFoeBiGyrWqp41l23cKE18ZY+gYtvVjBMce1/o3+YxTmD50ZttKCgVjok0Z3F XReg+NNaN6T/iHTufcJ4XziPJaOgDQax+SvlD4vbtErIP6BO0Bpa5sBcexusFBY1QdVXxw72j3E8f 0w+yLbxFR8uFadnfNDeQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mD2Cs-0009AR-2O; Mon, 09 Aug 2021 10:08:30 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mD2Co-00099Y-J5 for linux-arm-kernel@lists.infradead.org; Mon, 09 Aug 2021 10:08:27 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 131DE6101D; Mon, 9 Aug 2021 10:08:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628503705; bh=wAbasrLWqtdXqVLY0pl1G5ydSmEuc+BxQs28J8KZVE8=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=AD92iTbZl99g8OCmHfAxOd6JDRzNJOnAShfhHnxawg8H59o4h361n0QBJlMqSKYDn ZKBiaUYcvOueeimhb6Mh1oMRr8cQi0etvx2oUZD3DybQ+m9BCxKTvM+ZrqnGxX2lss GFfktQmuUk0bowHouT9IU4b0Eyonn0rgxPG6uwPuFw1kZ8tAYdS62sIvBxoQhLo8Yw cyF5nrMszBtcO8cD8FslzQib8ipXO3B5eaTHdpb6T22uB2Z8Y1/EKpCxWrf2pZkmdP nC6ZPUTrqPh/lnYR4vS5gh7LUvRZN4bJGHS/5q1SSnKn/egNJfa8LbfQNs2IGkkRA2 sb1ez7PeHh78Q== References: <717ddd7c-22cd-d82c-e43d-80254718c801@omp.ru> <3ebcf6ee-4ca7-d7dc-6e04-62bc4f9e1ead@omp.ru> User-agent: mu4e 1.6.2; emacs 27.2 From: Felipe Balbi To: Sergey Shtylyov Subject: Re: [PATCH 3/9] usb: gadget: udc: at91: add IRQ check Date: Mon, 09 Aug 2021 13:07:39 +0300 In-reply-to: <3ebcf6ee-4ca7-d7dc-6e04-62bc4f9e1ead@omp.ru> Message-ID: <8735rjkk16.fsf@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210809_030826_687509_58C21379 X-CRM114-Status: GOOD ( 13.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Ludovic Desroches , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Sergey Shtylyov writes: > The driver neglects to check the result of platform_get_irq()'s call and > blithely passes the negative error codes to devm_request_irq() (which takes > *unsigned* IRQ #), causing it to fail with -EINVAL, overriding an original > error code. Stop calling devm_request_irq() with the invalid IRQ #s. > > Fixes: 8b2e76687b39 ("USB: AT91 UDC updates, mostly power management") > Signed-off-by: Sergey Shtylyov > > --- > drivers/usb/gadget/udc/at91_udc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > Index: usb/drivers/usb/gadget/udc/at91_udc.c > =================================================================== > --- usb.orig/drivers/usb/gadget/udc/at91_udc.c > +++ usb/drivers/usb/gadget/udc/at91_udc.c > @@ -1876,7 +1876,9 @@ static int at91udc_probe(struct platform > clk_disable(udc->iclk); > > /* request UDC and maybe VBUS irqs */ > - udc->udp_irq = platform_get_irq(pdev, 0); > + udc->udp_irq = retval = platform_get_irq(pdev, 0); > + if (retval < 0) > + goto err_unprepare_iclk; let's avoid multiple assignments in one line. How about: if (udc->udp_irq < 0) { retval = udc->udp_irq; goto err_unprepare_iclk; } -- balbi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel