From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5382AC47082 for ; Wed, 26 May 2021 14:12:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 19C3660FD8 for ; Wed, 26 May 2021 14:12:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 19C3660FD8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8bWklUhVSNtHrUDDtmYAe84orhrAo1DdwlxHeU5oKC0=; b=TYSPVYVKfrmeTP pyttopCKZjeeLQD6TX5MA2J0mRlNuoeKFdsmli0SCl/Gqj8UVn25mOOyF7PQ8wi++jI3IUnXLq/PZ clZMYvBcJJl/tcJW/9nSIJiphkaQh3PUvUS4kAdt8RpC8mdJDGxns6nFCXag12QjXS1U3XbmnBotF cPQannWZUTfq2bTZNSVMNQ8QDh29a9aISmD83lNSNmeVCBfyouOlAyBCeFeghnHBGtRIuwYAvWXde mIgMqHwiaEci7eaRuluzCHYPQlnaPfqK2cRXSf/+oFM7VELph7K3centmigYwf3K8QpnDbvLpPU6q 11BvAYLPhB+d2ovXvRhw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lluF0-00EjyM-Kl; Wed, 26 May 2021 14:10:34 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1llsm5-00E2pf-0r for linux-arm-kernel@lists.infradead.org; Wed, 26 May 2021 12:36:39 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 81C611516; Wed, 26 May 2021 05:36:35 -0700 (PDT) Received: from e113632-lin (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F21E63F73B; Wed, 26 May 2021 05:36:32 -0700 (PDT) From: Valentin Schneider To: Peter Zijlstra Cc: Will Deacon , linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Catalin Marinas , Marc Zyngier , Greg Kroah-Hartman , Morten Rasmussen , Qais Yousef , Suren Baghdasaryan , Quentin Perret , Tejun Heo , Johannes Weiner , Ingo Molnar , Juri Lelli , Vincent Guittot , "Rafael J. Wysocki" , Dietmar Eggemann , Daniel Bristot de Oliveira , kernel-team@android.com Subject: Re: [PATCH v7 01/22] sched: Favour predetermined active CPU as migration destination In-Reply-To: References: <20210525151432.16875-1-will@kernel.org> <20210525151432.16875-2-will@kernel.org> <877djlhhmb.mognet@arm.com> Date: Wed, 26 May 2021 13:36:27 +0100 Message-ID: <874kephdtg.mognet@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210526_053637_152912_A28C74E9 X-CRM114-Status: GOOD ( 11.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 26/05/21 14:32, Peter Zijlstra wrote: > On Wed, May 26, 2021 at 12:14:20PM +0100, Valentin Schneider wrote: >> --- >> diff --git a/kernel/sched/core.c b/kernel/sched/core.c >> index 5226cc26a095..cd447c9db61d 100644 >> --- a/kernel/sched/core.c >> +++ b/kernel/sched/core.c > >> @@ -1954,19 +1953,15 @@ static int migration_cpu_stop(void *data) >> if (pending) { >> p->migration_pending = NULL; >> complete = true; >> >> if (cpumask_test_cpu(task_cpu(p), &p->cpus_mask)) >> goto out; >> } >> >> if (task_on_rq_queued(p)) >> + rq = __migrate_task(rq, &rf, p, arg->dest_cpu); > >> @@ -2249,7 +2244,7 @@ static int affine_move_task(struct rq *rq, struct task_struct *p, struct rq_flag >> init_completion(&my_pending.done); >> my_pending.arg = (struct migration_arg) { >> .task = p, >> + .dest_cpu = dest_cpu, >> .pending = &my_pending, >> }; >> >> @@ -2257,6 +2252,7 @@ static int affine_move_task(struct rq *rq, struct task_struct *p, struct rq_flag >> } else { >> pending = p->migration_pending; >> refcount_inc(&pending->refs); >> + pending->arg.dest_cpu = dest_cpu; >> } >> } > > Argh.. that might just work. But I'm thinking we wants comments this > time around :-) This is even more subtle. Lemme stare at it some more and sharpen my quill then. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel