From: Dmitry Safonov <dima@arista.com>
To: Will Deacon <will@kernel.org>
Cc: Petr Mladek <pmladek@suse.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dmitry Safonov <0x7f454c46@gmail.com>,
linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Russell King <linux@armlinux.org.uk>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Jiri Slaby <jslaby@suse.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 09/50] arm64: Add loglvl to dump_backtrace()
Date: Wed, 6 Nov 2019 16:00:09 +0000 [thread overview]
Message-ID: <8750aff1-036b-4604-27ab-5e04c7f9eeb4@arista.com> (raw)
In-Reply-To: <20191106132516.GC5808@willie-the-truck>
On 11/6/19 1:25 PM, Will Deacon wrote:
> On Wed, Nov 06, 2019 at 03:05:00AM +0000, Dmitry Safonov wrote:
[..]
>> @@ -82,12 +82,13 @@ static void dump_kernel_instr(const char *lvl, struct pt_regs *regs)
>> printk("%sCode: %s\n", lvl, str);
>> }
>>
>> -void dump_backtrace(struct pt_regs *regs, struct task_struct *tsk)
>> +void dump_backtrace(struct pt_regs *regs, struct task_struct *tsk,
>> + const char *loglvl)
>> {
>> struct stackframe frame;
>> int skip = 0;
>>
>> - pr_debug("%s(regs = %p tsk = %p)\n", __func__, regs, tsk);
>> + printk("%s%s(regs = %p tsk = %p)\n", loglvl, __func__, regs, tsk);
>
> This one needs to stay as pr_debug().
Makes sense, it's debug rather part of backtrace, will fix.
Thanks,
Dmitry
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-06 16:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191106030542.868541-1-dima@arista.com>
2019-11-06 3:04 ` [PATCH 04/50] arm/asm: Add loglvl to c_backtrace() Dmitry Safonov
2019-11-06 3:04 ` [PATCH 05/50] arm: Add loglvl to unwind_backtrace() Dmitry Safonov
2019-11-06 9:12 ` Russell King - ARM Linux admin
2019-11-06 16:32 ` Dmitry Safonov
2019-11-06 3:04 ` [PATCH 06/50] arm: Add loglvl to dump_backtrace() Dmitry Safonov
2019-11-06 3:04 ` [PATCH 07/50] arm: Wire up dump_backtrace_{entry,stm} Dmitry Safonov
2019-11-06 3:04 ` [PATCH 08/50] arm: Add show_stack_loglvl() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 09/50] arm64: Add loglvl to dump_backtrace() Dmitry Safonov
2019-11-06 13:25 ` Will Deacon
2019-11-06 16:00 ` Dmitry Safonov [this message]
2019-11-06 3:05 ` [PATCH 10/50] arm64: Add show_stack_loglvl() Dmitry Safonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8750aff1-036b-4604-27ab-5e04c7f9eeb4@arista.com \
--to=dima@arista.com \
--cc=0x7f454c46@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mingo@kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).