From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5886C43331 for ; Mon, 30 Mar 2020 21:30:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E035206CC for ; Mon, 30 Mar 2020 21:30:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YS8M4tMk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E035206CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zlkz4IpbYJmFPjJRDboS4BxzHWkoqO6n2eT/FLa4YV0=; b=YS8M4tMkVUJJb3GV2p33mORaz WrtmF8KaevVPlTuLTC/l/iGf9uFHXpnt+5YNTw9UkUAELFb70VIR4hk1GCXrCHP3uPeuGdkLkaH6m qjcxDBQ3VpR8a8ccxJZoyKmhROW1wElUDzI9iR06PRHRRYhGbryZ8LlNNn8VAPU10N7W4NoG/mNzn PTDmeQc74fFyD67M6hqyHFaXP15tKP+1RjHBJP+gVDOAhgdQygCdv8tDwSb4W1lFfVbXc/BHC8E0f FZ2zCXV5fLfIvJJmmFaj+AaP0SSbQ88Ee3950YBRM/PvdnSxL2pJh56HikRWaPJ8IcEWvvnkFHrDe 9v2HHboSw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJ1zj-0002Y8-HW; Mon, 30 Mar 2020 21:30:55 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJ1zg-0002XC-Ck; Mon, 30 Mar 2020 21:30:54 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: aratiu) with ESMTPSA id 32AC5296540 From: Adrian Ratiu To: Ezequiel Garcia Subject: Re: [PATCH v5 4/5] drm: imx: Add i.MX 6 MIPI DSI host platform driver In-Reply-To: <4a9d2d6e5cecbe296c14119d27a8793a7dbed7b2.camel@collabora.com> References: <20200330113542.181752-1-adrian.ratiu@collabora.com> <20200330113542.181752-5-adrian.ratiu@collabora.com> <4a9d2d6e5cecbe296c14119d27a8793a7dbed7b2.camel@collabora.com> Date: Tue, 31 Mar 2020 00:31:56 +0300 Message-ID: <877dz134xf.fsf@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200330_143052_568373_74B9F0A8 X-CRM114-Status: GOOD ( 17.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Jernej Skrabec , Laurent Pinchart , Jonas Karlman , Martyn Welch , Sjoerd Simons , linux-kernel , DRI mailing list , Andrzej Hajda , NXP Linux Team , linux-rockchip@lists.infradead.org, kernel@collabora.com, Fabio Estevam , linux-stm32@st-md-mailman.stormreply.com, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Emil Velikov Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 30 Mar 2020, Ezequiel Garcia wrote: > Hello Fabio, Adrian: > > On Mon, 2020-03-30 at 08:49 -0300, Fabio Estevam wrote: >> Hi Adrian, On Mon, Mar 30, 2020 at 8:34 AM Adrian Ratiu >> wrote: >> > This adds support for the Synopsis DesignWare MIPI DSI v1.01 >> > host controller which is embedded in i.MX 6 SoCs. Based on >> > following patches, but updated/extended to work with existing >> > support found in the kernel: - drm: imx: Support Synopsys >> > DesignWare MIPI DSI host controller >> > Signed-off-by: Liu Ying >> > - ARM: dtsi: imx6qdl: Add support for MIPI DSI host >> > controller >> > Signed-off-by: Liu Ying >> This one looks like a devicetree patch, but this patch does >> not touch devicetree. >> > + ret = clk_prepare_enable(dsi->pllref_clk); + if >> > (ret) { + dev_err(dev, "%s: Failed to enable >> > pllref_clk\n", __func__); + return ret; + >> > } + + dsi->mux_sel = >> > syscon_regmap_lookup_by_phandle(dev->of_node, "fsl,gpr"); + >> > if (IS_ERR(dsi->mux_sel)) { + ret = >> > PTR_ERR(dsi->mux_sel); + dev_err(dev, "%s: >> > Failed to get GPR regmap: %d\n", + >> > __func__, ret); + return ret; >> You should disable the dsi->pllref_clk clock prior to >> returning the error. > > Another approach could be moving the clock on and off to to > component_ops.{bind,unbind} (as rockhip driver does). > > What exactly is the PLL clock needed for? Would it make sense to > move it some of the PHY power on/off? (Maybe not, but it's > worthing checking). > > Also, it seems the other IP blocks have this PLL clock, so maybe > it could be moved to the dw_mipi_dsi core? This could be > something for a follow-up, to avoid creeping this series. Hi Ezequiel, pll is the video reference clock which drives the data lanes and yes all drivers have it as it's a basic requirement, so moving it to the common bridge is indeed a good idea, however this kind of driver refactoring is out of scope for this specific patch series, because, for now, I'd like to get the regmap and the imx6 driver in, once that is done we can think how to further abstract away common logic and slim down the existing drivers further. Basically I just want to avoid feature creep as I expect v6 to be ~ 8 patches big and the series is already over 1200 lines. Thank you, Adrian > > Thanks, > Ezequiel > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel